Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp5180817rwd; Mon, 12 Jun 2023 00:51:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5jCSc0pragBCkQkZuYx45IHmU9Uu4kCuqetHCH0kDFZX47XDlGnzGjRxqVO4iQ8/9ovrQ4 X-Received: by 2002:a05:6a20:8e05:b0:10c:1b38:c89d with SMTP id y5-20020a056a208e0500b0010c1b38c89dmr11695350pzj.2.1686556279944; Mon, 12 Jun 2023 00:51:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686556279; cv=none; d=google.com; s=arc-20160816; b=YrXrVQmBTQ6/zMxQ1lFUXYv9ZtuO/uTpMDIw4pRkNm+eXlus1xsjkgLAruhJcA8X+k 01eluVT5QVvJmILDwm9djrp9HYfhPXrL4cRWy6Dup+q3nvE0CyBHtdU6HGhatXsrC3Bs HHPwaOhAeoKoRY2s219oCDpzTqP/4O4VZs+t9pdFnbuZzpxLIt1TmZ/y+qS5kHilErnh UhRc6OFtY6IHxstTcKn6ScZdNpBYcLPahlCkUUf0wJu9d8Vr2UE03ObkCXYV/dOF7Wwd TP+3O8go+3Sr2bCu3PNdUOTwpHDD2p5/Zjvn8SzaPACQJVtIBguOjyNKlzesrRAu3eiz /axQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=ik2PbxJeEu4cqvcUohHtCee5Rq/H9LRZmejCC0KDr0s=; b=WzMQfXl/2oxcK6T1PjKmJFvHPAfB/4iivAO0atRg4fcMSPz0oW/HIzR09PzxNR1c9t Dzm35rm3gt3u87ZlA6Lhpb9DycLCZWdPinLIVPKJinLk6YWFQyBJ1SnOqaNO2CS4dvgJ j3ZjaSzj+KSdRhZPIazorwt9fG9CHpXik70Zb5vbiMfCzqoE3vM+VxUV/OwVZo3/pr0F frtKja1wBAhEYNWAqVM7zgoY9qn/NCxn084j46heygZOC4/f9ySW8dXv4ow6cRxzfLaX J83iqDvCOPJyUikSqA/AvO5M4ABaXYJWflgdW60V6gOYeHbc6oguH+C54oQ46kHbcK6X NkKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=T1hFFfcO; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 22-20020a630016000000b00543a6cf2b5asi6264136pga.528.2023.06.12.00.51.07; Mon, 12 Jun 2023 00:51:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=T1hFFfcO; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235125AbjFLHmf (ORCPT + 99 others); Mon, 12 Jun 2023 03:42:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235238AbjFLHmY (ORCPT ); Mon, 12 Jun 2023 03:42:24 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 310F4E64 for ; Mon, 12 Jun 2023 00:41:53 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1686555627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ik2PbxJeEu4cqvcUohHtCee5Rq/H9LRZmejCC0KDr0s=; b=T1hFFfcOkNg3PJ1emI8GW0uqLCzD+uDWIrLhPy8ydmDFvMwaSHsz2pN/hU9b+XwSEXALD7 EC4sSqpZeDK/gBTAtUVju851E2SUNRlppBUnfEdYOWxIWLG21Bp0shIUmGdTEp73xg0NTs UVqRAx63Ss2LkRefqtfL0SkV9k9nx2HgdIgBfGCLvUjlUirkbwOjvFjkkR1oQkjx+CX/z/ 5RBC2RBf0E/UzkPgSF697qcxpRHXTfTAbdnk5t/XDNHXzAivBEOO7xTqKca7sf+a8xiejY GjQ9/PQW+QPm77wIYFgoJEQGBoRiMnntRZr2DAOWppTqiKetxl1cYPUW8+wijw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1686555627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ik2PbxJeEu4cqvcUohHtCee5Rq/H9LRZmejCC0KDr0s=; b=tx+F99Qf9FIjomd/q8CPgs5yOTdKVWi3hnQVfa+Bl1Uz0HnO1UH51mjLn3MtM81imH2j+3 USNMNaVBSUsXVKBw== To: Li zeming , jstultz@google.com, sboyd@kernel.org, linux-kernel@vger.kernel.org Cc: Li zeming Subject: Re: [PATCH] time: clocksource-wdtest: Remove unnecessary initialization of variable 'ret' In-Reply-To: <20230613193540.3177-1-zeming@nfschina.com> References: <20230613193540.3177-1-zeming@nfschina.com> Date: Mon, 12 Jun 2023 09:40:26 +0200 Message-ID: <87ttvd6sd1.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Li! On Wed, Jun 14 2023 at 03:35, Li zeming wrote: Can you please pick the proper prefixes and not create random ones. https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#patch-subject > ret is assigned first, so it does not need to initialize the > assignment. This sentence does not make sense. You cannot initialize an assignment. What you want to say is something like this. 'ret' is always assigned before being checked, so initializing the variable is not required. No? Thanks, tglx