Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Lu Hongfei <luhongfei@vivo.com>
To:     Felix Kuehling <Felix.Kuehling@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        amd-gfx@lists.freedesktop.org (open list:AMD KFD),
        dri-devel@lists.freedesktop.org (open list:DRM DRIVERS),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, luhongfei@vivo.com
Subject: [PATCH] gpu: drm/amd: Fix the bug in list_for_each_entry() loops
Date:   Mon, 12 Jun 2023 14:59:54 +0800
Message-Id: <20230612065954.24014-1-luhongfei@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fPgANkFV8H+khGHfBIRG6Z4FTesLLp6VTtRecNVA2zFflEcE99YkavHpVCOd?=
 =?us-ascii?Q?GGo6UAPE1V7b3Rpbb9kv4RleEiiY9ps2VrQTS6cjjoV73mT4rRJl3nUce/TJ?=
 =?us-ascii?Q?wtos1C7ne8qDu/HYk1sszT0v2ElFXpf9hQr0InObe21dFl5f1g3mmF+lyt7Q?=
 =?us-ascii?Q?uvmU0ZJ2+q5rMxc6YsCWhtX4ERLXGX+igpqKespDEzbzAGpOj3hSz/3AxQNu?=
 =?us-ascii?Q?hBkzjv2mCDE6z2m3jbCfoBziPauMkmfg/js/xs/yKdFms1cVSX5LK4bu8FTM?=
 =?us-ascii?Q?eJh0gPag+gjBNE7eQUD3KTvg1e4OVqf9B206tQS6e2uJ/hQT6g8/ayek+LIG?=
 =?us-ascii?Q?w9m2aJvJRVLgdbwsZqa6giniQooooW266yCujNy7w+3qnaKyt3x4UzNEUpIj?=
 =?us-ascii?Q?j1er2pSEfbzbMrh6HnaPTgyV36X703QGi2u/KWgoZLdk1O8QHPGoRkIbbLbi?=
 =?us-ascii?Q?E5f05GVPwMgRYjYvFx2DRmhPEc7B+DY2hanvqkmUuVc4tqgDKTO3hRXiLUjz?=
 =?us-ascii?Q?m3+pGYLZJqiQ+y4BurQQSgHBmW3GkUs0z7qWv2VWYaPV6WKi7tLqmyzYSUgp?=
 =?us-ascii?Q?orcoZYTks4u0fbNMaqb2c5wRh27tzPMW/vVHMEOCZRwDVedaj73kZpdntSqA?=
 =?us-ascii?Q?bWlF/esFpVd8tCG/3L8m6zXvo0A97jrZzNF6lKo5A4sQvSqe9F+mw/bGCJpQ?=
 =?us-ascii?Q?fcQw5upzOJDkEbY+cjLHkZfcExo3EB2qYTKTRTnfF4LMFakca2CUqt88MTMW?=
 =?us-ascii?Q?gVN5PQf0/DODyv9WOCic2wD0O/LUC37Orixy/luxzrm60fsFGKP6w+5izZXO?=
 =?us-ascii?Q?N49nR26afKCqMggwljdzSILSTEO7mhuFZD3jpkFO93RXgEJuGpvxEpUI1yWA?=
 =?us-ascii?Q?wqXqBQ1KlpfpnrRc3JxRzb+MBjcD0J2nkbNY1zg80+lmS6l9otIdioyQba/Y?=
 =?us-ascii?Q?1yHemUGqVeF3S617k1b1Ck08BqzO3cVLy71OzsT5DIU0v/8DPM1ZZ9UuO9y1?=
 =?us-ascii?Q?d/7zIt+lY05CgKpMmOrNaWurbTZWyJjqpDBX9VMnBPtOAeCYX6scJvLNUQrk?=
 =?us-ascii?Q?gI1hasdo0Uov7MIOCaOWH+T2W1xACJxdiY+puXPvpnywchhW8g0jGrjA+7lz?=
 =?us-ascii?Q?4IBCoSOvDJv7mks9BuA/QTPtMt1/ZKr2aYbhkssrPIz14i+3g3qk9h9yl6IW?=
 =?us-ascii?Q?KPAVd8yylcBb5SxdZltFQlTd5pabc7NrGJEoZbUjaI7e5TUoZb2P7q4QLS1X?=
 =?us-ascii?Q?/ke4dr8Z7D2nzyt9ZUM24czVyzPy0hEkufjP/PLunqqjxTqQHETfDqoCMQwT?=
 =?us-ascii?Q?B8uWoRhD1QkLxmKgUcCmkvWHe/5sNBLoqRV9AMDrsJKYKkR13sjoVyvQsBKH?=
 =?us-ascii?Q?VfKJRh9qPedg7g4+YxKjdVifC0RnwvRiGDd4uqfJ+qJ3MDmZS4G0taw0FTfE?=
 =?us-ascii?Q?ScwPRjxkJ2+kay4VxwRIAz3nEJnyu5lOPq32VSAOv9v4uO7qdj7GMH/k5NRG?=
 =?us-ascii?Q?XIwHPcLi7svLIjwxLhT68P8wuLqJeudoo8Km7aaMV38tDPOXtH7HeIQwqDfu?=
 =?us-ascii?Q?bIoneCZfkuKgRTCKp1rlvZdQGkJXmgHAeTlGdEuL?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6341cf40-4fa9-462d-6912-08db6b12a7ca
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB6697.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 07:00:07.4261
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7co9VpFAzS9U5Of9XH0o1hOJOSOfKFiOFi3pez65ISIAMjw91/CIHFR0zO1aXV54ETrn1pesNF9bpLl0rJilWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4081
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

pqn bound in list_for_each_entry loop will not be null, so there is
no need to check whether pqn is NULL or not.
We could remove this check.

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
---
 drivers/gpu/drm/amd/amdkfd/kfd_debug.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_debug.c b/drivers/gpu/drm/amd/amdkfd/kfd_debug.c
index cd34e7aaead4..10d0cef844f0
--- a/drivers/gpu/drm/amd/amdkfd/kfd_debug.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_debug.c
@@ -1097,9 +1097,6 @@ void kfd_dbg_set_enabled_debug_exception_mask(struct kfd_process *target,
 
 	pqm = &target->pqm;
 	list_for_each_entry(pqn, &pqm->queues, process_queue_list) {
-		if (!pqn)
-			continue;
-
 		found_mask |= pqn->q->properties.exception_status;
 	}
 
-- 
2.39.0