Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230609221136.7431-1-chris.paterson2@renesas.com>
In-Reply-To: <20230609221136.7431-1-chris.paterson2@renesas.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Mon, 12 Jun 2023 09:29:15 +0200
Message-ID: <CAMuHMdWV6nBN=W4s2c+xhKu8rwg7JtE1qX=GgO+HbiyOUsV=TA@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: renesas: Fix txdv-skew-psec typo in RZ/G2L
 family smarc-som.dtsi files
To:     Chris Paterson <chris.paterson2@renesas.com>
Cc:     Magnus Damm <magnus.damm@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Biju Das <biju.das@bp.renesas.com>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Tomohiro Komagata <tomohiro.komagata.aj@renesas.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Sat, Jun 10, 2023 at 12:11 AM Chris Paterson
<chris.paterson2@renesas.com> wrote:
> It looks like txdv-skew-psec is a typo from a copy+paste. txdv-skew-psec
> is not present in the PHY bindings nor is it in the driver.
>
> Correct to txen-skew-psec which is clearly what it was meant to be.
>
> Given that the default for txen-skew-psec is 0, and the device tree is
> only trying to set it to 0 anyway, there should not be any functional
> change from this fix.
>
> Fixes: 361b0dcbd7f9 ("arm64: dts: renesas: rzg2l-smarc-som: Enable Ethernet")
> Fixes: 6494e4f90503 ("arm64: dts: renesas: rzg2ul-smarc-som: Enable Ethernet on SMARC platform")
> Fixes: ce0c63b6a5ef ("arm64: dts: renesas: Add initial device tree for RZ/G2LC SMARC EVK")
> Cc: stable@vger.kernel.org # 6.1.y
> Reported-by: Tomohiro Komagata <tomohiro.komagata.aj@renesas.com>
> Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.6.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds