Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Lu Hongfei <luhongfei@vivo.com>
To:     "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org (open list:SCSI TARGET SUBSYSTEM),
        target-devel@vger.kernel.org (open list:SCSI TARGET SUBSYSTEM),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, luhongfei@vivo.com
Subject: [PATCH] drivers: target: Fix the conversion to bool in iblock_execute_pr_out
Date:   Mon, 12 Jun 2023 16:10:06 +0800
Message-Id: <20230612081006.40821-1-luhongfei@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yZlGE32ahR3Jx/mRqa6EQ9bYS6aarU1k9gJrGCb2G8vf9Q5cCafV23zdJfqm?=
 =?us-ascii?Q?Yb+1XZh3hmY+9j8TIGmxmQbjaEZhlw2E+hIJL7Lp/aO12HKTMRXExf2mWy92?=
 =?us-ascii?Q?hAyzeD5QhW3SSXujmkgpgyxHWamBzuATWxu7kkiBV1/HAux7ySfcdD1Meiu3?=
 =?us-ascii?Q?khyzp3XrSOd81vSof+miTmExadRhEXApgUrFiazY1XZ5YQxRHUX8GbYLm4av?=
 =?us-ascii?Q?/GIBU/gysdt0MCIzsJ6xJY/FW5YfbVuLETkwTitRmZST5QJ4p3LNHa6tGtKN?=
 =?us-ascii?Q?8DPe15vPsOK8Lrgi/hRy1RQyicZ3HQXH+WhOXjE+y80/wZyZQqzS05JfwypT?=
 =?us-ascii?Q?RMc3wmkUdqOYOUTMf0USU6ZkB/Tnl/W7hM8yRA+f8qbuI1iPTVb9YOg1TGza?=
 =?us-ascii?Q?n69uYsHB7+EOTEKTPIdPwl+4YLi+U5lAbax3CH4modyzwc6vDUdz8cqkrkz7?=
 =?us-ascii?Q?ZlnpaXjf738Eyfl/7f3kCcLGyGHEYieh3XWoiCn05FuqXYuTPGmbJa1/tKoF?=
 =?us-ascii?Q?yMdZEJGvLaZ6FvvwUzRCiX5CLm9zDe7HXwdKz9sntRwTaXKJd+ovif8M9eu4?=
 =?us-ascii?Q?xKFnM0c0dCOXF4mLs7+DbNahDs0ZsWdpjVc2SR7/JLbCC32OBJxoX4mebWEt?=
 =?us-ascii?Q?pTYy+4UpuJ7HnSsamnvHB8fjCqOtCTkf6xSbqSauUPL0Iq9YeCtYtiFiwuCb?=
 =?us-ascii?Q?cr4Gk+HD/vHowDj3FQw6YEXFNje6Cdl6gPiQv1EXEjgYmtBPOGmFv0Qv/ZB0?=
 =?us-ascii?Q?L8ghMg7U88VGIvrnMvKDYtT9+ypUaseHPkUItHJNiLkAuLGV2cnUtnhPwub3?=
 =?us-ascii?Q?QwxDt7eHrbKpEfTAvS7b9CYZztCZb9/S7WXP80HnHl1fVYtZ9NxXNRcDTyU4?=
 =?us-ascii?Q?DEEFNlVJ9NX3wcR5jtdfX0JzjJiARWNh6dwoscEnjEcMigk4pB86gIgyNr5D?=
 =?us-ascii?Q?BBiHOCfHC84sNibRV+k45Q76sR6RgCXZif7dTsfT8fQvbVwioF3nbRtGXYeY?=
 =?us-ascii?Q?r29R0THPts/iDq8ieIKO+g10axtpLAvqbcUzMwLP5T/599JE46+XzkSkrq0j?=
 =?us-ascii?Q?hwgnMwPm1U/PPhfe5XHfkjEWJAZVL5yWqZ6GD6xumTRwxCO3j/nJwXPbhnL7?=
 =?us-ascii?Q?ZRc1ojFt07EWwEOjEjn/aE8A+ph3HPIP0nDZcTjo7DZjiOaklHSyo5gdOyHh?=
 =?us-ascii?Q?KdzubEvjsZOiL6xRG7ZNHxJG+aZIYMDsZM0HGOVd9EUQ5M3b0V4RuQtmYPvC?=
 =?us-ascii?Q?zW3A853IiNApywiamd1Jq8BZW4fcIKZrgsccBaq/gYY08G8CrvEvifK47A5w?=
 =?us-ascii?Q?qVEepd4q6Ui+vbH0UbquEsY/1uKV0cbgznLiEJ61wszIHSPSrVYVyfh5DGkX?=
 =?us-ascii?Q?FYNo0vji8GPB/3WzDS/nFanlsf83OR9p7nfJWdxerzy/y6aOVfelXbVE/1WS?=
 =?us-ascii?Q?EZM34Ou9FeqCrQZk+teUTRC20QA4dsoHdDlM6NQ1/qFELbLaOtuG/UD3VLLR?=
 =?us-ascii?Q?mzsUgi0ysswRF4ZRxAPQCUdOZhNnSFb4cbkaS9L5lPccc647xPIF4wX9kPfe?=
 =?us-ascii?Q?0LgL2CVYBtMsxAdiCM5+P9e9+LbiVBJ7tlafXVl+?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d5882f15-5fa6-4f56-ca7a-08db6b1c755d
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB6697.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 08:10:17.7394
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H43qYAW4J3DI5jjbcaupx8Zvv/fzviOtQGRZngDY7eQlvxx94Q4zPeSOwINpqcDZxhc53Vvj7KkGNTMemNy+qQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5291
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The return value of the '==' or '!=' operator are bool, so there's
no need to convert it to bool again in iblock_execute_pr_out.

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
---
 drivers/target/target_core_iblock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
index 254c33c9788e..ea42cb5d06d4
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -889,7 +889,7 @@ static sense_reason_t iblock_execute_pr_out(struct se_cmd *cmd, u8 sa, u64 key,
 
 		ret = ops->pr_preempt(bdev, key, sa_key,
 				      scsi_pr_type_to_block(type),
-				      sa == PRO_PREEMPT ? false : true);
+				      sa != PRO_PREEMPT);
 		break;
 	case PRO_RELEASE:
 		if (!ops->pr_clear) {
-- 
2.39.0