Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Jun 2023 11:12:45 +0300
From:   Dan Carpenter <dan.carpenter@linaro.org>
To:     Ricardo Ribalda Delgado <ribalda@chromium.org>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, stable@kernel.org
Subject: Re: [PATCH] ASoC: mediatek: mt8173: Fix error path
Message-ID: <178ec977-5be3-4b2a-bb24-1286be68baf2@kadam.mountain>
References: <20230612-mt8173-fixup-v1-1-81f5c90316d1@chromium.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230612-mt8173-fixup-v1-1-81f5c90316d1@chromium.org>
Precedence: bulk

On Mon, Jun 12, 2023 at 09:49:32AM +0200, Ricardo Ribalda Delgado wrote:
> @@ -1175,14 +1179,11 @@ static int mt8173_afe_pcm_dev_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto err_cleanup_components;
>  
> -	irq_id = platform_get_irq(pdev, 0);
> -	if (irq_id <= 0)
> -		return irq_id < 0 ? irq_id : -ENXIO;
>  	ret = devm_request_irq(afe->dev, irq_id, mt8173_afe_irq_handler,
>  			       0, "Afe_ISR_Handle", (void *)afe);
>  	if (ret) {
>  		dev_err(afe->dev, "could not request_irq\n");
> -		goto err_pm_disable;
> +		goto err_cleanup_components;

Hm...  I hadn't noticed that.  You're right, but I don't think your
patch goes far enough.  I think everything after the first
successful call to snd_soc_add_component() should be goto
err_cleanup_components;

But I am not 100% sure.

regards,
dan carpenter

>  	}
>