Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Jun 2023 16:34:56 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     Sean Christopherson <seanjc@google.com>
CC:     Paolo Bonzini <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, Xiaoyao Li <xiaoyao.li@intel.com>,
        "Pawan Gupta" <pawan.kumar.gupta@linux.intel.com>
Subject: Re: [PATCH 1/2] KVM: x86: Snapshot host's MSR_IA32_ARCH_CAPABILITIES
Message-ID: <ZIbYsBv43EcwLavy@chao-email>
References: <20230607004311.1420507-1-seanjc@google.com>
 <20230607004311.1420507-2-seanjc@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230607004311.1420507-2-seanjc@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OjYk1q9GSbzOaljU0SIg1W67rWpPVAX7frz2z+ZZOwlDbGWNbPOZHvenbJPV?=
 =?us-ascii?Q?szOCAK9Om/+6zurfllJmFqKmUhyi7Y7cgEXwTBo4tYG2MftoIzfKUBCINnLm?=
 =?us-ascii?Q?RnJNfq/bh6p61W88x1VLLtXMTBsfPsQVE9H4EERptzESNObwFOoRp6PtLHle?=
 =?us-ascii?Q?2Ye3wuuJxx3WId1hUMjVZ8Xsa7W/RbnCAP295melNSdp63NiBwBBohy46Fzf?=
 =?us-ascii?Q?a4Z7K/tb57imf5QG87WRkGk/uArKSydjAkyYigFLa4T0Uw4Dgjged0mZ9T2s?=
 =?us-ascii?Q?4sldNKM7PLrojdF2mCmRXgY+Y+G1XlqsEn6jn5zatSvt8dQg0wX2dDD7Jzz5?=
 =?us-ascii?Q?ziIDEYn4sFIw4v8GsmJr7KUw0gHizZji6zlRrP8oXQwMOPhzXFiyYlDHra2x?=
 =?us-ascii?Q?0zg2nGkXF4Zk2Ki+mKIRMgJQizXMyClN6RVQBpdcXWNfxah4RzZfCOMDoTf7?=
 =?us-ascii?Q?/buGlxgCA+hQ8YKViLcIMsQpU6SBQoU8cqc9t7F7laHzXE3UAdReuSpBjBDD?=
 =?us-ascii?Q?Sc9jlqt7GqpaTMIhmj5x1lg05S3f008rxWFSk/IPQnmClL6R5R4tzjekBuuJ?=
 =?us-ascii?Q?InQTJ34nr8ZzYB0Iu5s6JENKBF7PmGfU/eNhwpupYJWZWfdCtIkE8FvgS/XZ?=
 =?us-ascii?Q?97ghKST8nQQql1KwP3mwLfHLCl0YvXyldayQyax7ha2Uxu5Lc3yrF5vSD2Bw?=
 =?us-ascii?Q?mD0Bp+Z4XHTY2Lafdzpp7Xqm9uZMDiVTWmoHFGxzjJjlhJLNRVDlqHvyuVWX?=
 =?us-ascii?Q?BUbc61woe35LEwp2OZSgnkiIeuDS5ShItgK9CylVgVTn0+zC7Hilk2QuJhuu?=
 =?us-ascii?Q?CgrLejJcZwEAFa2+X85+pC4VAVr8761ReWoYK1RD36dWSlhLqVG676kqRz1h?=
 =?us-ascii?Q?ZWTkTujs2x3GZFmDTfcAFz6f05ixLWFlYeI7jHo42UgHfQe3l7o/e8+zXw2r?=
 =?us-ascii?Q?mk9wPIodvvACReMRAY3ThPZ7PidslvJ3ghhfrS59R7/fFJN42ZPeb21Oouxg?=
 =?us-ascii?Q?AMyGNmVULexFf/cR9gUZgme8IkUI6vfNc2SpbhB9VMafIeMkceNgnphCvjm6?=
 =?us-ascii?Q?aKwb8Cnhk6e5HXtGwqzOc7hkgt1H7T6wO8Z0hHUuRSHDw2VT/sjJ/IjzsSQQ?=
 =?us-ascii?Q?A+Ozi9kgps9QRJP6jpGbPxBVqsBe6J7xmMtVdfAV3lIOm5WqQRx6F2CsX658?=
 =?us-ascii?Q?M4IeDWg25DKa7Oh/NeCTnIRElDMugJdgcNWKyd2aJmqq6eKtvnuH1cLK6D2Y?=
 =?us-ascii?Q?hRyFGfR3Jm8V5peG2VlcukAw7l2ztOvojNeauz+a5FT00DNaWn0tJnQUX/t0?=
 =?us-ascii?Q?DTYRCLjOuSL5DFJdYXZDFObVlnXgM1jLIpCipzATFnZ2IS6HCY9hklD1ndIr?=
 =?us-ascii?Q?7TXiCzekUx2BGGb3bEk9DZ6u7nURpcu8DpZOAZlHnTor0tJ3tzKE/O9inHPa?=
 =?us-ascii?Q?Krm7J/G3kat9+sWo80D/z5/qx8OdwHWbPeds1v1mk8UNPlCI2DVHZo2tDw52?=
 =?us-ascii?Q?yoSJS8fuVDqzvlOLa6RG/Lwxy7uKyo2dJNXIh6F5XA5q4xwbmAmb5JXthOug?=
 =?us-ascii?Q?5/LMRbngQOmcFxPXyHxU6NOg+fujVILY/emsVI8/?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 57046e16-b2b6-45da-02df-08db6b1fec65
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6780.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 08:35:05.9901
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Rk6Rvf43+ntq179NNni+VfjKD6ROwMNIAMpxvEAg34XPt+eEKI7YjX7UiexyBQ6ARXU8oMnxiuxzKfNotj57bg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6224
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 06, 2023 at 05:43:09PM -0700, Sean Christopherson wrote:
>Snapshot the host's MSR_IA32_ARCH_CAPABILITIES, if it's supported, instead
>of reading the MSR every time KVM wants to query the host state, e.g. when
>initializing the default value during vCPU creation.  The paths that query
>ARCH_CAPABILITIES aren't particularly performance sensitive, but creating
>vCPUs is a frequent enough operation that burning 8 bytes is a good
>trade-off.
>
>Alternatively, KVM could add a field in kvm_caps and thus skip the
>on-demand calculations entirely, but a pure snapshot isn't possible due to
>the way KVM handles the l1tf_vmx_mitigation module param.  And unlike the
>other "supported" fields in kvm_caps, KVM doesn't enforce the "supported"
>value, i.e. KVM treats ARCH_CAPABILITIES like a CPUID leaf and lets
>userspace advertise whatever it wants.  Those problems are solvable, but
>it's not clear there is real benefit versus snapshotting the host value,
>and grabbing the host value will allow additional cleanup of KVM's
>FB_CLEAR_CTRL code.
>
>Link: https://lore.kernel.org/all/20230524061634.54141-2-chao.gao@intel.com
>Cc: Chao Gao <chao.gao@intel.com>
>Cc: Xiaoyao Li <xiaoyao.li@intel.com>
>Signed-off-by: Sean Christopherson <seanjc@google.com>

Reviewed-by: Chao Gao <chao.gao@intel.com>