Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d63da17e-78cf-22ec-a134-a2a2b4bf52e4@redhat.com>
Date:   Mon, 12 Jun 2023 11:21:24 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] scripts: fix the gfp flags header path in gfp-translate
Content-Language: en-US
To:     Prathu Baronia <prathubaronia2011@gmail.com>,
        akpm@linux-foundation.org, masahiroy@kernel.org,
        linux-kernel@vger.kernel.org
Cc:     linux-mm@kvack.org, nathan@kernel.org, ndesaulniers@google.com,
        nicolas@fjasle.eu
References: <20230608154450.21758-1-prathubaronia2011@gmail.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <20230608154450.21758-1-prathubaronia2011@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 08.06.23 17:44, Prathu Baronia wrote:
> Since gfp flags have been shifted to gfp_types.h so update the path in
> the gfp-translate script.
> 
> Signed-off-by: Prathu Baronia <prathubaronia2011@gmail.com>
> ---
>   scripts/gfp-translate | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/gfp-translate b/scripts/gfp-translate
> index b2ce416d944b..6c9aed17cf56 100755
> --- a/scripts/gfp-translate
> +++ b/scripts/gfp-translate
> @@ -63,11 +63,11 @@ fi
>   
>   # Extract GFP flags from the kernel source
>   TMPFILE=`mktemp -t gfptranslate-XXXXXX` || exit 1
> -grep -q ___GFP $SOURCE/include/linux/gfp.h
> +grep -q ___GFP $SOURCE/include/linux/gfp_types.h
>   if [ $? -eq 0 ]; then
> -	grep "^#define ___GFP" $SOURCE/include/linux/gfp.h | sed -e 's/u$//' | grep -v GFP_BITS > $TMPFILE
> +	grep "^#define ___GFP" $SOURCE/include/linux/gfp_types.h | sed -e 's/u$//' | grep -v GFP_BITS > $TMPFILE
>   else
> -	grep "^#define __GFP" $SOURCE/include/linux/gfp.h | sed -e 's/(__force gfp_t)//' | sed -e 's/u)/)/' | grep -v GFP_BITS | sed -e 's/)\//) \//' > $TMPFILE
> +	grep "^#define __GFP" $SOURCE/include/linux/gfp_types.h | sed -e 's/(__force gfp_t)//' | sed -e 's/u)/)/' | grep -v GFP_BITS | sed -e 's/)\//) \//' > $TMPFILE
>   fi
>   
>   # Parse the flags
> 
> base-commit: 44c026a73be8038f03dbdeef028b642880cf1511

Yes, works for me then

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb