Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Valentin Schneider <vschneid@redhat.com>
To:     Li zeming <zeming@nfschina.com>, mingo@redhat.com,
        peterz@infradead.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
        bristot@redhat.com
Cc:     linux-kernel@vger.kernel.org, Li zeming <zeming@nfschina.com>
Subject: Re: [PATCH] sched: rt: Remove unnecessary =?utf-8?B?4oCYTlVMTA==?=
 =?utf-8?B?4oCZ?= values from push_task
In-Reply-To: <20230510235417.3061-1-zeming@nfschina.com>
References: <20230510235417.3061-1-zeming@nfschina.com>
Date:   Mon, 12 Jun 2023 10:21:24 +0100
Message-ID: <xhsmhttvdxch7.mognet@vschneid.remote.csb>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On 11/05/23 07:54, Li zeming wrote:
> push_task is assigned first, so it does not need to initialize the
> assignment.
>
> Signed-off-by: Li zeming <zeming@nfschina.com>

Subject would be clearer as "Remove unnecessary initialization", but
regardless:

Reviewed-by: Valentin Schneider <vschneid@redhat.com>

> ---
>  kernel/sched/rt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> index 662c565745fd..55e480d5174a 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -2073,7 +2073,7 @@ static int push_rt_task(struct rq *rq, bool pull)
>       }
>
>       if (is_migration_disabled(next_task)) {
> -		struct task_struct *push_task = NULL;
> +		struct task_struct *push_task;
>               int cpu;
>
>               if (!pull || rq->push_busy)
> --
> 2.18.2