Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <15095aec-4ed3-c16b-55b3-e7122652a897@redhat.com>
Date:   Mon, 12 Jun 2023 11:15:38 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] memory tier: remove unneeded
 !IS_ENABLED(CONFIG_MIGRATION) check
Content-Language: en-US
To:     Miaohe Lin <linmiaohe@huawei.com>, akpm@linux-foundation.org
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20230610034114.981861-1-linmiaohe@huawei.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <20230610034114.981861-1-linmiaohe@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10.06.23 05:41, Miaohe Lin wrote:
> establish_demotion_targets() is defined while CONFIG_MIGRATION is
> enabled. There's no need to check it again.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
>   mm/memory-tiers.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
> index dd04f0ce5277..a516e303e304 100644
> --- a/mm/memory-tiers.c
> +++ b/mm/memory-tiers.c
> @@ -366,7 +366,7 @@ static void establish_demotion_targets(void)
>   
>   	lockdep_assert_held_once(&memory_tier_lock);
>   
> -	if (!node_demotion || !IS_ENABLED(CONFIG_MIGRATION))
> +	if (!node_demotion)
>   		return;
>   
>   	disable_all_demotion_targets();

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb