Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp5290758rwd; Mon, 12 Jun 2023 02:56:46 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7SP4DoWcImBOjvwDtvofKF5JC2tEX9lC8Y3dqGizIgmlf0zISzgufrySYQgmygwB8CiSH1 X-Received: by 2002:a19:5619:0:b0:4f3:8196:80cb with SMTP id k25-20020a195619000000b004f3819680cbmr3574093lfb.41.1686563806264; Mon, 12 Jun 2023 02:56:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686563806; cv=none; d=google.com; s=arc-20160816; b=Uc6YdrzQtOUlCrAJZrPRXShPjeXhhAC2uxEJl52mSLlhJWfVTcD3/VSkI04eMBIxie xfx6TPCQD3HFNziN0346/Xr7nM5+yR/8Xh1lD6/tFppMNKMoK6H3mId7s/23NcK84zQH PROTAbTO2IcsS9SmIwsUcgiyZj6Zi4thp+LYDhm7P0Ij+4uDwc2YbV+zaM25bUW8lQxH 2u4gLNwWeEXz/QS7P01MvQnUpmdngu2kDf7zFMLUNDHUZ9HvVmQPIBJyL0YvJ549YVNj 7KSYAfbiQxfgRWTnaGhJKKzdLxGWqm6WxaEeC6TaCfm/+JglA3JF6TMMAVj7cHRng6Fw 6voQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fNA3pQAUnl5SwQH9eSGE6UJxUpnHbr8UA8zS8MrGEdo=; b=rpOUsJ+xVDM6vJMwDMNwqVJSxm8nStlAwfn83TFiS/kBY9N8toMl2EIHZV5ARTkhcu Y2/TytP6ukI7Yp2FyOhFwQEqCuWHFw4XXiPsCF8aeUmNuWiC3PHSvhuXhtEbT99DNs8m Iqes3xbiK6ky0AayavuX1h659zy1Vv9aUXwuKic1FeIs6QqzEH046Ch3nH9yAxMXu0HS dyismszOTHRpWdaPK+Jk1OsZZNMcCY70mXa/M3zHMm8oW97o+pfrYB/Q3ZIevfOCZF9w 12HLfvbtCV41QIQBIjTGcnyPpNuP42tSAwGK/MwtbWdDqtEFKJbasAZZeSwuEoJN8XtW uOAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=S9ulLI6a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m12-20020aa7c48c000000b0050bc36f514csi5389774edq.651.2023.06.12.02.56.09; Mon, 12 Jun 2023 02:56:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=S9ulLI6a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230141AbjFLJtS (ORCPT + 99 others); Mon, 12 Jun 2023 05:49:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232296AbjFLJr6 (ORCPT ); Mon, 12 Jun 2023 05:47:58 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 658E1558A for ; Mon, 12 Jun 2023 02:34:37 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-977c72b116fso623753966b.3 for ; Mon, 12 Jun 2023 02:34:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686562402; x=1689154402; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fNA3pQAUnl5SwQH9eSGE6UJxUpnHbr8UA8zS8MrGEdo=; b=S9ulLI6aWH4YWOkhKy47/q5SnI1L9ABRfn9txvV/Rsl022Krs+53C3JV7sEWiYQuEj akU7FdTk4tPqBllOX7IAHz+cIfLrZVbm+bP19ATMoSJhrSVqvsQ7IhS0prPCXfrcOH+N cj/XVwC94HuYfCB8ipUqNXkTUoNn0mEldWY7CKroL8ISzKQLn1BDUnV8yxbn1RRfD2xt O12oxCShyKkaPF9KAvflSvkKeXkJhfN84RWZSqzpDjD8QUoz8B+iufd5hBu9n75udRgF A+gGTT7/SSP19Ie9y4GiFCaO1c95Cd1P5uFDjryYCx5oc0PQyLjVCJVUGcm+gNRNz3JH s/UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686562402; x=1689154402; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fNA3pQAUnl5SwQH9eSGE6UJxUpnHbr8UA8zS8MrGEdo=; b=ja/M/6KbW+DSy73p09Q92Sb2MQLDuwOTivWaidpwkLG4alXuEUA61+QfNidOVu0EWb yJjGpbSUISF7xUPCbFbgFe8Bd0vOtqYm7aBT66L5Z4iv57xkpKdE5NMNOOVS4n92VKnC /CZlK32VRjXn2sMuP2YGpXW/98ddPULXGR60dL8pxNKJEZb3KU6gjNQLgxr1wRKZXTya tqL8C7r/CQsAC00IHni6mSaMYKZlVEPfrLeix2GuDxVLMrU7nRYRLaDLmEtiRJoB4Mbl R2CZADEUw9L8N3scA6UlZ1wXIqp5Qd4WYFyhwDd42iVTcCN8FDdibNsaujJUjlqe7fj5 Vb6w== X-Gm-Message-State: AC+VfDyElvbr2MKS8iOsAj19XYbGEOIBirTWd/gxy1YGBy1mikcvJMmE JRrHoB4yLP3ljuLqFoN6+gaKlg== X-Received: by 2002:a17:907:7da9:b0:973:946d:96ba with SMTP id oz41-20020a1709077da900b00973946d96bamr8620449ejc.69.1686562402724; Mon, 12 Jun 2023 02:33:22 -0700 (PDT) Received: from hackbox.lan ([86.121.163.20]) by smtp.gmail.com with ESMTPSA id gj13-20020a170906e10d00b00965a56f82absm4908151ejb.212.2023.06.12.02.33.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 02:33:22 -0700 (PDT) From: Abel Vesa To: Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Jesse Taube , Kai Ma Cc: hust-os-kernel-patches@googlegroups.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: imx: clk-imxrt1050: fix memory leak in imxrt1050_clocks_probe Date: Mon, 12 Jun 2023 12:32:37 +0300 Message-Id: <168656228136.662397.997641301782961079.b4-ty@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230418113451.151312-1-kaima@hust.edu.cn> References: <20230418113451.151312-1-kaima@hust.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 18 Apr 2023 11:34:51 +0000, Kai Ma wrote: > Use devm_of_iomap() instead of of_iomap() to automatically > handle the unused ioremap region. If any error occurs, regions allocated by > kzalloc() will leak, but using devm_kzalloc() instead will automatically > free the memory using devm_kfree(). > > Also, fix error handling of hws by adding unregister_hws label, which > unregisters remaining hws when iomap failed. > > [...] Applied, thanks! [1/1] clk: imx: clk-imxrt1050: fix memory leak in imxrt1050_clocks_probe commit: 1b280598ab3bd8a2dc8b96a12530d5b1ee7a8f4a Best regards, -- Abel Vesa