Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Jun 2023 11:49:57 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Bobby Eshleman <bobby.eshleman@bytedance.com>
Cc:     Stefan Hajnoczi <stefanha@redhat.com>,
        Stefano Garzarella <sgarzare@redhat.com>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Jason Wang <jasowang@redhat.com>,
        Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
        Bryan Tan <bryantan@vmware.com>,
        Vishnu Dasa <vdasa@vmware.com>,
        VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
        Dan Carpenter <dan.carpenter@linaro.org>,
        Krasnov Arseniy <oxffffaa@gmail.com>, kvm@vger.kernel.org,
        virtualization@lists.linux-foundation.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org,
        bpf@vger.kernel.org
Subject: Re: [PATCH RFC net-next v4 4/8] vsock: make vsock bind reusable
Message-ID: <ZIbqRXYMbYsdq874@corigine.com>
References: <20230413-b4-vsock-dgram-v4-0-0cebbb2ae899@bytedance.com>
 <20230413-b4-vsock-dgram-v4-4-0cebbb2ae899@bytedance.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230413-b4-vsock-dgram-v4-4-0cebbb2ae899@bytedance.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2lwW5HCcQLNa/S+M3zGbCXFxvCAKc2WDtM4e7Oc3qbySL/DEMqxFeg5EsTfM?=
 =?us-ascii?Q?dZaXTX57PRvNW7ftYHqZICb7hWUA5kC2VaCY/EPqrjL491QxUtaL1e/x82n3?=
 =?us-ascii?Q?9QB00BPIPW44D8BvFhFGoFAbctUkm+JOPCoGrLR6ZnZZeGeHR79mEs7wTg1J?=
 =?us-ascii?Q?ysxCriSpxUe5sbF/aRE+ZzmKxWJzMfJqOHEszo0Vhl/9nZvJ6RbP/TirQyMo?=
 =?us-ascii?Q?T7svj7gg0GcQcsasZKBkC37GzBTp3hPkLx/B66ohktROCmojwCHA2HYUBcpK?=
 =?us-ascii?Q?dAKCgAAvc/dqlfAEHQ1FIw8ERMDpFRMf+ycduwRhQWKrpEqPb2lKIWgjsZlM?=
 =?us-ascii?Q?qbEjs03XpTWyiT78w4RolGkNfPGEDdTCEpZQVxjMQ55bzzKOIB8v3glfi9BL?=
 =?us-ascii?Q?cG8FEAcQVxYwi66/TmVdoBd79mi1HzGIpfUJzA1mF6dTdwQQRacD+9zc+0Nh?=
 =?us-ascii?Q?GoZc93FXyiJ+BItyYSSgONLnoqw9WZqByRjf0LZTVUdM+MdSm0Hr3uDHdHoL?=
 =?us-ascii?Q?c6hCG6KzrrJ6WcqKH3/hpI4X8qxETTwFTUDIMpo+0mU8p55ZD/iJT4irhBsl?=
 =?us-ascii?Q?DwxDcrrfQ22QQUeh7dTzDE/QoVcmPmrGt364F0xvlyD1dj9GUE9Ndcw22n0l?=
 =?us-ascii?Q?M0ardOrKKR868pir3UyKvYVbZyKaMgFUiv7f3DRWqbAJpqf1IKie8LkbRZRG?=
 =?us-ascii?Q?sSmI8ZIsrSvN5mjPUAyXMrOmcBLVxkwBDpPyYypJ7ZmmwGAfmsN4YgnhGSOs?=
 =?us-ascii?Q?z9wKfiQDrT5GZsvEtX4WIbtSyf3j9AcmKik0MzWNFQY2/2aUkuyLqJL5F/Ds?=
 =?us-ascii?Q?NXH6FwN1EK1CpKt25GW/WRA05MssvvFBC1Ms3OU6RU5ilfeRsmMkWQjynnSq?=
 =?us-ascii?Q?DWLaUSo0OANiQ2xKeiLEhQFSMF9axie5FABGELQ4yIGgD9mhqFvPvyzC00mI?=
 =?us-ascii?Q?L6S8PxlHIi94tLJJwehQ8JWzTwnxiZwrGlmTlmT597HolXnQbFxMvrh6tNUq?=
 =?us-ascii?Q?Z6lS2REAHvo8HVaelASaSLY52ogtcYlfdYxySgrVJHyQWXm0+CyaRpPh5ixS?=
 =?us-ascii?Q?KkV+MtDge3uKK23N3gN5J4TBwGf4268/D56ngfPAqh2gOgdUmhGsbQX5jfEb?=
 =?us-ascii?Q?84Od8dkeWAGqLBSqomhYaVvjvTYiGA0K6ewbyGpiSXM+YYpYx4A0cH03VYPD?=
 =?us-ascii?Q?FCeQJVN3QDNey3TOtW6F02C0sraQ6686Lwy0tviF1Nm88KY7rcxZJ1V6QuxQ?=
 =?us-ascii?Q?Fkd9cBgaN2/Ndu1a+QAeDShdlRNsqwHpQzZmn0kRflXr4nSQc1gwjVhrApVX?=
 =?us-ascii?Q?zvnpZOsPkyo6MB/tklapgzmOXoLYb8o4oKVNo6d2ZXZr38PGNkD0jvR3donr?=
 =?us-ascii?Q?WHA15kvbxcRaR0S00Gqsj/nVBcfDhSZiLCMnSpK118NBy06leLoPJ3eH+HRs?=
 =?us-ascii?Q?STwo/EfrmX4S1N/CrJcyXbUVhVXdC33Dzi8PknfY8LhzsaYXZwSrSS6bU2S5?=
 =?us-ascii?Q?J4TC2112IjdD/cvQF2H4i+D68VUD5hnNh1UN5cNXZDQOEXzp58R4o85u/a2C?=
 =?us-ascii?Q?zEYiSwRWVSGLPmKTA5e6PeYsQun2s1WXg7yK9UgKuI7Yxdj4fkyKGPe2BXTz?=
 =?us-ascii?Q?vrmxC2Q3WGXd8i7qeRDas5vsjfTC1HF7hbBguPIGh8I+cUhbUXPe8O11iXRi?=
 =?us-ascii?Q?xVthdQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 67ec92b3-8f45-44c1-052a-08db6b2a66c6
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 09:50:06.3106
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kCrVqd4eD7bpj6h6/LLn9SaROZmV06Cl5tDV8z3MZZCeAxg2evJ9uSB86bpYlfnHmF74o1GIP5CkBTZ6dp8kN0S7RHY3FoO/Y0uKtECJSTs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR13MB5845
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jun 10, 2023 at 12:58:31AM +0000, Bobby Eshleman wrote:
> This commit makes the bind table management functions in vsock usable
> for different bind tables. For use by datagrams in a future patch.
> 
> Signed-off-by: Bobby Eshleman <bobby.eshleman@bytedance.com>
> ---
>  net/vmw_vsock/af_vsock.c | 33 ++++++++++++++++++++++++++-------
>  1 file changed, 26 insertions(+), 7 deletions(-)
> 
> diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
> index ef86765f3765..7a3ca4270446 100644
> --- a/net/vmw_vsock/af_vsock.c
> +++ b/net/vmw_vsock/af_vsock.c
> @@ -230,11 +230,12 @@ static void __vsock_remove_connected(struct vsock_sock *vsk)
>  	sock_put(&vsk->sk);
>  }
>  
> -static struct sock *__vsock_find_bound_socket(struct sockaddr_vm *addr)
> +struct sock *vsock_find_bound_socket_common(struct sockaddr_vm *addr,
> +					    struct list_head *bind_table)

Hi Bobby,

This function seems to only be used in this file.
Should it be static?