Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jose Abreu <Jose.Abreu@synopsys.com>
To:     Bartosz Golaszewski <brgl@bgdev.pl>, Vinod Koul <vkoul@kernel.org>,
        Bhupesh Sharma <bhupesh.sharma@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Kishon Vijay Abraham I <kishon@kernel.org>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
        Jose Abreu <Jose.Abreu@synopsys.com>
Subject: RE: [PATCH 18/26] net: stmmac: add new switch to struct
 plat_stmmacenet_data
Thread-Topic: [PATCH 18/26] net: stmmac: add new switch to struct
 plat_stmmacenet_data
Thread-Index: AQHZnQ/BBc6sAV7fFEaRb6UdKc9kka+G6riQ
Date:   Mon, 12 Jun 2023 09:49:53 +0000
Message-ID: <DM4PR12MB50885860C71F9E908A920CD0D354A@DM4PR12MB5088.namprd12.prod.outlook.com>
References: <20230612092355.87937-1-brgl@bgdev.pl>
 <20230612092355.87937-19-brgl@bgdev.pl>
In-Reply-To: <20230612092355.87937-19-brgl@bgdev.pl>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Tuy64uS5BXdifAjhD/1dTr4jTYtRY+yF1BR07rkCJg5Q7c08Q+fEHz/yJhpO?=
 =?us-ascii?Q?FyZfysoTKkHOskcq4exiwNkClTrP9w3bMCX+dLkh241kh5kqBzupf10409aX?=
 =?us-ascii?Q?3kIjRjy2Njb2S3dri5ZGz6joeFoYKCcjuQmlxLKLxw9JVGkxWxIZiwPjIqB7?=
 =?us-ascii?Q?gWXHQiUr5yggfJgAXG1wq9Dm8sjA+srPaGRv40F1fJO4uJEx8KcE7efkujdZ?=
 =?us-ascii?Q?L73ipn1A5V+TTUD9cGvFIPQE0PbFYk8x50uGkgt1PHw8QxCeSeuR+ks3TIzJ?=
 =?us-ascii?Q?Jqhkb8z9f5fIzYdlMt6c7sTxZMixwI7c4T73FnZJVsAyp9AcZ5QLGJhgFxnJ?=
 =?us-ascii?Q?1IKErOarchvk5jvKLfbLNAi1OziviRhxK9WeUNKGdRZ3Vg9z+OC/UJnMpDu4?=
 =?us-ascii?Q?H0rZP+3iGfmY6DH+auCj8l1vfMl9rRUj8KaAnWuZPhd2qVVudKQGaC33gwNG?=
 =?us-ascii?Q?7cGtsvBOUrjMqX/Eh9tu1739HJKGIRkVAtanaWHRp45ncGCQJaR7bm+iXVJy?=
 =?us-ascii?Q?oU8uLdoqXK1BYjTiULhuTal5mGorjoa6SDJy9gw2iVo+IUwmo3J3jrB4DHbz?=
 =?us-ascii?Q?HufKNiQPyZhPx5Ex9LDJligkDNtqvndGwfIH+hwZZcZTh8O6O7GSrfd+zKTe?=
 =?us-ascii?Q?H6i9c+rXkuxtHn/zptsWnnJeM4SOY/u0DxK6Gbt6La1cvdg0mRqHwUkWYueB?=
 =?us-ascii?Q?cPyiDITTk6RNvZMPtrPTz4P00mImUMaL0H9zEfVXeGZv0zOowowvrYmG1ljJ?=
 =?us-ascii?Q?6dvYcqI5tCmlzjAhRo9S0r6MXrxL+nPxPpzav3n4gcLCkQSTcTUlsxK9TVMs?=
 =?us-ascii?Q?Sunepl8tBCCITPifBWxM0+1L8dmlnkR9hYcrLyETARblxqoEpMB8cyGCA9qD?=
 =?us-ascii?Q?+yPHbJ5WtM5sNyAF6H+0xmjGP1WRinOILwDdOzj1q2e07VjLzuPjRuKpxTZg?=
 =?us-ascii?Q?Iehw2vsuQr8ES3KqLkEWi19RxL72/Mx0vSM3AoGUIxaA/asQwCN7m6yiiWax?=
 =?us-ascii?Q?G98zoNaAjxARqOHH8GOCS50IBJ1O7a0YZwykQB4BCMeiEvFQTNIoszAixhl4?=
 =?us-ascii?Q?j9fVHbDV8dbeN77u83aJVIMyWQIFAOCN76qxdBJ6yT8sKp6m2dRUb1mI+VzM?=
 =?us-ascii?Q?FCClXC5QbPdguxbhwxbAL6KPToLSWkbLJvnd6AlijXhsi3duZ8Tr3PkWQxy/?=
 =?us-ascii?Q?kTPeBFJd6UI/NuBTVF3n7Uia3SaU6eUDlPkavItbD5jqBfO/ZLdjcVxbW3sJ?=
 =?us-ascii?Q?7NK8HLsrg5MUheJWY6R1463gHwELtlbHgK67SvRJv5MmVmaaXMUGv3L0ilNf?=
 =?us-ascii?Q?pQet2jidCppx+6MZw5Pfnl2wIPwZBhmXZdWjS/WItgCwYh3BCibOqVVVnGhO?=
 =?us-ascii?Q?WQQWuzQtz4iuEP76fCdoA6dEbZDheJcrwhpJMn4SW3oN5xWquBy8O9aU+KVI?=
 =?us-ascii?Q?6lMK5wORu+blGRSISeZLkobn8yjrP+eZu/oS/paVanFnb2MlgIpp0Q5DCb/Q?=
 =?us-ascii?Q?M0j32F6H3qSm43W5HVrtJKwb42nxhLBVowUGD+PmgHubjkvsa0T83sdc0D2P?=
 =?us-ascii?Q?5R99t0AT3tW3IkiqbP6WIqmuJPk6hD8u1XaXeaxt?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?qW6Ch6SI0Kgy2pMg2aUn6aQBRQMo14TMIEIVoeojc3UBdtayVM32+zgJ4k8q?=
 =?us-ascii?Q?PDACWhoiuR/mvXZNSxgo9GGpbuoKVqJDNMtkwB9K+iTJkxUtgf/nzUwFSM20?=
 =?us-ascii?Q?IXa+sJsp519vMvZsptXvwGdtO0wbrpcg9hQwEErXGH0EuRBPVie8s2+xEQgy?=
 =?us-ascii?Q?ZJBfHP4MVwEHCOFjxg9QzBXWEJDx8HB/FN/MEUymAih7p2HCtZsjILToAiHT?=
 =?us-ascii?Q?FL/3XoMf8f+4JaNjfThLpC9dSKoLNq8RM5JzLZfoVcfWdVaCJStwl5bv4icw?=
 =?us-ascii?Q?9wW945+Vcp+s8Ld6FfCxdMqcmfZNDUP9H4dpq3GAiAfOFnx0WojDoDM5UK7g?=
 =?us-ascii?Q?z3TBVaUvhk44aHt+XgEKbCWGE6m4X7pykufEP0M6uSpfDC2afBNkhOjkFl0P?=
 =?us-ascii?Q?XPqJd8KXRDBI4HTt3MQjBJSc8v8r1yzmLQDAQCypPUF+I0RxpN0+TWgfm29O?=
 =?us-ascii?Q?zAp/YgH0uDoikbJxWbE3X1Qyv4vaRhEU5fDFI+DswVVWN0Qu/88x8Mah5ziQ?=
 =?us-ascii?Q?7/qKXKq+PfUGr0vhbxYfkZlBCIWn1B8vz9MfKAuZ0xFL/hpRbQ2xCtv0ApQ+?=
 =?us-ascii?Q?SZOwlBLOCd+bBvYc92MU27dgheXnynogFnhel6d9SWv7JgyKS21FuHiunlS4?=
 =?us-ascii?Q?KJiOhUz6u+fTHHvuvfvXcnEWKKYddoSb5Yeotm8PsOMww30jYIOdul2jCsGD?=
 =?us-ascii?Q?skBBnxDBARKFd+HGtBnNzjQ2vW+lhU5XGdJOGA7J8SG9j4A3KbcwymXuCnjO?=
 =?us-ascii?Q?IcOCnwdOWSQoeWi/TQqX/ZfBnKSZo2IsCEFixnqy3by6sVLG5AqvTGjyY9/z?=
 =?us-ascii?Q?T5kaw0jyQa2beuXDQP0Wf0XWmaQQowcwkP4F3ks0MUlbQneIZtPTi3hQlEZr?=
 =?us-ascii?Q?nAI6AroJBvVoX3UKFjmN4VntISDn62WCNHmzfG9h/m0k60qqC/J9XYQVIc9H?=
 =?us-ascii?Q?9hPQlUcFfLXzM+jqCeqjuYM4m92qkxkKesrzc80qaK5sjJiHxEugGZucCJ+a?=
 =?us-ascii?Q?q9Ry3Pz9qHPJnAshGk13+WtPRYAggaEByFkFR/T62T5SInie08Z3GCM8i0YV?=
 =?us-ascii?Q?AnxgV6i6BosKMNwQkiJhIgoafaYj1IhhGpu3jAFXrpxKRkHkfzRrEucuE69O?=
 =?us-ascii?Q?WvXuqkB2vIQI2rMvoCrAFiyuL4pyYKhosFb8k5rDl7uJlviNDlzKMdo=3D?=
X-OriginatorOrg: synopsys.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5088.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b666670-8c4f-4dda-9be4-08db6b2a5f3f
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2023 09:49:53.3563
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TpFs+OHTmy4OpUk2Tv6Yiavy8Vpzihr+k9qRw22JhX/qPeOhM+NMjZYUx+mE4P2hGLVSr0u4sJ/btOTHYLaPkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4555
X-Proofpoint-GUID: TXdyPQLeuxDYW9psUziloD-sBv42-6SN
X-Proofpoint-ORIG-GUID: TXdyPQLeuxDYW9psUziloD-sBv42-6SN
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-06-12_06,2023-06-09_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_active_cloned_notspam policy=outbound_active_cloned score=0
 mlxlogscore=999 lowpriorityscore=0 priorityscore=1501 phishscore=0
 spamscore=0 impostorscore=0 malwarescore=0 mlxscore=0 adultscore=0
 clxscore=1011 bulkscore=0 suspectscore=0 classifier=spam adjust=0
 reason=mlx scancount=1 engine=8.12.0-2305260000
 definitions=main-2306120084
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Bartosz Golaszewski <brgl@bgdev.pl>
Date: Mon, Jun 12, 2023 at 10:23:47

> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>=20
> On some platforms, the PCS can be integrated in the MAC so the driver
> will not see any PCS link activity. Add a switch that allows the platform
> drivers to let the core code know.
>=20
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
>  include/linux/stmmac.h                            | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/=
net/ethernet/stmicro/stmmac/stmmac_main.c
> index fa07b0d50b46..fdcf1684487c 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -5793,7 +5793,7 @@ static void stmmac_common_interrupt(struct stmmac_p=
riv *priv)
>  		}
> =20
>  		/* PCS link status */
> -		if (priv->hw->pcs) {
> +		if (priv->hw->pcs && !priv->plat->has_integrated_pcs) {
>  			if (priv->xstats.pcs_link)
>  				netif_carrier_on(priv->dev);
>  			else
> diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h
> index 225751a8fd8e..06090538fe2d 100644
> --- a/include/linux/stmmac.h
> +++ b/include/linux/stmmac.h
> @@ -293,5 +293,6 @@ struct plat_stmmacenet_data {
>  	bool sph_disable;
>  	bool serdes_up_after_phy_linkup;
>  	const struct dwmac4_addrs *dwmac4_addrs;
> +	bool has_integrated_pcs;
>  };
>  #endif
> --=20
> 2.39.2

We should eventually consider changing some elements of this struct to a bi=
t-field.

Reviewed-by: Jose Abreu <Jose.Abreu@synopsys.com>

Thanks,
Jose