Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3ac37e54-0633-37d2-2ba7-f06abcb9a5a7@linaro.org>
Date:   Mon, 12 Jun 2023 11:51:19 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [EXTERNAL] Re: [PATCH] arm64: defconfig: Enable HSR by default
Content-Language: en-US
To:     Ravi Gunasekaran <r-gunasekaran@ti.com>, catalin.marinas@arm.com,
        will@kernel.org
Cc:     arnd@arndb.de, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <20230612094340.13865-1-r-gunasekaran@ti.com>
 <ab8dfd0f-fa49-6493-d79d-c35f632373f3@linaro.org>
 <e3e409c5-56b5-570d-e962-a7c0a1c05fa3@ti.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <e3e409c5-56b5-570d-e962-a7c0a1c05fa3@ti.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/06/2023 11:49, Ravi Gunasekaran wrote:
> 
> 
> On 6/12/23 3:14 PM, Krzysztof Kozlowski wrote:
>> On 12/06/2023 11:43, Ravi Gunasekaran wrote:
>>> Enable HSR feature in kernel build.
>>
>> Why? Commit msg should answer to this question.
> 
> I apologize for incomplete description. I will send out a v2.
> 
> HSR protocol is implemented by the network stack at /net/hsr/*
> In order to create HSR interface, HSR module needs to be loaded.

You described what HSR is, but I want to know why do we need it in our
development arm64 kernel. You might want to enable anything and explain
what is this "anything" but this does not solve any of the concerns.

Best regards,
Krzysztof