Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jonathan McDowell <noodles@meta.com>
To:     Jean Delvare <jdelvare@suse.com>,
        Lennart Poettering <mzxreary@0pointer.de>,
        Kay Sievers <kay.sievers@vrfy.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] firmware: dmi: Don't restrict access to serial number / UUID
Thread-Topic: [PATCH] firmware: dmi: Don't restrict access to serial number /
 UUID
Thread-Index: AQHZnRSgbC5BfmvI5025YFjNaR+wNg==
Date:   Mon, 12 Jun 2023 09:59:50 +0000
Message-ID: <ZIbslWZev/Ayoug5@noodles-fedora.dhcp.thefacebook.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uVCON+jQZhnB+btpU3qH1cdmmqet+upkuxwvazflBc4hresFXO05KsH/Konb?=
 =?us-ascii?Q?l+w1LMBw3xa5AwW3dCMrultcTV1l2tVBRKtE38ZmvSdB8fdI+pgJJzVJhW+t?=
 =?us-ascii?Q?7vIEaH5L1TByvLkag4Zo357dRKT+InxcBWeIuGi5hvdF5as8pPykz8TxhcRj?=
 =?us-ascii?Q?JYOvCnOZJQ5Fyc/tL4hO5u6kolxyEWPe/o7289xNpATupv4NZHfbqgYYGmhf?=
 =?us-ascii?Q?+RpjJU8/KDBJmCxIwzwO/wVaCarPXV/JiLL6m1HA1my1W8+uqlDsYHcTwOhy?=
 =?us-ascii?Q?p0nBqhl5qDxt7gQcLePLcEZLCdiXBFRccM7HDm2PO1qISbzbKsOvsZ74wK0Y?=
 =?us-ascii?Q?TcqLhmmTCZ2uE+KBmDxgp420SmSB5KTqs4u0PI406DzCoxCXa65Zi2BKRuxx?=
 =?us-ascii?Q?D+r7iLQyeTRlTAqAleSCXZjcoF7Oe7StEpcu9CR5OGxa63OAbshdqryVV+ZD?=
 =?us-ascii?Q?Y/GC1ugmahpGRXS48Pd3VcE5HF05mPhgdPCUSt/h+AParhoVyGmHhOL7JG5I?=
 =?us-ascii?Q?nJyfq2GbQnNbCYMtRVXn3UR8gBYutEOZ8k9sbCBw812iyYE+t2BQqLC8L453?=
 =?us-ascii?Q?T+//N5610uuUksiWTVJbVh3gjHb5Ig0KLR/MlggSwSYRwCLnVkXPWD+6rPfD?=
 =?us-ascii?Q?WNElWxhZzjgxVXymxpeywnOSWhctL+RhcEM7mt02RbWD+enPRdf4t50ViQEn?=
 =?us-ascii?Q?mJ1A5TvVApLbV99vOZLB5oAg9cTiXiD6iF74XCB9vLnAEdzFwvS0pQqFVOxG?=
 =?us-ascii?Q?MiIQ/qfRU1lC/XtH8LsRoNej0RtAuy14IEhvtndISBFdceiOuq83pvSFtwnN?=
 =?us-ascii?Q?HFwDCo5qaYgJh72LbohIYu+egl7A6vn35qXt24RvHn8R8i1SOZ23YWT1flvD?=
 =?us-ascii?Q?lLBX+6uX3Hti+2rtUeQIQr3uSmhabpwn410efoS2TFSEgsAES8ElBjUwRdKT?=
 =?us-ascii?Q?CXq2wpiqwHrzMAHzRjOX8L1n9CYHy8mBLTEcAl35GnVFHoOpCx+uZkcH8d4h?=
 =?us-ascii?Q?9vpt9tTzaeh4PpM0X6RdklE7YN7y0tOzBYPbRp/d5exbAc2kB/CCanirgSe+?=
 =?us-ascii?Q?Xtn1A0KWqNspxoXP5YtukViLSoN2wh8l4pV5Gva9HeyNTLEROPBNUJpVQU7M?=
 =?us-ascii?Q?E6LeNSrvXOwh6RZmyIdR9NQUJCj8BxJDoUcG5yx3LUy3YgfPcbg9vfUcVPiS?=
 =?us-ascii?Q?h3ny0Of+7L9LHer10BTJRAqrnfIOgbHStUTVGnIJfmfAqh5+1dtXdMqPWMvZ?=
 =?us-ascii?Q?eBpnWwLKddANkm48hg8N7cOpxfHVSw74MkbcqearLHLQ0k9FafItKFZqgz6Z?=
 =?us-ascii?Q?Ho08acfEDmTtiEVPI4nG8z9OCxzeTnM+rEmkWdnW0C3tY0aHFl2Fz0Iw0cS6?=
 =?us-ascii?Q?d4vM/JB5PRHXg9xSdU6QQ1XbgRtkUMhdGs9NTtlnIALFUaHNjfbNm+D670ZJ?=
 =?us-ascii?Q?jWcccrsQQibg+87k+XbPsX1CGaRRSxwZJ3nKjdWXSo9a4jpD95Resl2B+tab?=
 =?us-ascii?Q?31wvETctMKngcbuODhoUKculMeXJMdrRxxOZF/9DMScY2hmJAjpq6Eju29r7?=
 =?us-ascii?Q?BLbWRJaX0y+lQQq9HRa6lpYJVDUBC0ySHJoLbRO6?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <850F49339C8A1D4CB828761608F42520@namprd15.prod.outlook.com>
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA0PR15MB3997.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e0ec677-70c0-4db5-e17d-08db6b2bc314
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2023 09:59:50.3304
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0MbaDO5+ZLUOmMAfCfsyXDT0XZzVGIY0ov697KHTeeIUGNynJNL0MNHvrOCFcBQgTCHsjFAoKgZUoWASY6u6RQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR15MB4182
X-Proofpoint-GUID: Y1EjdHx_FMbdVVpgfl65Ig7Dulv_i1VO
X-Proofpoint-ORIG-GUID: Y1EjdHx_FMbdVVpgfl65Ig7Dulv_i1VO
X-Proofpoint-UnRewURL: 0 URL was un-rewritten
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-06-12_06,2023-06-09_01,2023-05-22_02
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The /sys/devices/virtual/dmi/id/*_serial + product_uuid files are
currently only readable by root. There's no clear rationale for this;
Windows + OS X both allow regular users to access the information, so
there appears to be no expectation on the manufacturer side that it
should be kept secret.

Having the information easily available helps with automated tools that
collect system information for the purposes of fault diagnosis/tracking
without requiring the tools have root access.

(I've tried to look for context on the initial patch submission about
why these were root-only but didn't find any; hopefully Lennart or Kay
can provide details if I'm missing something.)

Signed-off-by: Jonathan McDowell <noodles@meta.com>
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=103601
---
 drivers/firmware/dmi-id.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/firmware/dmi-id.c b/drivers/firmware/dmi-id.c
index 5f3a3e913d28..ae700c09d7de 100644
--- a/drivers/firmware/dmi-id.c
+++ b/drivers/firmware/dmi-id.c
@@ -46,19 +46,19 @@ DEFINE_DMI_ATTR_WITH_SHOW(bios_release,		0444, DMI_BIOS_RELEASE);
 DEFINE_DMI_ATTR_WITH_SHOW(ec_firmware_release,	0444, DMI_EC_FIRMWARE_RELEASE);
 DEFINE_DMI_ATTR_WITH_SHOW(product_name,		0444, DMI_PRODUCT_NAME);
 DEFINE_DMI_ATTR_WITH_SHOW(product_version,	0444, DMI_PRODUCT_VERSION);
-DEFINE_DMI_ATTR_WITH_SHOW(product_serial,	0400, DMI_PRODUCT_SERIAL);
-DEFINE_DMI_ATTR_WITH_SHOW(product_uuid,		0400, DMI_PRODUCT_UUID);
+DEFINE_DMI_ATTR_WITH_SHOW(product_serial,	0444, DMI_PRODUCT_SERIAL);
+DEFINE_DMI_ATTR_WITH_SHOW(product_uuid,		0444, DMI_PRODUCT_UUID);
 DEFINE_DMI_ATTR_WITH_SHOW(product_sku,		0444, DMI_PRODUCT_SKU);
 DEFINE_DMI_ATTR_WITH_SHOW(product_family,	0444, DMI_PRODUCT_FAMILY);
 DEFINE_DMI_ATTR_WITH_SHOW(board_vendor,		0444, DMI_BOARD_VENDOR);
 DEFINE_DMI_ATTR_WITH_SHOW(board_name,		0444, DMI_BOARD_NAME);
 DEFINE_DMI_ATTR_WITH_SHOW(board_version,	0444, DMI_BOARD_VERSION);
-DEFINE_DMI_ATTR_WITH_SHOW(board_serial,		0400, DMI_BOARD_SERIAL);
+DEFINE_DMI_ATTR_WITH_SHOW(board_serial,		0444, DMI_BOARD_SERIAL);
 DEFINE_DMI_ATTR_WITH_SHOW(board_asset_tag,	0444, DMI_BOARD_ASSET_TAG);
 DEFINE_DMI_ATTR_WITH_SHOW(chassis_vendor,	0444, DMI_CHASSIS_VENDOR);
 DEFINE_DMI_ATTR_WITH_SHOW(chassis_type,		0444, DMI_CHASSIS_TYPE);
 DEFINE_DMI_ATTR_WITH_SHOW(chassis_version,	0444, DMI_CHASSIS_VERSION);
-DEFINE_DMI_ATTR_WITH_SHOW(chassis_serial,	0400, DMI_CHASSIS_SERIAL);
+DEFINE_DMI_ATTR_WITH_SHOW(chassis_serial,	0444, DMI_CHASSIS_SERIAL);
 DEFINE_DMI_ATTR_WITH_SHOW(chassis_asset_tag,	0444, DMI_CHASSIS_ASSET_TAG);
 
 static void ascii_filter(char *d, const char *s)
-- 
2.40.1