Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Lu Hongfei <luhongfei@vivo.com>
To:     Felix Kuehling <Felix.Kuehling@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        amd-gfx@lists.freedesktop.org (open list:AMD KFD),
        dri-devel@lists.freedesktop.org (open list:DRM DRIVERS),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, luhongfei@vivo.com
Subject: [PATCH v2] gpu: drm/amd: Remove the redundant null pointer check in list_for_each_entry() loops
Date:   Mon, 12 Jun 2023 19:58:48 +0800
Message-Id: <20230612115848.8739-1-luhongfei@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zeJl8jHf+lau8aBsrV13Zr5C+/PL4oJMzh+l3OlOCSOk1K3r2WdAWA0eylUO?=
 =?us-ascii?Q?5syKp+NMf8DdaudFzZJh7u9W9rD/xpZihKzIi6e451QD8Wa3JoKrNksDcnjT?=
 =?us-ascii?Q?RLyV7EwDv/VTGLtULdOgkZRFHx4QAo7oo+tO+C0qKqip8ggFPx1bnSl1Zhqa?=
 =?us-ascii?Q?AwAf2gNvWNko2lvS3/HZCzgE9OvZR/Dyi7mCp7X/HIY19TRmW9vPMHcJSupC?=
 =?us-ascii?Q?ivLHkaRzVpjPllGM6KlVlOS4qeJNu0Mfol7HStPGLCr9hS8A3GWhUS6MiUmW?=
 =?us-ascii?Q?Acd696k3Wd8RtwHthLoRQKPYqq7WKSFWrTLxI61WH3+/Gwz9N+p4y8zqTKvF?=
 =?us-ascii?Q?sQTBE7ZilTi3iFz26u58MGrkYMykU9Rtpycoquz788gYVMfmoaomMo+XF7+a?=
 =?us-ascii?Q?plcV9b/O+Gv8WIlHpFSnGGPYQzGrfTM0l4M45vPO9oJcVZYfU2/mF0oWEX9a?=
 =?us-ascii?Q?0ftusXohK0N89qcz1ZDbTy+jbuHl96sv9PqgDKPoK2KigHZdhzGhfLn6t0iR?=
 =?us-ascii?Q?20q//Ahbc/DhV4FhckHH0c2R7KaK82rgM7FyvQwHTY0cYe2aaSLP/5HiztUv?=
 =?us-ascii?Q?q41A5BQDWsUNePFVwv3aOdog5slYg7uPsuNtpqmSYeOgczyjdalInfdAomw6?=
 =?us-ascii?Q?hpFVx+UvUkoIb6KZIVAp1VGC6qzMREbnwhYlS719k0ggFqSWLHL/f0fPsOFq?=
 =?us-ascii?Q?V8Z9vcYfa3AkE1urhBoVQ8oo0F6G5Fze5X8x+n0zg8oO37PoCu6DS0SrYCzA?=
 =?us-ascii?Q?GJGaXnPIzNi1RkCVb0FS6HOhTwM0Z51WaKJ41s3FVfNLU+c7zvHr+IlwIKTe?=
 =?us-ascii?Q?bdHdZyc2B2MGdqbOeI22ipPHPSSH5otAGAIfiZIVuoAjenH8fJobe7fjNIao?=
 =?us-ascii?Q?Bdz1qzmlt3LAPXb1bNW5SNV6OfgMFgraxMreXMRE1UXj1hyMS0s/mftGB5OB?=
 =?us-ascii?Q?NdHwZsiaEcT9AHcwzcjELIVU59dYVQHvIfgQBD5sDmH6KsJyWMqQNwdJT4x7?=
 =?us-ascii?Q?aGRaf4tLGz3sn0xm57ahprFzznHD55YxrC5n+JpHPb3p/BhIwEaXjQJGr2cG?=
 =?us-ascii?Q?FKn+xYlmV90TLYOUW4aGWxifOpTi2VP0M3X/tZ3tDFwG3LX9zh9d8AZ5hu8e?=
 =?us-ascii?Q?xGxRDIalHq3mzby0p2in4r8a+S+qrdf1vOp33D9e12kkyrO3pTWwjrqrBrbc?=
 =?us-ascii?Q?R6CTjbV9CKLBnxQS35VD6lj8/6V4QnKV3Dnn7hUG3dlAM+LwE7dxfhGonjDr?=
 =?us-ascii?Q?dliDAqaSetWLjo5E3AZ2AMKs5HCIrsee8q5LjWtpX+9xNw/uY9IRSQvj1qnc?=
 =?us-ascii?Q?S6/gVtPgWMLZglVoiLkmmoNo9Ctfb5yOqQ7/FSvoxRLaBrK5p2dN9Igspvqc?=
 =?us-ascii?Q?UfVYw9hJ3p4k1aX2sTJvUnASHqnM1OpOK0ZTReMmIPzjv/uzvPt0jO3jjHaV?=
 =?us-ascii?Q?W3JE/Mjbtjidqx6G9VbGeLnjHBC10axeqN3RLwIHqQXD8PF9bIFDD4rtuZaB?=
 =?us-ascii?Q?7BIZQC0sGA3fW5lKipQKwazr6F2hXizoFRpcVmTy4CMK9XKCm1nvQwWGr1Xz?=
 =?us-ascii?Q?VldfhscljPCcdLcaUaMbGqLOPrqEDqC664D1mM6O?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df9f21f8-187b-4910-74cb-08db6b3c67f5
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB6697.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 11:58:59.4578
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d2eyIV1FkFlw+9jW2Dd47KnPki/InRjecMNA52Qhk6RUFDblDB9OE8Wvi4KAf3xAi2Hk19jmzZTOZc/a0Afflw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB5129
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

pqn bound in list_for_each_entry loop will not be null, so there is
no need to check whether pqn is NULL or not.
Thus remove a redundant null pointer check.

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
---
The filename of the previous version was:
0001-gpu-drm-amd-Fix-the-bug-in-list_for_each_entry-loops.patch

The modifications made compared to the previous version are as follows:
1. Modified the patch title
2. "Thus remove a redundant null pointer check." is used instead of
   "We could remove this check."

 drivers/gpu/drm/amd/amdkfd/kfd_debug.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_debug.c b/drivers/gpu/drm/amd/amdkfd/kfd_debug.c
index cd34e7aaead4..10d0cef844f0 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_debug.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_debug.c
@@ -1097,9 +1097,6 @@ void kfd_dbg_set_enabled_debug_exception_mask(struct kfd_process *target,
 
 	pqm = &target->pqm;
 	list_for_each_entry(pqn, &pqm->queues, process_queue_list) {
-		if (!pqn)
-			continue;
-
 		found_mask |= pqn->q->properties.exception_status;
 	}
 
-- 
2.39.0