Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Markus Burri <markus.burri@mt.com>
To:     linux-kernel@vger.kernel.org
Cc:     Markus Burri <markus.burri@mt.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Michael Hennerich <Michael.Hennerich@analog.com>,
        Alexandru Tachici <alexandru.tachici@analog.com>,
        Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Subject: [PATCH v1] iio: ado: ad7192: Add error check and more debug log
Date:   Mon, 12 Jun 2023 14:15:54 +0200
Message-Id: <20230612121554.367285-1-markus.burri@mt.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hrzI9t40dz1BvGLrQ4kW2v+GhrnVfV3eJua74k5tnRIDkc91TMox897/lMMl?=
 =?us-ascii?Q?uZ0ltAU3xA+8drW3VX4Y4lDjmUwPcDBO8Otgeh3EGmMmA7edy/HHTPcKbius?=
 =?us-ascii?Q?5S9g0yfFxh7OnJ/lhh8kf1mMLeiFITR1dYtXtca74I5TsuH5WKGYaOKBXqxg?=
 =?us-ascii?Q?e427wG+3deJ1HRfJpK3UA3nmbzqokLGTPlpZe6bDBZxLu996lzA3aHQbMLKU?=
 =?us-ascii?Q?jyPrNj5uOqbdDfBrYMTrmxUbWH2l13mMNmfpRV1XWSpX6/4+48lazt83YFyT?=
 =?us-ascii?Q?cCme8CSSCaKkFe94kY5jCdWnLYIPZbZ4hFjdw9wDr8rIMyzfon5KGYCQrozU?=
 =?us-ascii?Q?U21i+Jz5dUX+2knbi4fkK9IUqB55JRBu5+wTu+Xq+J40YDpDpdqom1VbOxEO?=
 =?us-ascii?Q?0Q1B6X3bmLFe6bfOEJ+8mPKTd/YG6znCiOUw2BENqZwE8jvBOboBLAygS9Rr?=
 =?us-ascii?Q?ankhIMlhBzMZAvK7hpHug7l4Ob30w8JQS4rsMZNodH2RD6Te+dDMOcXf73wE?=
 =?us-ascii?Q?0qzcKNSaOiemW8GlPLqlmW3dJM0mPk4fE1xZjJo8ms7PdVOMZDaBjj0+YMe+?=
 =?us-ascii?Q?OFRuDXZmKCVD9Ug+fZN3vrP0J4DORScQ08RmGWmrS4uQk4A7ZyS5k4lGW+7b?=
 =?us-ascii?Q?ORGQFAHQzPWRETV1H1mcTs4bfP2JFcffQwDcNpsFceL+6fYVcdNxC57j1DsB?=
 =?us-ascii?Q?G2+0j1gKwU2RV+AB0gALGgyOpKjQpMF+qo+ticG8PS1LTispyiUGexMtQNdk?=
 =?us-ascii?Q?uQXl0XSukDILf6ncoX8/pLGwKEoaCnOoAJc1xmEhve7DQr+84TGNpvwOT0if?=
 =?us-ascii?Q?tjz6/py+/Ye2Z/TGHqS8pWLtnUw3bgRUo50CIHnCf6Ixi/N34lftvZC3oXmG?=
 =?us-ascii?Q?JpsFIY6Lu0S6W1x3e/TZQYVvVRWKW5EYWSXianxmlt+g3UbNQSZnY6LPoiqJ?=
 =?us-ascii?Q?G8IRfaYTMq2rhn1SeFGAPHtyyc1yAL0fi979Bt7UMnkGdjz8blAOcen/tJ/H?=
 =?us-ascii?Q?eZtNrIpj1XG4DKrY70gNiVOFzTjMRoIySMlneVGykQYRP0M5gDEVdBRimYda?=
 =?us-ascii?Q?/0V3+CRnajktQuXQ6/uAnNeZBN7j0jYAVdeezZZk6YtedhUz6STdO2BIp9Eh?=
 =?us-ascii?Q?/Q/ZE0H/xWoEdA5oCTy2LBIegnYIOsaH2KXTdU2rSlr3OTweZe81bDzBs1Pk?=
 =?us-ascii?Q?wosfLl/OanepZjhxMvtJxors5BkNvgc/HbhgF6bdPkY2xutrLr6ZazdmVTnS?=
 =?us-ascii?Q?yCBh0PwIgTD4B5+4/gNbTfTkcYNS6SLxgG/UFjBFN5//jLfkF6Y25lahmG8n?=
 =?us-ascii?Q?yOR+nixfRqi+QdGDtb9dgSfRWPI4Lg/gRGBAYpQFGWZXrEzUHIaBxszqR8JI?=
 =?us-ascii?Q?12I5Q7Muz3fLOr9rM0q7+NZkES8EzjaUMVgzPHj8c0zvH0TfWAGLycFf3zOo?=
 =?us-ascii?Q?sMgfll3b+cA/dvdY9mfd0gtYIIi/nYqPVntNALVWEOcFPIg/jJ1VaKHmlXNK?=
 =?us-ascii?Q?Ci40we5rQjVDH/MEKPT7LTJYXuHFQy9rYhYjSlw+CGfazYMRimv+/BmmocYi?=
 =?us-ascii?Q?sLmxZGQX8zVxPymI9HFsfs5aZG9FZvx8CaZfy2rV?=
X-OriginatorOrg: mt.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6af2ed33-f6f0-4139-bead-08db6b3edce4
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7488.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 12:16:34.3006
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fb4c0aee-6cd2-482f-a1a5-717e7c02496b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1PYEJLC/IYCJo2melmuuH4yRvCZKL02rXzSoHllW6R6GT+cW2evT7IqdPbXt/0nax/lXPyvvwYnMkYYSE5DpYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR03MB6922
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Print read and expected device ID as debug warning.
Add error check for sd_sd_init() result.

Signed-off-by: Markus Burri <markus.burri@mt.com>
---
 drivers/iio/adc/ad7192.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c
index d71977b..220c3b7 100644
--- a/drivers/iio/adc/ad7192.c
+++ b/drivers/iio/adc/ad7192.c
@@ -403,8 +403,8 @@ static int ad7192_setup(struct ad7192_state *st, struct device_node *np)
 	id &= AD7192_ID_MASK;
 
 	if (id != st->chip_info->chip_id)
-		dev_warn(&st->sd.spi->dev, "device ID query failed (0x%X)\n",
-			 id);
+		dev_warn(&st->sd.spi->dev, "device ID query failed (0x%X != 0x%X)\n",
+			 id, st->chip_info->chip_id);
 
 	st->mode = AD7192_MODE_SEL(AD7192_MODE_IDLE) |
 		AD7192_MODE_CLKSRC(st->clock_sel) |
@@ -1049,7 +1049,9 @@ static int ad7192_probe(struct spi_device *spi)
 	else
 		indio_dev->info = &ad7192_info;
 
-	ad_sd_init(&st->sd, indio_dev, spi, &ad7192_sigma_delta_info);
+	ret = ad_sd_init(&st->sd, indio_dev, spi, &ad7192_sigma_delta_info);
+	if (ret)
+		return ret;
 
 	ret = devm_ad_sd_setup_buffer_and_trigger(&spi->dev, indio_dev);
 	if (ret)
-- 
2.39.2