Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i8771445c:Fastmail
Date:   Mon, 12 Jun 2023 14:21:01 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Frank Oltmanns <frank@oltmanns.dev>
Cc:     Andre Przywara <andre.przywara@arm.com>,
        Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Roman Beranek <me@crly.cz>,
        Samuel Holland <samuel@sholland.org>,
        Stephen Boyd <sboyd@kernel.org>,
        linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v2 1/2] clk: sunxi-ng: nkm: consider alternative parent
 rates when finding rate
Message-ID: <oo534q7hgmves7pd665ut356xpksw7oonrjk22tu4h4mg6mwhd@dwoc5a5c5wn3>
References: <20230611090143.132257-1-frank@oltmanns.dev>
 <20230611090143.132257-2-frank@oltmanns.dev>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="e4wbpxmfzpclxccx"
Content-Disposition: inline
In-Reply-To: <20230611090143.132257-2-frank@oltmanns.dev>
Precedence: bulk


--e4wbpxmfzpclxccx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Sun, Jun 11, 2023 at 11:01:42AM +0200, Frank Oltmanns wrote:
> In case the CLK_SET_RATE_PARENT flag is set, consider using a different
> parent rate when determining a new rate.
>=20
> To find the best match for the requested rate, perform the following
> steps for each NKM combination:
>  - calculate the optimal parent rate,
>  - find the best parent rate that the parent clock actually supports
>  - use that parent rate to calculate the effective rate.
>=20
> In case the clk does not support setting the parent rate, use the same
> algorithm as before.
>=20
> Signed-off-by: Frank Oltmanns <frank@oltmanns.dev>

Most of the comments I had on v1 still apply there, so let's figure them
out before sending a v3.

Maxime

--e4wbpxmfzpclxccx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZIcNrQAKCRDj7w1vZxhR
xYjBAP4zxaQPtCC3bLmbBvqxb8o92BcM76cTi9dor6Y96WivRwD7BPrLB9GMmbgP
qaL3OlTIIIndIP66M8PVuTjVjm6tCQw=
=EEt7
-----END PGP SIGNATURE-----

--e4wbpxmfzpclxccx--