Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Jun 2023 15:16:19 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Sarath Babu Naidu Gaddam <sarath.babu.naidu.gaddam@amd.com>
Cc:     richardcochran@gmail.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, vincent.cheng.xh@renesas.com,
        harini.katakam@amd.com, git@amd.com
Subject: Re: [PATCH] ptp: clockmatrix: Add Defer probe if firmware load fails
Message-ID: <ZIcao8a7Yqf6McGw@corigine.com>
References: <20230612100044.979281-1-sarath.babu.naidu.gaddam@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230612100044.979281-1-sarath.babu.naidu.gaddam@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kUYFndJjDNObmpHKeERmla02ISzn2mPP3IQgVH/tQzDyQKIggVjAF6OmW5RA?=
 =?us-ascii?Q?hu1zbEmALn/8x92+s/sEFI38vCqFC4qz0bjKXU09hQrkjwIO4xlksbuYcxO8?=
 =?us-ascii?Q?NY0j0BoWyHtQMQ1o5QNy+FqpYHtgbWBlIk7yohNP+QPbuyOcw8C2Y1gkINb1?=
 =?us-ascii?Q?3odvTaHBp4gmtjgJpVau++tPvxGGzVd8Ujh0kaJDFd5kPPiAXuCohbiPm5zI?=
 =?us-ascii?Q?eKXKWO5bS1AqJyi3/gMto0f/SQZxcv8Cu0s/qo7dXKcWBmaQnQ5ObS9sE+hf?=
 =?us-ascii?Q?0m62jc/abMSwd2lgL0ZLw/pR0n6gtzELzXgMetbVvkSdQg9DZGsX3wsnxr1I?=
 =?us-ascii?Q?8OT3Hs/em0cLpKNomouGBniksIwxthN5P+es/9aneIZpJXsutxRb9fgcM2Dy?=
 =?us-ascii?Q?NOTFSkrDv3N89JAg5lmqneE/IwnznXCI0teTitmZNETOVI6RKhaUm6HRH+ph?=
 =?us-ascii?Q?qgnYJSsU9irD6t/wd/YQ8Zs57GhQaSEhQEsljeo6PCdOl1JYIw/nXCTILS7m?=
 =?us-ascii?Q?ynL8Yvq9mCdzl5ctS8fXpYv1tXvu7ovUvCPzj/fZGGMqduGjKGz0ovcZnuR9?=
 =?us-ascii?Q?QkOpLIDqxnFsbDKlO7MOksVvGgoEoij2nleXYn2Ecwyi2FBmxikfAvyZnngI?=
 =?us-ascii?Q?oFKT+rseSfCzkl1B5Z4f/nvc9ozxpiJrvoOP+xKi0Zdh9AGvIRnDDbDegBI1?=
 =?us-ascii?Q?yvq0OWl4Iw5WVAqWLMHPJO/6aodijFsZoIgPO6l36FTGErM+18HwfJBBwK/l?=
 =?us-ascii?Q?LupAPEZobZAHSy4by6XX8oMHagiHO9Z+oQOIEhKpXfB0/BV9Xqaq++ZDybEm?=
 =?us-ascii?Q?Rgn/C4bjt2IHYluQ2MKkjlMQD3hUaA7QjTD/HQ5qGGedRJ9t+ZnRO+G7m4aD?=
 =?us-ascii?Q?2f3IvYwL/p9jeZXoXLKC7YwqKLJFKq4plfCurfllsevR7XoskSulGpRdUrPc?=
 =?us-ascii?Q?ed9afdrjYZ4uY1q/Nw21z1DDnvUGLARaXcOYy76bFOxrjjZv1nyZsHsl4UN8?=
 =?us-ascii?Q?Nz7m/HTDpm+8Gp6vN85ynuZfa9ygh0i44of8EVUFZwd9areBUvYVAwS3jObj?=
 =?us-ascii?Q?kMgu4oFfniizJ1C8/IGxx/44+dMhTkmtUWBw/swl36PdxlZIqg8IUVCK6Oy4?=
 =?us-ascii?Q?YKrG9Z2P7LdjtgWj0jEX41yFA61CCGjNeDFnM9auWnRN/TuI/cJGewxu2EpZ?=
 =?us-ascii?Q?aLSVfkgf8rcBHWSVIg54ovc1NbW+d40Am7JimlBdLTJIQQST+0eSj5y5bsBs?=
 =?us-ascii?Q?+CohmqLz4X74ifTfIRsVP8QokkjWqxEFre+yrc3CO3s7/Tf/zc/buFCv1sZz?=
 =?us-ascii?Q?SBi7qORYMjtwfr6HZCzQcsdW2iIK/6j2rwwNum5M0hwFWzMtDCoCxWuGbyc2?=
 =?us-ascii?Q?pnMw/vClWKgwvozyH5n2f06iI2BqKrbD6nJ4YpGcX+3iOdWja36NslyG78fc?=
 =?us-ascii?Q?f7Z5/2YRFMBC4mPHy0dpaEw5breL4rzcn9K6YkOpYnhfi50FoPppZmEJlS8r?=
 =?us-ascii?Q?ZCOhuXA86G9NjKefk+kLpsWD0x+czxY2B22lABl0bi6TEGHl24+v6vxCEMRQ?=
 =?us-ascii?Q?QH7i25lyB4qIJcpMIWvlwo0CtM/XdlHJj6iRklzlikWb5TKxzs0Cagd7Mn1h?=
 =?us-ascii?Q?ISZY9AwncO0Adt4yDrRUC1aFTFVgOfWG0Ph50W6b0BAFOJmV+L9HzSQZuLfd?=
 =?us-ascii?Q?OxNCOA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: acf65b4a-3c9e-4c0a-c901-08db6b473a17
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 13:16:26.6698
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: p5/Ejz1CEPsxS2O7qUjYBzFX0LWJsSUX1/d7NRTO7kv1Kal4ZEOPHpqT8wYGrroWT7FlcuufM6ST1OEJUduFvh/eDb4Opu3UVD2juun52Rg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR13MB4945
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 12, 2023 at 03:30:44PM +0530, Sarath Babu Naidu Gaddam wrote:
> Clock matrix driver can be probed before the rootfs containing
> firmware/initialization .bin is available. The current driver
> throws a warning and proceeds to execute probe even when firmware
> is not ready. Instead, defer probe and wait for the .bin file to
> be available.
> 
> Signed-off-by: Sarath Babu Naidu Gaddam <sarath.babu.naidu.gaddam@amd.com>
> ---
>  drivers/ptp/ptp_clockmatrix.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c
> index c9d451bf89e2..96328dfb7e55 100644
> --- a/drivers/ptp/ptp_clockmatrix.c
> +++ b/drivers/ptp/ptp_clockmatrix.c
> @@ -2424,9 +2424,13 @@ static int idtcm_probe(struct platform_device *pdev)
>  
>  	err = idtcm_load_firmware(idtcm, &pdev->dev);
>  
> -	if (err)
> +	if (err) {
>  		dev_warn(idtcm->dev, "loading firmware failed with %d", err);
>  
> +		if (err == -ENOENT)
> +			return -EPROBE_DEFER;

Hi Sarath,

Smatch reports that idtcm->lock is leaked here.

> +	}
> +
>  	wait_for_chip_ready(idtcm);
>  
>  	if (idtcm->tod_mask) {
> -- 
> 2.25.1
> 
>