Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp5612980rwd; Mon, 12 Jun 2023 07:27:09 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4S8Sj3wySVOuzfT35j1SiD5sJXbvxINY2nYQQUTEiYr1QTUJrgruEj6VtxwlDqZyAZaaFT X-Received: by 2002:a17:902:da91:b0:1b3:d606:91f8 with SMTP id j17-20020a170902da9100b001b3d60691f8mr2545652plx.23.1686580028782; Mon, 12 Jun 2023 07:27:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686580028; cv=none; d=google.com; s=arc-20160816; b=j4O2cpvq6z5I/z83Ni+LSRBZQxA2ffz2TzTcvgnBMNAu/cj81gvXw41y04hlHl9e/V T/GzOnX1ck673gUFwT1Ho5bxwl7r5/Hht98zptckvGDpxRiWIkxv6djwStoQp/ziVwXS pojWcqovLDwfMYjXWkmaVvCXbzDYM5ZoOejgTdpDyMxS2cFf8bfxyvOEzR5yoPVpQaiT WZo7fK3UrkDlNiAuvJxIRS3u7o0Ufo32zsPJq255g5Sz95p/Z2vcci/LFktAj4611Bm6 1vXkz5kqMeWisHO/eLzLv+49S7u/K8nZfU3wRRDy1Vs3kAph+Kwzv4qUwdFa1xe6P9TC Giew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=5XlFuQXVEDYri1l5bqNadN5WFO/7K04QREToOase7Ps=; b=mfOurL15N4zXpkAE/ljHFBvTC6DLHh1YLyFIE1uQHXYy3cdrDW9voGFTq4Vg6TNpyy cYGTuMm3oGKdcLaX2ABNYUcKBJ8dteGhRzbncWlGth8XVHhtrEKSGT4/K5SWOF9DEZuS avKCKEjH9zYWV3AFxh9KnYLCzXyezS4J1J4ZB7bmIqAVToZNvhdhv92Mh1LOySrt48Yq IsNKj8fV34oVgieAG+heRrYA0qZiEm5UAVgGl9APcmTMbDv0epYHy3gFtjXxrcOq/D7X fUuzGmY0tEvZVCuN66IufGkWj3j+IPYi+dbEdkPLSWdbG6zjD9UJrRE88OJ9Iy8tnW78 uAxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=YELoukMA; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=NvP+v4zO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lk8-20020a17090308c800b001b042e93c11si3613902plb.262.2023.06.12.07.26.56; Mon, 12 Jun 2023 07:27:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=YELoukMA; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=NvP+v4zO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237608AbjFLOPA (ORCPT + 99 others); Mon, 12 Jun 2023 10:15:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237351AbjFLOOF (ORCPT ); Mon, 12 Jun 2023 10:14:05 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAE3210D4; Mon, 12 Jun 2023 07:14:00 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8883C2283D; Mon, 12 Jun 2023 14:13:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686579239; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5XlFuQXVEDYri1l5bqNadN5WFO/7K04QREToOase7Ps=; b=YELoukMA/BkLxCHOiUsNrRK6rtuEwABy2ibt67n8OBECyHcnC+40cUyDoZoTUbUpm6HOmF cg+zK8kPoWaNckCOEXFPhsJQaihjWWhiz34ytE1c/U9OezWAoQTlNDwlpxiufaRH0nqe5B 9jAsNimFDMl4HQuJs2cLXOyvSZTMOLQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686579239; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5XlFuQXVEDYri1l5bqNadN5WFO/7K04QREToOase7Ps=; b=NvP+v4zOyBFQXazhe6Mi7gCMeDRyvKnEfoCeGaIrC/NW8GYpI/tgRBqSJtX5LVE5Lb50j9 mOD19hEG0AGHchAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3478A1357F; Mon, 12 Jun 2023 14:13:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id kKrrCycoh2RwGQAAMHmgww (envelope-from ); Mon, 12 Jun 2023 14:13:59 +0000 From: Thomas Zimmermann To: daniel@ffwll.ch, javierm@redhat.com, sam@ravnborg.org, deller@gmx.de, geert+renesas@glider.be, lee@kernel.org, daniel.thompson@linaro.org, jingoohan1@gmail.com, dan.carpenter@linaro.org, michael.j.ruhl@intel.com Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sh@vger.kernel.org, linux-omap@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Thomas Zimmermann , stable@vger.kernel.org Subject: [PATCH v2 14/38] fbdev/ep93xx-fb: Do not assign to struct fb_info.dev Date: Mon, 12 Jun 2023 16:07:52 +0200 Message-ID: <20230612141352.29939-15-tzimmermann@suse.de> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230612141352.29939-1-tzimmermann@suse.de> References: <20230612141352.29939-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Do not assing the Linux device to struct fb_info.dev. The call to register_framebuffer() initializes the field to the fbdev device. Drivers should not override its value. Fixes a bug where the driver incorrectly decreases the hardware device's reference counter and leaks the fbdev device. v2: * add Fixes tag (Dan) Signed-off-by: Thomas Zimmermann Fixes: 88017bda96a5 ("ep93xx video driver") Reviewed-by: Javier Martinez Canillas Cc: # v2.6.32+ --- drivers/video/fbdev/ep93xx-fb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/ep93xx-fb.c b/drivers/video/fbdev/ep93xx-fb.c index f6cd200fe50ff..37309f9dbe828 100644 --- a/drivers/video/fbdev/ep93xx-fb.c +++ b/drivers/video/fbdev/ep93xx-fb.c @@ -474,7 +474,6 @@ static int ep93xxfb_probe(struct platform_device *pdev) if (!info) return -ENOMEM; - info->dev = &pdev->dev; platform_set_drvdata(pdev, info); fbi = info->par; fbi->mach_info = mach_info; -- 2.41.0