Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5a9f41c1-3f29-ba35-8a45-634fca6a8bcb@linux.alibaba.com>
Date:   Mon, 12 Jun 2023 22:17:26 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.0
Subject: Re: [PATCH v7 4/5] erofs: unify inline/shared xattr iterators for
 listxattr/getxattr
To:     Jingbo Xu <jefflexu@linux.alibaba.com>, xiang@kernel.org,
        chao@kernel.org, huyue2@coolpad.com, linux-erofs@lists.ozlabs.org
Cc:     linux-kernel@vger.kernel.org
References: <20230612123745.36323-1-jefflexu@linux.alibaba.com>
 <20230612123745.36323-5-jefflexu@linux.alibaba.com>
From:   Gao Xiang <hsiangkao@linux.alibaba.com>
In-Reply-To: <20230612123745.36323-5-jefflexu@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/6/12 20:37, Jingbo Xu wrote:
> Make inline_{list,get}xattr() as well as inline_xattr_iter_begin()
> unified as erofs_iter_inline_xattr(), and shared_{list,get}xattr()
> unified as erofs_iter_shared_xattr().
> 

Could you use erofs_xattr_iter_inline() and erofs_xattr_iter_shared()?

Thanks,
Gao Xiang