Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp5627997rwd; Mon, 12 Jun 2023 07:39:02 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5FP6E6x35RZXgYljXWCu+LLo0j+Wv//01HUc/p7FqASfF1DjnMhFb+rUb2E+dI0GsJVDQw X-Received: by 2002:a17:90b:2318:b0:25b:dae4:205 with SMTP id mt24-20020a17090b231800b0025bdae40205mr3513974pjb.32.1686580742053; Mon, 12 Jun 2023 07:39:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686580742; cv=none; d=google.com; s=arc-20160816; b=nwVhBX37NfiayX3rwSidYRui0t7whYTsz760X+0hFGdUcWMLXGDFrA6u1g0LI5d0CO By6OsISoz2snCyyOzSYQmVKReoTN7AJ+UA6pLBJoVoIVk6bQlKydAjzJufYxj1G2p7g4 Q/DdUCRkJspjv32tS3P1Vk8ADpB9op37Ne3MMgN8KabeNWHplTM4yL8ynu7RwlLS4PUW nHaZ5+A5mgU6N4Yfw4t7uBggG2PO/RmCDoMEeffRS786ysLJNICVZaRrvW0l+S7iFIdh gBTqyAX5tT/TZusACJpWWwQnAwjro8H3ehqPA9+aVVMD0alCw9+p0YLjWfKbISylcetm SL4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=LdFYt/qoASITAY52DE6HZWdcNBV1SGXn2DcIPAfGew4=; b=dMYmqlS8nPca+bsZN4INTnfnjSnrtqC2WXv0aFlBf2fBc23wvMS5mcUXqItSMozk5x avCyOxxvWHSRwmHH48jqtjTt0eGjh5nyvNXHWToGbSbjxhoCRgjYbXnZbqrG1GJt77La BJDCiKGBQWw/fmf0ZT/BbLkMtH5CHlX+vk08zZH1j8re2VarK801X72NSxGKYprPY1jH ErDMgilzL5o93I+KsknYO0AQJW+7bnl7RCz18mdnEDb3ei9mp0tcHpQwYfYieyfklwZI qczl8t/yOTbOJpKBpnwgEu88z2fIWVcUYjS8BDw8xu0sYKKIdX7MNYEDB68ll9gnzswX zXkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="App3xnd/"; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r14-20020a17090a560e00b0025bde5b7785si1905603pjf.105.2023.06.12.07.38.48; Mon, 12 Jun 2023 07:39:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="App3xnd/"; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237610AbjFLOOe (ORCPT + 99 others); Mon, 12 Jun 2023 10:14:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237312AbjFLOOA (ORCPT ); Mon, 12 Jun 2023 10:14:00 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D917710F7; Mon, 12 Jun 2023 07:13:59 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 81C4020462; Mon, 12 Jun 2023 14:13:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686579238; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LdFYt/qoASITAY52DE6HZWdcNBV1SGXn2DcIPAfGew4=; b=App3xnd/PWP0Xs9iyWZuToNef4BTZlbLklZguTbxU4RJC8xXv4JLiO9FRTtxnZ1cEYtEh/ 3WV2Ep6TB6tCCdrFtcGpZf8iqaYD+mhmjYasnC8dELJYzMAobZ44gVC/OgnAirQ8jAc8Xn pWWh3RuXpclvXmwe6HUCnCJg38am17Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686579238; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LdFYt/qoASITAY52DE6HZWdcNBV1SGXn2DcIPAfGew4=; b=cVlodZvwWfCYOUvMHommz91hfORQOgDv3GTcQQ4PR/S7Yyrt0yLFdCFWheikmqenw7RhRw OH0fG1axuLAu33Aw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 363FE1357F; Mon, 12 Jun 2023 14:13:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YOo1DCYoh2RwGQAAMHmgww (envelope-from ); Mon, 12 Jun 2023 14:13:58 +0000 From: Thomas Zimmermann To: daniel@ffwll.ch, javierm@redhat.com, sam@ravnborg.org, deller@gmx.de, geert+renesas@glider.be, lee@kernel.org, daniel.thompson@linaro.org, jingoohan1@gmail.com, dan.carpenter@linaro.org, michael.j.ruhl@intel.com Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sh@vger.kernel.org, linux-omap@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v2 11/38] fbdev/broadsheetfb: Call device_remove_file() with hardware device Date: Mon, 12 Jun 2023 16:07:49 +0200 Message-ID: <20230612141352.29939-12-tzimmermann@suse.de> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230612141352.29939-1-tzimmermann@suse.de> References: <20230612141352.29939-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Call device_remove_file() with the same device that has been used for device_create_file(), which is the hardware device stored in struct fb_info.device. Prepares fbdev for making struct fb_info.dev optional. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/video/fbdev/broadsheetfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/broadsheetfb.c b/drivers/video/fbdev/broadsheetfb.c index 5f18af88e7408..5a5fe4bbc10b0 100644 --- a/drivers/video/fbdev/broadsheetfb.c +++ b/drivers/video/fbdev/broadsheetfb.c @@ -1200,7 +1200,7 @@ static void broadsheetfb_remove(struct platform_device *dev) if (info) { struct broadsheetfb_par *par = info->par; - device_remove_file(info->dev, &dev_attr_loadstore_waveform); + device_remove_file(info->device, &dev_attr_loadstore_waveform); unregister_framebuffer(info); fb_deferred_io_cleanup(info); par->board->cleanup(par); -- 2.41.0