Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Jun 2023 16:03:24 +0100
Message-ID: <86r0qgbu4j.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Mark Rutland <mark.rutland@arm.com>, linux-kernel@vger.kernel.org,
        Reiji Watanabe <reijiw@google.com>,
        Will Deacon <will@kernel.org>
Subject: Re: [PATCH] perf/core: Drop __weak attribute from arch_perf_update_userpage() prototype
In-Reply-To: <20230612145423.GC83892@hirez.programming.kicks-ass.net>
References: <20230603082519.1088285-1-maz@kernel.org>
        <ZIcarHx0qbfC2iyy@FVFF77S0Q05N>
        <20230612145423.GC83892@hirez.programming.kicks-ass.net>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2
 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 12 Jun 2023 15:54:23 +0100,
Peter Zijlstra <peterz@infradead.org> wrote:
> 
> On Mon, Jun 12, 2023 at 02:16:28PM +0100, Mark Rutland wrote:
> > On Sat, Jun 03, 2023 at 09:25:19AM +0100, Marc Zyngier wrote:
> > > Reiji reports that the arm64 implementation of arch_perf_update_userpage()
> > > is now ignored and replaced by the dummy stub in core code.
> > > This seems to happen since the PMUv3 driver was moved to driver/perf.
> > 
> > I guess we should have a Cc stable then?
> > 
> > The below implies this has always been on dodgy ground, and so it's probably
> > inaccurate to give this a Fixes tag pointing to the move.
> > 
> > > As it turns out, dropping the __weak attribute from the *prototype*
> > > of the function solves the problem. You're right, this doesn't seem
> > > to make much sense. And yet... It appears that both symbols get
> > > flagged as weak, and that the first one to appear in the link order
> > > wins:
> > > 
> > > $ nm drivers/perf/arm_pmuv3.o|grep arch_perf_update_userpage
> > > 0000000000001db0 W arch_perf_update_userpage
> > 
> > Ah, so having it on th *declaration* will apply to any *definition*. :/
> 
> Yikes..
> 
> > That suggests this is a bad pattern generally, and we should probably remove
> > the other __weak instances in headers. Lukcily it seems there aren't that many:
> > 
> > [mark@lakrids:~/src/linux]% git grep __weak -- **/*.h | wc -l
> > 50
> > 
> > IMO we'd should aim to remove __weak entirely; it causes a number of weird
> > things like this and it'd be much easier to manage with a small amount of
> > ifdeffery.
> > 
> > Peter, thoughts?
> 
> Not a fan of __weak myself, after having had to deal with how the
> compilers actually make it work.
> 
> Where do I queue this? perf/urgent?

That'd be my preference, as arm64 is currently a bit broken and I'd
like 6.4 to be functional.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.