Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp5716779rwd; Mon, 12 Jun 2023 08:45:38 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ64zk/tYMbMi1QU/dQAsS8OeIpGoOVHdPrTG6mh3OZTntKGVZJME+lzIp1JOB6W3idSlRUR X-Received: by 2002:a2e:9a92:0:b0:2a8:c75d:8167 with SMTP id p18-20020a2e9a92000000b002a8c75d8167mr3024371lji.4.1686584738336; Mon, 12 Jun 2023 08:45:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686584738; cv=none; d=google.com; s=arc-20160816; b=MpPJWBliEUIJWpRE1PgrAVqCjl/jDu6YbOOs9VJJz3MkeHE40Xxvs8K04YFq4KBVQE arnVzcRIuxM6CGRdkjdy40HpA3+VHf/hcwF2IsqhHi3SyjH7epdc+jSbQYiDwimiFeYE g8zSnZMzrGudCZAvDuGxGvWY4rKcIgRz9PZEFPiNI+ycz0qvAFlog0qRxszMLW4B7YZT 14uzS+0Duo2Hpcae92Y+4EHbiTOePIVPgZHD49PiR8he5s51UqxAzrpZYnwJegwqFEag p4jFaUosmlrPWHoxLd8hUlVzmxwhFK7GJiVaexdRmmdA/Z6epzjByLx92qUF9vJaZnGn oo0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=umaRAVEFst5u69VzvUUaqtvHKhrBfBJc4qRS1y2IjkA=; b=O/Rnsqehxtu0WCoimtAURy9kUHUQH5lZ0y/vna2Mv8FnlaFZt9WDUwdQoA1XS4keoB YwoxIU4WuSsXrx0Bcgpz2i3zhz9YGXNo9xYq/tLdZR2nzmE+prfRK9ZukOoltgL2nNLx cj/X1b7bmxmLnTuDsb6DwVesj63DLCUCLX/yxr9SB8e5+r572I2UL9X+Welku/H+mxF1 qTHbZo7yq8PBfLIPkEDO0zwbuJSte/g7tXC8InO9kYSAaDHgLX/BR801a9ByW3OuXeuq cDPflon0ai0Z/sR+z7wi3zbJ3NUqJaeYFproZEmNImnvjSIknfjHmBRywYgWQSTXtbbE KEXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=bHl84HgY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q6-20020a1709060e4600b0096f790ee863si5105225eji.70.2023.06.12.08.45.06; Mon, 12 Jun 2023 08:45:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=bHl84HgY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238430AbjFLPUi (ORCPT + 99 others); Mon, 12 Jun 2023 11:20:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237316AbjFLPUg (ORCPT ); Mon, 12 Jun 2023 11:20:36 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3362210F2; Mon, 12 Jun 2023 08:20:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686583222; x=1718119222; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=q8JaITbanHGw6fa7joaZEriYniFQhtzpInAYV2vakQg=; b=bHl84HgYi8AA69qSIKF88ZFwCZ+KhCOnJpLVHoqGqKEl5/yi4gINGLEr 0TA4NtdIy9lkslPmTiRWGkpb7QwHvQs6+2HlS0KEgt7f1Ty0hIRfFyLe3 ZAbYEjJA1ycdMW5RHHr4JISfThgQkCx0XqivMslJC8KDZbve+HTbWQwiV 1NYfK97+Hld6eGnD3QMoPEUewYfz5D1zvMHm1tA8lIXL30LxuCv4C54rw zXmOXMjY+k0OPMT+wnk1x4BZ+DNRbIuCPXucL7VZcUYtfQRgc/rF+lW5k yRFpsaHOeZbZOMeLwk9Xah7bPyCDupoWdyJIsscOhFfkqev+5RrUG8BkW w==; X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="360556475" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="360556475" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2023 08:20:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="741066906" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="741066906" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga008.jf.intel.com with ESMTP; 12 Jun 2023 08:20:19 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1q8jL7-00397x-1y; Mon, 12 Jun 2023 18:20:17 +0300 Date: Mon, 12 Jun 2023 18:20:17 +0300 From: Andy Shevchenko To: Sakari Ailus Cc: Damien Le Moal , Serge Semin , Greg Kroah-Hartman , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Hans de Goede , Jens Axboe , "Rafael J. Wysocki" , Len Brown , Daniel Scally , Heikki Krogerus Subject: Re: [PATCH v2 3/3] ata: ahci_platform: Make code agnostic to OF/ACPI Message-ID: References: <20230609154900.43024-1-andriy.shevchenko@linux.intel.com> <20230609154900.43024-4-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 12, 2023 at 08:02:44AM +0000, Sakari Ailus wrote: > On Fri, Jun 09, 2023 at 06:49:00PM +0300, Andy Shevchenko wrote: > > With the help of a new device_is_compatible() make > > the driver code agnostic to the OF/ACPI. This makes > > it neater. As a side effect the header inclusions is > > corrected (seems mod_devicetable.h was implicitly > > included). > > You're wrapping the lines well before 75. Why? Didn't pay attention to that much. Is it a problem? Should I send a new version because of that? > > Signed-off-by: Andy Shevchenko > > Reviewed-by: Sakari Ailus Thank you! -- With Best Regards, Andy Shevchenko