Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1681366162-4949-1-git-send-email-xinlei.lee@mediatek.com> <1681366162-4949-3-git-send-email-xinlei.lee@mediatek.com>
In-Reply-To: <1681366162-4949-3-git-send-email-xinlei.lee@mediatek.com>
From:   Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date:   Mon, 12 Jun 2023 23:18:09 +0800
Message-ID: <CAAOTY_-QwzY55V-dFcb2z69fRQwtoAat7ZKdScW29=3Lfe_LGA@mail.gmail.com>
Subject: Re: [PATCH 2/3] drm/mediatek: Add mt8188 dsi compatible to mtk_dsi.c
To:     xinlei.lee@mediatek.com
Cc:     chunkuang.hu@kernel.org, p.zabel@pengutronix.de, airlied@linux.ie,
        daniel@ffwll.ch, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
        jitao.shi@mediatek.com, shuijing.li@mediatek.com,
        dri-devel@lists.freedesktop.org,
        linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Project_Global_Chrome_Upstream_Group@mediatek.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Xinlei:

Reorder this patch after patch "[3/3] drm/mediatek: dsi: Add dsi
cmdq_ctl to send panel initial code"

Regards,
Chun-Kuang.

<xinlei.lee@mediatek.com> =E6=96=BC 2023=E5=B9=B44=E6=9C=8813=E6=97=A5 =E9=
=80=B1=E5=9B=9B =E4=B8=8B=E5=8D=882:09=E5=AF=AB=E9=81=93=EF=BC=9A
>
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add the compatible because there are different definitions for cmdq
> register bit control in mt8188.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++
>  drivers/gpu/drm/mediatek/mtk_dsi.c     | 8 ++++++++
>  2 files changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/med=
iatek/mtk_drm_drv.c
> index a13b36ac03a1..9ba05961479d 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -654,6 +654,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[=
] =3D {
>           .data =3D (void *)MTK_DSI },
>         { .compatible =3D "mediatek,mt8186-dsi",
>           .data =3D (void *)MTK_DSI },
> +       { .compatible =3D "mediatek,mt8188-dsi",
> +         .data =3D (void *)MTK_DSI },
>         { }
>  };
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediate=
k/mtk_dsi.c
> index 7d5250351193..500a3054282d 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -1208,6 +1208,12 @@ static const struct mtk_dsi_driver_data mt8186_dsi=
_driver_data =3D {
>         .has_size_ctl =3D true,
>  };
>
> +static const struct mtk_dsi_driver_data mt8188_dsi_driver_data =3D {
> +       .reg_cmdq_off =3D 0xd00,
> +       .has_shadow_ctl =3D true,
> +       .has_size_ctl =3D true,
> +};
> +
>  static const struct of_device_id mtk_dsi_of_match[] =3D {
>         { .compatible =3D "mediatek,mt2701-dsi",
>           .data =3D &mt2701_dsi_driver_data },
> @@ -1217,6 +1223,8 @@ static const struct of_device_id mtk_dsi_of_match[]=
 =3D {
>           .data =3D &mt8183_dsi_driver_data },
>         { .compatible =3D "mediatek,mt8186-dsi",
>           .data =3D &mt8186_dsi_driver_data },
> +       { .compatible =3D "mediatek,mt8188-dsi",
> +         .data =3D &mt8188_dsi_driver_data },
>         { },
>  };
>  MODULE_DEVICE_TABLE(of, mtk_dsi_of_match);
> --
> 2.18.0
>