Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Ruhl, Michael J" <michael.j.ruhl@intel.com>
To:     Thomas Zimmermann <tzimmermann@suse.de>,
        "daniel@ffwll.ch" <daniel@ffwll.ch>,
        "javierm@redhat.com" <javierm@redhat.com>,
        "sam@ravnborg.org" <sam@ravnborg.org>,
        "deller@gmx.de" <deller@gmx.de>,
        "geert+renesas@glider.be" <geert+renesas@glider.be>,
        "lee@kernel.org" <lee@kernel.org>,
        "daniel.thompson@linaro.org" <daniel.thompson@linaro.org>,
        "jingoohan1@gmail.com" <jingoohan1@gmail.com>,
        "dan.carpenter@linaro.org" <dan.carpenter@linaro.org>
CC:     "linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
        "Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
        "linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
        "linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: RE: [PATCH v2 01/38] backlight/bd6107: Compare against struct
 fb_info.device
Thread-Topic: [PATCH v2 01/38] backlight/bd6107: Compare against struct
 fb_info.device
Thread-Index: AQHZnTgtEZa+Yf7M/Uyn0VM1axsFgK+HRkGg
Date:   Mon, 12 Jun 2023 15:17:43 +0000
Message-ID: <IA1PR11MB641822AFCB0E0EA5856C7E59C154A@IA1PR11MB6418.namprd11.prod.outlook.com>
References: <20230612141352.29939-1-tzimmermann@suse.de>
 <20230612141352.29939-2-tzimmermann@suse.de>
In-Reply-To: <20230612141352.29939-2-tzimmermann@suse.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sbZy9do+O2W+7EaTO87y25qlmsUHPeYmdSpf3XM1sH5WH2A75VGw9lu06wdD?=
 =?us-ascii?Q?nhu9CsYBtsT8uxJAa+SIAftTwkTXLL+cU0CGpT7WpQ766s78kiS7DT1JJ4FZ?=
 =?us-ascii?Q?QcbVUZt/lqZnlBVWs9mRvBKo/9O8Luoz8kB1NQEvYExJ6FgU4G8kgChLN0NJ?=
 =?us-ascii?Q?cCCZl1fhaji8jXc9KrgQUlJ1VYj/DqbvTKlw960R2jLoBWH1CciRBb+Z7UG9?=
 =?us-ascii?Q?BWNVrZXyPh6Fe+1jT9YY8F94Ovw5fDcysFSH79H4eX8i7p6EkJ83Y1Na3hUq?=
 =?us-ascii?Q?oHp+sdG2gxfI52Im/tdOQxune/BWuxdt1WrECmjgPWqRklBLXUEkNKShq6W2?=
 =?us-ascii?Q?A0LPnma6wiLpj7nckp+AsTjhTiUvjW4qnttqX4H2mhrPE4BJmdddpVgxU1Fe?=
 =?us-ascii?Q?z89SEA9HpfGUuiKbtoCgCLH9Tlx7rjjAnQFItxij4p6DnNQESD0bXvR0TggP?=
 =?us-ascii?Q?8BY4OJU10N/D+/ITFLqQmbRIwQuR1BBv2J+JxVxKjoNmsTZB4l4fXOBHcIBe?=
 =?us-ascii?Q?DyXSHmPRVOFpYsSOPAAPIBLZlDxjmalfBE7MrJMlKsNCAe9xEolQTuvxTlPS?=
 =?us-ascii?Q?Cw/iVGUcjTs1cXkZPeBlKi2qZM+maMs2bZ6uZdRx+XWB+nlgb5K5D2WK75x5?=
 =?us-ascii?Q?tOaIrOIOUjtGYBmJOSCBFwcsVoZ4OL1L9d93zr11qnB+y6wDU0s27cFJST77?=
 =?us-ascii?Q?oszru/27N91wCEkXDuhIDjkbGhbIZDHivCdR47Th7cdiu0PZqp+o6xFQKv7Z?=
 =?us-ascii?Q?pKkE2cu4nJJsc2Y1alubAU6oiqV9h1v/CcQiRptEdHbTxBISFBZQPh+bHiaj?=
 =?us-ascii?Q?eLBiasRAHw911AQUtI3Q4Ms/OtelveOR8nOEO5RkqHfvIbMutkuUO7o9FNjD?=
 =?us-ascii?Q?ja+NY7jVuE4FnVqoHOeAoiSJov+iJcCbS9y2fmh68paPAIHeJ2Uom4j5k0Ou?=
 =?us-ascii?Q?A/qoGK2/LmuwO0ORGhcC/asB9sRpdevGy91vZCmIf6s3fcSnjoth4yktdNVL?=
 =?us-ascii?Q?ri8uTtVy2uJCiZlYa8RXSa/zyaYb7IktLTJ91YBuQBYIk0qGKReTGi7K4ZDE?=
 =?us-ascii?Q?cVYdUTOXFkdI4uSPW8U9N3M7kAdNX5Z6ZhhEI4aUpcfyauvhxye9RnZYeVst?=
 =?us-ascii?Q?M2qYrKV0DKJz4kwx85Uw229pnIm/CiAovu7kppB+NDMBacqr5Yj5vsNssiKQ?=
 =?us-ascii?Q?vHGLo5w1w62J7sZn0k0EnKSmsjwhgETR+x83mMGU9yqAn9p+MQZ7pk/+PLtN?=
 =?us-ascii?Q?EZJ4Ct8PmV/N0RczK4FTP06ty1vtD2yLZpixM4YxfM9tvhQ4gmO2z/PL22va?=
 =?us-ascii?Q?Jbtu6h8b8LMzWPpB4VVlnWYTCd+WABa+CjgjFoejnihWW0jXGcsuqjpft1KF?=
 =?us-ascii?Q?8k4vFGRMY8ztVkYWPc/yufSxwC401SzlvV0eKP87plNcX/VGljIieKGeuFBc?=
 =?us-ascii?Q?9z4vSs4DxRL/trlZQ1T98cbUBaFEztEJdaCnGy7PoeHqqTC9wpWzZU69oWsK?=
 =?us-ascii?Q?Cv1uRo4pZmfeLSjKoCvfpXPJJfe4MmCa5QbkIYHWpvEPbzZ2k2wLoQ1iql0U?=
 =?us-ascii?Q?2faG7KW6rIcDgIiezWOBvtY/DygySFAwtW7FkVVL?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6418.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 429e829a-734c-49e0-77a5-08db6b582ba2
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2023 15:17:43.5991
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: F/BpvOtxd7A9Fl2Vu39ZWtpxAoJkInQtv3mCET3Ctq0Uh3o5D9gnUHigS22/dbd+ZznkJuqd10vEafXK70O07l2sAqcz+KVlCmRtZnox2EE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8033
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>-----Original Message-----
>From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of
>Thomas Zimmermann
>Sent: Monday, June 12, 2023 10:08 AM
>To: daniel@ffwll.ch; javierm@redhat.com; sam@ravnborg.org;
>deller@gmx.de; geert+renesas@glider.be; lee@kernel.org;
>daniel.thompson@linaro.org; jingoohan1@gmail.com;
>dan.carpenter@linaro.org; Ruhl, Michael J <michael.j.ruhl@intel.com>
>Cc: linux-fbdev@vger.kernel.org; Laurent Pinchart
><laurent.pinchart+renesas@ideasonboard.com>; linux-sh@vger.kernel.org;
>linux-staging@lists.linux.dev; linux-kernel@vger.kernel.org; dri-
>devel@lists.freedesktop.org; stable@vger.kernel.org; Thomas Zimmermann
><tzimmermann@suse.de>; linux-omap@vger.kernel.org
>Subject: [PATCH v2 01/38] backlight/bd6107: Compare against struct
>fb_info.device
>
>Struct bd6107_platform_data refers to a platform device within
>the Linux device hierarchy. The test in bd6107_backlight_check_fb()
>compares it against the fbdev device in struct fb_info.dev, which
>is different. Fix the test by comparing to struct fb_info.device.
>
>Fixes a bug in the backlight driver and prepares fbdev for making
>struct fb_info.dev optional.
>
>v2:
>	* move renames into separate patch (Javier, Sam, Michael)
>
>Fixes: 67b43e590415 ("backlight: Add ROHM BD6107 backlight driver")
>Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>Cc: Lee Jones <lee@kernel.org>
>Cc: Daniel Thompson <daniel.thompson@linaro.org>
>Cc: Jingoo Han <jingoohan1@gmail.com>
>Cc: dri-devel@lists.freedesktop.org
>Cc: <stable@vger.kernel.org> # v3.12+
>Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
>---
> drivers/video/backlight/bd6107.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/video/backlight/bd6107.c
>b/drivers/video/backlight/bd6107.c
>index f4db6c064635b..e3410444ea235 100644
>--- a/drivers/video/backlight/bd6107.c
>+++ b/drivers/video/backlight/bd6107.c
>@@ -104,7 +104,7 @@ static int bd6107_backlight_check_fb(struct
>backlight_device *backlight,
> {
> 	struct bd6107 *bd =3D bl_get_data(backlight);
>
>-	return bd->pdata->fbdev =3D=3D NULL || bd->pdata->fbdev =3D=3D info->dev=
;
>+	return bd->pdata->fbdev =3D=3D NULL || bd->pdata->fbdev =3D=3D info->dev=
ice;

Thomas,

Looking at the fb.h file I see:

	struct device *device;		/* This is the parent */
	struct device *dev;		/* This is this fb device */

Is this documentation "correct"?  If so, how does that match what you are d=
oing here?

Thanks,

M

> }
>
> static const struct backlight_ops bd6107_backlight_ops =3D {
>--
>2.41.0