Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7575cded-9fc1-7ed7-da4d-bc4147ade742@meta.com>
Date:   Mon, 12 Jun 2023 08:19:38 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.12.0
Subject: Re: [PATCH bpf-next 1/5] bpf: Add bpf_cpumask_first_and() kfunc
Content-Language: en-US
To:     David Vernet <void@manifault.com>, bpf@vger.kernel.org
Cc:     ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
        martin.lau@linux.dev, song@kernel.org, yhs@fb.com,
        john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
        haoluo@google.com, jolsa@kernel.org, linux-kernel@vger.kernel.org,
        kernel-team@meta.com, tj@kernel.org
References: <20230610035053.117605-1-void@manifault.com>
From:   Yonghong Song <yhs@meta.com>
In-Reply-To: <20230610035053.117605-1-void@manifault.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjZBSVhuWW4wTDJ5c0NEc3A5OWZaOWNTNi9Jc05Jd090b29nVGZOVXdabnpx?=
 =?utf-8?B?MGNmTDJzOFNCK3BHVU8vQVloTkk4NDBHbTJVZktmaU1CaXViYUt2TXI1N1l1?=
 =?utf-8?B?MlZkMy9SeFE1MVdObTNmcmJwMkVmNzVXVFpzV1gxZDFheHJRejJYSHIvSjdu?=
 =?utf-8?B?aVdqQm82U0IrRG10VHArd0w3L2Z2WlhCRVlJMUlOS05RUjBNQUhDaTdLZno3?=
 =?utf-8?B?NlFQQXVlVmFwWFBzZ1NicjFyWlpZajJjRkl2MjlsUnlkTE5Ia092Y2RmMlpp?=
 =?utf-8?B?YnFKdm1PVUg4Sy85MjZla1RSTHU0bnM0VmQzYnRxMmZwYlhZeFZqbzFHTlNw?=
 =?utf-8?B?OTVsanlvL0xoa3cwUEp3Q1FOeENBRWpRYU9WV2c1RGFsbUxVa3VSSG5kcXAy?=
 =?utf-8?B?OUJndnY0Z2hudjNNSzIzSkNscGhFLzUrMUV2TTFTYkl5MHltcm4veGVjeVdO?=
 =?utf-8?B?NEJJUFV4TFhET0gwaHFqMzVaM1pIRWtSKytzbWN5RGxGTHVYbThJSkFMRk1a?=
 =?utf-8?B?dnhMbGx6Q2EvQzhFK29ZT1RSUWh3NEFZWGxFMmJNa0pPc0ZiNG45RjRobUdS?=
 =?utf-8?B?cmRBMS9zUk5KSU9YRU5SOFdvOW5xWEs1MTJsNjUzWjNjU2NHaEhHQkhIVlNZ?=
 =?utf-8?B?cXAvUkF3dG52azVaaFB1aGd2aXM2ZFNVZXovOWdTdGxjWWVrc3IwaTZkZkxI?=
 =?utf-8?B?OXdoQ1B4MDBVVmF0elJqbm9CSi92a0tNei84SzJGdGxnRmlTQkNwZEVLUVgy?=
 =?utf-8?B?RDJJWk0wQ0krLzJEdGY4R3l3Z1l4dnB6ci9UN0lZa09vT0RBUVJ4SGxqd1Mx?=
 =?utf-8?B?YnBkb1lhWFJiQjEwSCtoN3lUU2JXRVNBdzVOWGNkS3VBeHVkcVc0clRsUXM5?=
 =?utf-8?B?NEhGUmNRaGc0a3d2MlZRZm1aQjU0ZUx5NlFwckFpVkhYaUEwWVZxY3FJWlJ4?=
 =?utf-8?B?VEdQY1VmMTJ3U0dZYnlFdjVZd0VTeEFlS2lYT1UvVzBrWEY1OVhOUnZlNzZE?=
 =?utf-8?B?dTJTaHZCS1JpOFdYQUUvWk9BejdFVzMrVmIyTDFyU1lLdktnMU0rTVN4YUUw?=
 =?utf-8?B?OFpFcFZCSHVhSFIrbGZBcUtaV1VaRnYwUGpKR3AyRnUzNW84WTFhT21tQ1ND?=
 =?utf-8?B?NFBUUi9rU3JMSkZ5ZkpWZWZSVTdCMWhjM1UvYTZ5cThlVmdjNitEVTV2WmFB?=
 =?utf-8?B?c3ZZQ0d2T1FtT1NpRzk5L3A4TTdQMjNBUngzRmJZUmhlbjhTRmRYR3lTczVS?=
 =?utf-8?B?VFRNTUF6WjUvQUIxQU11KzBXSVFuSkE0WGloeVdxZTBCTHpFaGVrS05aaklM?=
 =?utf-8?B?N0xjeUk2OGdsdkxNRnhMbFJLQjMvNVN5OVg3OTR2bFpIOHAvQ3d0THZob3Y2?=
 =?utf-8?B?b3R4T0RiK09QRElLVnNUK3BJdmUxbUdJWGJCVll5Mm5CdWRVTUJEN25mWXdh?=
 =?utf-8?B?TE5mVmM4bHNhTUppcjJWamduWjFFNjF4STM4eU10cms2aE1CZzJ6MWU1cHNE?=
 =?utf-8?B?OHhrZkpWSkxnZ3p0WTZEQ0RMUVA5YzlQTzdRU0tQUG0xeXUwMXc1Um9mYzhE?=
 =?utf-8?B?WUxjNTZNejFMd2NwWDl2eG9KaVF2VStiODQyamZ4VEpUMTBqU2I4UVl1bFdP?=
 =?utf-8?B?endaTUF3YVNQbHZrd2VVVWUyQnJOdjIxR1d3STgwOUxya2w1d2RJUE9iU1V0?=
 =?utf-8?B?MlYzQ0MvVndaYzFWdmdpWkZ1TklQS29KNUdpSWVoTk1EbVZpdzFxVzdoOVR2?=
 =?utf-8?B?WEloUnRoSGlwQ1drT1dneHAyeUNQb3ZVU1YvM3MwblkyUGFkM3B1NEw3VmZN?=
 =?utf-8?B?NXM4c0srMEFkZTFiNndJMmN5YzA5UVhNempGY0htTkNRZi9UZTdhdkdsVDdw?=
 =?utf-8?B?Q0RzWFc1N0JPckNZeVZCYzhFakN5Z1k3dmQ0MWpGUFhoeTBFWjIvU294akNo?=
 =?utf-8?B?SmszU0FHUjdFV1Rsa1cwUk0yaThHR0xzWk90ZjZPb0ZaTWM0NlhYWHdCNk80?=
 =?utf-8?B?MUVXcW4wVUN5KzlpRmY4TWxzSTR2ak55dlM2YjNKVlpVNHQ2UnFyTnUvai8r?=
 =?utf-8?B?eGlja2NPSUgyMk9Bb21wL0hDTkhBa0x1VXhraCs0QVZNamlnUnA2MnlheUNh?=
 =?utf-8?B?YjN3QzRVN3dZaEtuMWpyajV5V3VmMmcrcTlpWTBNdG9FWEJyU0FDYkM5L29Q?=
 =?utf-8?B?MkE9PQ==?=
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 09c5f26d-6dbb-49cf-245a-08db6b5872b3
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 15:19:42.9953
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UQes40Z3Kb0UPwN56+cUV9bfX2vOQBEwvSrP03+9kIyCLHZB1ftx9Dm0Ri1jrhde
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR15MB4898
X-Proofpoint-GUID: GMsr9C_nvO5pehwDLLIHZ1yaqKJiVi0z
X-Proofpoint-ORIG-GUID: GMsr9C_nvO5pehwDLLIHZ1yaqKJiVi0z
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-06-12_06,2023-06-09_01,2023-05-22_02
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/9/23 8:50 PM, David Vernet wrote:
> We currently provide bpf_cpumask_first(), bpf_cpumask_any(), and
> bpf_cpumask_any_and() kfuncs. bpf_cpumask_any() and
> bpf_cpumask_any_and() are confusing misnomers in that they actually just
> call cpumask_first() and cpumask_first_and() respectively.
> 
> We'll replace them with bpf_cpumask_any_distribute() and
> bpf_cpumask_any_distribute_and() kfuncs in a subsequent patch, so let's
> ensure feature parity by adding a bpf_cpumask_first_and() kfunc to
> account for bpf_cpumask_any_and() being removed.
> 
> Signed-off-by: David Vernet <void@manifault.com>

Acked-by: Yonghong Song <yhs@fb.com>