Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp5754264rwd; Mon, 12 Jun 2023 09:10:11 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5q7jWrvaM4vtkOOSReH8pk8ICE8R9esT/ehROTeIeVb0DHrvqj15Gk1RcYE0/l8AGb1Cn1 X-Received: by 2002:a17:906:d542:b0:94f:36a0:da45 with SMTP id cr2-20020a170906d54200b0094f36a0da45mr11731950ejc.29.1686586211431; Mon, 12 Jun 2023 09:10:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686586211; cv=none; d=google.com; s=arc-20160816; b=hWyijfn/ofQWRbXWlcb2v4HTkomWl97wtMduha93AVD0ZXtEYKQKAR3MpF6WRvnpzY n5LysdhI3FTCRmze7v1G/KGOcnwdeoywdR8Ae4L9hYY+Ot8vnn3t3pXbIUr0goey//Y6 DG5CxSrLPoZoCrR8eC7UaDBEEhffm2iOIAg4P0o+6NWHZxmVCMDdveZWyT/o2dnwONBX /m4hL4jw5beVu9Ctod+Vwq3/4cSPG7+J8tYyJlzxNvQGGHn0tBuLmoqLY/7CnGfgwfDc tEJhu1LEelYufCCG1BTyOoSD3IAmyuf/nxbccWTzPnOVR3ow6BTPMExwkeH/veoX9t2U DGkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=03Uv8p5M7gEkdkNdSPyShEzWZ6NYMd5z8nkRrTJAMPo=; b=Ajj6ZQgejBx3pZY/kJRc+yjE5T4/WQ7YLSacsiW5Ts3hc6q92uOVUokaZtMWqRO7LC mb1n6DZuz0On2DpYEM7NhIE6wORjp7nDKuLNEkYmI5rofBoaegn0FF0fDLFYNswp+2uH IcbaBWCpt4ri61L/quCwlhdlcDSW9bMjc5GOUzz1JYE390tFz5QfLtYS2RbE6JGKhGlF dIZc2UbQKcp8trqiiEgFnBxDbcSriZTGR+wZ6x144iWDptuE1KeANExZCOoG93EdtqLh bO8qMzSRz/sXlIqof5hJUfEQPtDYwRGubM9ijpXezt3pMajb76fQux2EbgDOcIKZj5Ux o0FQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FeEk1W1v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bu13-20020a170906a14d00b0096f63913462si5396077ejb.1008.2023.06.12.09.09.46; Mon, 12 Jun 2023 09:10:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FeEk1W1v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239684AbjFLPpi (ORCPT + 99 others); Mon, 12 Jun 2023 11:45:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235366AbjFLPpc (ORCPT ); Mon, 12 Jun 2023 11:45:32 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8176E10F7 for ; Mon, 12 Jun 2023 08:44:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686584678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=03Uv8p5M7gEkdkNdSPyShEzWZ6NYMd5z8nkRrTJAMPo=; b=FeEk1W1veFezITsBgt9tp7FUs4IbFxfGEl6ulNBys5bSlABei25ACfCbfuj+aO13t796fy Z29bds4O+0SlpFFr4e3G82fe0QLfeEr8kuIRNB46H/ST5jltvB0OPtkChhJKeQPaLMcgNV oLcPRb4RMh5ueQ2URQvcBRDs+pRb77M= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-301-26wjdDJJMDicMIQ0bGewog-1; Mon, 12 Jun 2023 11:44:37 -0400 X-MC-Unique: 26wjdDJJMDicMIQ0bGewog-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f7f2d9a660so17709635e9.2 for ; Mon, 12 Jun 2023 08:44:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686584676; x=1689176676; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=03Uv8p5M7gEkdkNdSPyShEzWZ6NYMd5z8nkRrTJAMPo=; b=bdT0P9kbK3B+6/UDF/2HqXP9Xc7Pu4v8c+m0pdgD4E5fIMN9dEWaybstEQG9SRXT3I WHwa91zisAvkZmJJz0sgQqixlIZz8r88ePQ28yS0EYXAl08ZsT+SKkpefXppzbNG1IGL 45iFvrbmKwKQTNaJ6EbpEvYrJJ8px2Bndhy2gUebK+Bsv6NYDZwHVOJL6wP9bc9M24PN U2RO+Nbjw76gVBQOL8LscVK9o+vFkcACfBe2pmcPv+0V5LiQaweyLnaIZ4l8PiRZJ6IZ /Ji2zHBMYNDI/epGbM6Z2eRycG9FPCZY4Z5Ef/dRKBXf5peKMyMJ91uHkvXXRBFkppvD oiaA== X-Gm-Message-State: AC+VfDzQQW0H/rGaTjRIvlvgITEGAyITLeyTTVuA42T0fZdlAPEizt8v zxnN2N9UTJfA6Bc+O/3IhgiXWydpP5R122PIiTDL/sLz14wrHFg7zP3tKKgDB2WYCHSErQ+K4lt gUxvlydjAI2X5Jc1I1SMYm6vQ X-Received: by 2002:a7b:c40a:0:b0:3f8:648:bba with SMTP id k10-20020a7bc40a000000b003f806480bbamr6931481wmi.8.1686584676467; Mon, 12 Jun 2023 08:44:36 -0700 (PDT) X-Received: by 2002:a7b:c40a:0:b0:3f8:648:bba with SMTP id k10-20020a7bc40a000000b003f806480bbamr6931459wmi.8.1686584676188; Mon, 12 Jun 2023 08:44:36 -0700 (PDT) Received: from vschneid.remote.csb ([154.57.232.159]) by smtp.gmail.com with ESMTPSA id s12-20020a7bc38c000000b003f7ba52eeccsm11810463wmj.7.2023.06.12.08.44.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 08:44:35 -0700 (PDT) From: Valentin Schneider To: Tom Rix , mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com Cc: linux-kernel@vger.kernel.org, Tom Rix Subject: Re: [PATCH] sched/fair: rename variable cpu_util eff_util In-Reply-To: <20230611122535.183654-1-trix@redhat.com> References: <20230611122535.183654-1-trix@redhat.com> Date: Mon, 12 Jun 2023 16:44:34 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/06/23 08:25, Tom Rix wrote: > cppcheck reports > kernel/sched/fair.c:7436:17: style: Local variable 'cpu_util' shadows outer function [shadowFunction] > unsigned long cpu_util; > ^ > > Clean this up by renaming the variable to eff_util > > Signed-off-by: Tom Rix Reviewed-by: Valentin Schneider