Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d4476c3b-9923-dde2-8338-9f67ebfc729f@quicinc.com>
Date:   Mon, 12 Jun 2023 21:17:07 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] accel/qaic: Fix dereferencing freed memory
Content-Language: en-US
To:     Jeffrey Hugo <quic_jhugo@quicinc.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        Sukrut Bellary <sukrut.bellary@linux.com>,
        "Oded Gabbay" <ogabbay@kernel.org>,
        Sumit Semwal <sumit.semwal@linaro.org>
CC:     <linux-arm-msm@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
        <linaro-mm-sig@lists.linaro.org>, <linux-media@vger.kernel.org>
References: <20230610021200.377452-1-sukrut.bellary@linux.com>
 <fc979a4e-c30a-2606-9eec-afbba4fdd774@amd.com>
 <e3a867a8-284b-7250-b1b2-1956f533f6b0@quicinc.com>
 <ff196b04-e8c5-52d9-852b-9a9cc7eecdd0@amd.com>
 <b5e5c141-b5df-e24d-8fa4-94297d561cec@quicinc.com>
From:   Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@quicinc.com>
In-Reply-To: <b5e5c141-b5df-e24d-8fa4-94297d561cec@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 6/12/2023 8:39 PM, Jeffrey Hugo wrote:
> On 6/12/2023 7:21 AM, Christian König wrote:
>> Am 12.06.23 um 15:03 schrieb Pranjal Ramajor Asha Kanojiya:
>>>
>>>
>>> On 6/12/2023 4:52 PM, Christian König wrote:
>>>>
>>>>
>>>> Am 10.06.23 um 04:12 schrieb Sukrut Bellary:
>>>>> smatch warning:
>>>>>     drivers/accel/qaic/qaic_data.c:620 qaic_free_object() error:
>>>>>         dereferencing freed memory 'obj->import_attach'
>>>>>
>>>>> obj->import_attach is detached and freed using dma_buf_detach().
>>>>> But used after free to decrease the dmabuf ref count using
>>>>> dma_buf_put().
>>>>>
>>>>> Fixes: ff13be830333 ("accel/qaic: Add datapath")
>>>>> Signed-off-by: Sukrut Bellary <sukrut.bellary@linux.com>
>>>>> ---
>>>>>   drivers/accel/qaic/qaic_data.c | 4 +++-
>>>>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/drivers/accel/qaic/qaic_data.c 
>>>>> b/drivers/accel/qaic/qaic_data.c
>>>>> index e42c1f9ffff8..7cba4d680ea8 100644
>>>>> --- a/drivers/accel/qaic/qaic_data.c
>>>>> +++ b/drivers/accel/qaic/qaic_data.c
>>>>> @@ -613,11 +613,13 @@ static int qaic_gem_object_mmap(struct 
>>>>> drm_gem_object *obj, struct vm_area_struc
>>>>>   static void qaic_free_object(struct drm_gem_object *obj)
>>>>>   {
>>>>>       struct qaic_bo *bo = to_qaic_bo(obj);
>>>>> +    struct dma_buf *dmabuf;
>>>>
>>>> Maybe move that variable into the if.
>>>>
>>>>>       if (obj->import_attach) {
>>>>>           /* DMABUF/PRIME Path */
>>>>> +        dmabuf = obj->import_attach->dmabuf;
>>>>>           dma_buf_detach(obj->import_attach->dmabuf, 
>>>>> obj->import_attach);
>>>>> -        dma_buf_put(obj->import_attach->dmabuf);
>>>>> +        dma_buf_put(dmabuf);
>>>>
>>>> I strongly assume you are not using the GEM prime helpers for this?
>>>>
>>>> Christian.
>>>
>>> Driver uses drm_gem_prime_fd_to_handle() helper function but it also 
>>> registers for ->gem_prime_import() which is internally called by 
>>> drm_gem_prime_fd_to_handle(). All the operations done in 
>>> gem_prime_import() are undone here.
>>
>> Then why don't you use drm_prime_gem_destroy() which is the cleanup 
>> helper for imports created by ->gem_prime_import() ?
>>
>> That looks pretty much identical to what you do here manually.
> 
> I think destroy() wasn't used because we are new to DRM and sometimes 
> confused by the multitude of options.  I appreciate the suggestion and 
> will follow up to see if destroy() will work here, or identify what 
> would prevent the use of it.
> 
> -Jeff

Thank you Christian for your suggestion. I agree with you driver can use 
  drm_prime_gem_destroy() here.