Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Jun 2023 08:36:26 -0700
From:   Jaegeuk Kim <jaegeuk@kernel.org>
To:     Chao Yu <chao@kernel.org>
Cc:     linux-kernel@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: compress tmp files given extension
Message-ID: <ZIc7ek4UWwjB41a5@google.com>
References: <20230606203645.3926651-1-jaegeuk@kernel.org>
 <7af0f599-2314-56af-2813-5e63754134e1@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7af0f599-2314-56af-2813-5e63754134e1@kernel.org>
Precedence: bulk

On 06/12, Chao Yu wrote:
> On 2023/6/7 4:36, Jaegeuk Kim wrote:
> > Let's compress tmp files for the given extension list.
> 
> Could you please check below commit? IIRC, it was introduce to avoid compressing
> file which has unpredictable tmp file, e.g. foo.sox.
> 
> Could you please describe the case you encounter?

I don't know what I need to describe more tho, looking at how to compress
abc.so.tmp and abc.so, given compress_extension=so.

So, your concern is somehow abc.soa? If so, we need to fix is_extension_exist.
Will check what's going on here.

> 
> commit 4a67d9b07ac8dce7f1034e0d887f2f4ee00fe118
> Author: Chao Yu <chao@kernel.org>
> Date:   Tue May 18 17:54:58 2021 +0800
> 
>     f2fs: compress: fix to disallow temp extension
> 
>     This patch restricts to configure compress extension as format of:
> 
>      [filename + '.' + extension]
> 
>     rather than:
> 
>      [filename + '.' + extension + (optional: '.' + temp extension)]
> 
>     in order to avoid to enable compression incorrectly:
> 
>     1. compress_extension=so
>     2. touch file.soa
>     3. touch file.so.tmp
> 
> Thanks,
> 
> > 
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> >   fs/f2fs/namei.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
> > index 3e35eb7dbb8f..cdc94c8e60f7 100644
> > --- a/fs/f2fs/namei.c
> > +++ b/fs/f2fs/namei.c
> > @@ -161,7 +161,7 @@ static void set_compress_new_inode(struct f2fs_sb_info *sbi, struct inode *dir,
> >   	/* Compress wanting extension. */
> >   	for (i = 0; i < ext_cnt; i++) {
> > -		if (is_extension_exist(name, ext[i], false)) {
> > +		if (is_extension_exist(name, ext[i], true)) {
> >   			set_compress_context(inode);
> >   			return;
> >   		}