Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Jun 2023 18:31:54 +0200
From:   Mehdi Djait <mehdi.djait.k@gmail.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     jic23@kernel.org, mazziesaccount@gmail.com,
        krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
        lars@metafoo.de, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 5/7] iio: accel: kionix-kx022a: Refactor driver and
 add chip_info structure
Message-ID: <ZIdIev+evQUvX5Rg@carbian>
References: <cover.1686578553.git.mehdi.djait.k@gmail.com>
 <3a41a5ae9857cacdb062c398715a5938ccd47014.1686578554.git.mehdi.djait.k@gmail.com>
 <ZIc/uvB1zxNRnuRS@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZIc/uvB1zxNRnuRS@smile.fi.intel.com>
Precedence: bulk

Hello Andy,

On Mon, Jun 12, 2023 at 06:54:34PM +0300, Andy Shevchenko wrote:
> On Mon, Jun 12, 2023 at 04:22:08PM +0200, Mehdi Djait wrote:
> > Add the chip_info structure to the driver's private data to hold all
> > the device specific infos.
> > Refactor the kx022a driver implementation to make it more generic and
> > extensible.
> 
> ...
> 
> > +	chip_info = spi_get_device_match_data(spi);
> 
> Missing check. You addressed only I?C case. Is there any explanation?

I will add the check for the SPI case

> 
> ...
> 
> >  struct kx022a_data {
> > +	const struct kx022a_chip_info *chip_info;
> >  	struct regmap *regmap;
> 
> I would suggest to run bloat-o-meter with this version and if you place
> chip_info after regmap. Does it gain us some memory?

I used the bloat-o-meter on the two .ko files (this version and the the
one where chip_info after regamp) Is this what you asked for ?  

add/remove: 0/0 grow/shrink: 0/5 up/down: 0/-20 (-20)
Function                                     old     new   delta
kx132_get_fifo_bytes                         148     144      -4
kx022a_trigger_set_state                     352     348      -4
kx022a_read_raw                              380     376      -4
kx022a_buffer_predisable                     248     244      -4
kx022a_buffer_postenable                     296     292      -4
Total: Before=11244, After=11224, chg -0.18%

--
Kind Regards
Mehdi Djait