Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230609124408.3788680-1-thierry.reding@gmail.com> <3c501536-2620-0022-df93-415d490fc1a5@linaro.org>
In-Reply-To: <3c501536-2620-0022-df93-415d490fc1a5@linaro.org>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Mon, 12 Jun 2023 19:43:19 +0200
Message-ID: <CAJZ5v0jwZt3HOJi3sBGR50G01K+pHSAsJd1UVBfZofpWBAvnVA@mail.gmail.com>
Subject: Re: [PATCH] thermal: Allow selecting the bang-bang governor as default
To:     Daniel Lezcano <daniel.lezcano@linaro.org>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>, linux-pm@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Mon, Jun 12, 2023 at 11:07 AM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
>
> Hi Thierry,
>
> On 09/06/2023 14:44, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > For many setups the bang-bang governor is exactly what we want. Many
> > ARM SoC-based devices use fans to cool down the entire SoC and that
> > works well only with the bang-bang governor because it uses the
> > hysteresis in order to let the fan run for a while to cool the SoC
> > down below the trip point before switching it off again.
>
> Yeah, that trip point detection is screwed up at the moment, but we are
> on the way to solve that. From there, we should be able to have the
> step_wise governor working as the bang-bang governor and remove this one.
>
> Meanwhile, the change sounds ok for me.
>
> Rafael, may I pick this change?

Please do, thank you!