Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230519201249.31147-1-leoyang.li@nxp.com> <CAJZ5v0i1nspPuHuUoLsWOz7MLnnB8bv=cXYbFcv0a=okBxBg3w@mail.gmail.com>
 <SJ1PR11MB6083D48DECD2C43B5F1ED4EBFC4DA@SJ1PR11MB6083.namprd11.prod.outlook.com>
In-Reply-To: <SJ1PR11MB6083D48DECD2C43B5F1ED4EBFC4DA@SJ1PR11MB6083.namprd11.prod.outlook.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Mon, 12 Jun 2023 19:33:02 +0200
Message-ID: <CAJZ5v0h6dqtvh7bUx_yrGnt32dcye-m8Yu5-FfUYZ4WgRoP9rg@mail.gmail.com>
Subject: Re: [PATCH v2] apei/ghes: correctly return NULL for ghes_get_devices()
To:     "Luck, Tony" <tony.luck@intel.com>, Li Yang <leoyang.li@nxp.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Borislav Petkov <bp@alien8.de>, Len Brown <lenb@kernel.org>,
        James Morse <james.morse@arm.com>, Jia He <justin.he@arm.com>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Mon, Jun 5, 2023 at 7:26 PM Luck, Tony <tony.luck@intel.com> wrote:
>
> > > Since 315bada690e0 ("EDAC: Check for GHES preference in the
> > > chipset-specific EDAC drivers"), vendor specific EDAC driver will not
> > > probe correctly when CONFIG_ACPI_APEI_GHES is enabled but no GHES device
> > > is present.  Make ghes_get_devices() return NULL when the GHES device
> > > list is empty to fix the problem.
> > >
> > > Fixes: 9057a3f7ac36 ("EDAC/ghes: Prepare to make ghes_edac a proper module")
> > > Signed-off-by: Li Yang <leoyang.li@nxp.com>
> > > Cc: Jia He <justin.he@arm.com>
> >
> > Boris, Tony, any comments?
>
> All of the callers are expecting NULL for a failure, not an empty list. So this looks OK to me.
>
> Reviewed-by: Tony Luck <tony.luck@intel.com>

Applied as 6.5 material, thanks!