Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Jun 2023 19:35:55 +0200
From:   Mehdi Djait <mehdi.djait.k@gmail.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     jic23@kernel.org, mazziesaccount@gmail.com,
        krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
        lars@metafoo.de, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 5/7] iio: accel: kionix-kx022a: Refactor driver and
 add chip_info structure
Message-ID: <ZIdXe3Vp4uHEGeRr@carbian>
References: <cover.1686578553.git.mehdi.djait.k@gmail.com>
 <3a41a5ae9857cacdb062c398715a5938ccd47014.1686578554.git.mehdi.djait.k@gmail.com>
 <ZIc/uvB1zxNRnuRS@smile.fi.intel.com>
 <ZIdIev+evQUvX5Rg@carbian>
 <ZIdSO7MGk3K/R2u1@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZIdSO7MGk3K/R2u1@smile.fi.intel.com>
Precedence: bulk

Hello Andy,

On Mon, Jun 12, 2023 at 08:13:31PM +0300, Andy Shevchenko wrote:
> On Mon, Jun 12, 2023 at 06:31:54PM +0200, Mehdi Djait wrote:
> > On Mon, Jun 12, 2023 at 06:54:34PM +0300, Andy Shevchenko wrote:
> > > On Mon, Jun 12, 2023 at 04:22:08PM +0200, Mehdi Djait wrote:
> 
> ...
> 
> > > >  struct kx022a_data {
> > > > +	const struct kx022a_chip_info *chip_info;
> > > >  	struct regmap *regmap;
> > > 
> > > I would suggest to run bloat-o-meter with this version and if you place
> > > chip_info after regmap. Does it gain us some memory?
> > 
> > I used the bloat-o-meter on the two .ko files (this version and the the
> > one where chip_info after regamp) Is this what you asked for ?
> 
> Yes. I assume the old one is the current as in this patch?

Yes

> If so, you know what to do in the next version :-)

Yes, I will change it in the next version :)

--
Kind Regards
Mehdi Djait