Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp156164rwd; Mon, 12 Jun 2023 11:27:03 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6ikZ1bNAp+p/tcEIM0CV8k70nOtDg66KTqPwoeu0PuG4DF1RXQVylR8ComUI3hdwNwR1QP X-Received: by 2002:a05:6a21:99a5:b0:10c:62b3:7dc4 with SMTP id ve37-20020a056a2199a500b0010c62b37dc4mr11179328pzb.55.1686594423063; Mon, 12 Jun 2023 11:27:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686594423; cv=none; d=google.com; s=arc-20160816; b=zm/mo7Kb4nMc2W0wKkMZeSN1AJzwZLWYQYkEjaNF6AlhA9F8ZhsfpcT17Jow/9oeXD P+qgdgO9kwdgLCG7EiHJi7A1jEzo8GC7glRNk2D+HhiaQGW4GQnQS0wc5Hdyt/mLOkPD 7mADAQ/a4E+P1ofFib0cYRhsvsRWM2uwirtFgv3HnYskrP/dgkD+XN5ngczwEGUn+w+4 LzzTbQr9Env+Uq3slN5ba+HkbULQkAP+swkbMKHa8L0vEkFVvUglTb5Gm52yff9jM2YA IcMNt3QIu1VM6jeyC6giA1ZhGwZviyirB1Py09DpJekTkFZ8IsvEc2nHfXoMhQIr25BL d1KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=XyzQ4No+RLHAAwpMFK+EQR9jGsjSskvb0lQK3qnBq3I=; b=I53je7pUghhd6njStLtwK3Iu3yOFv30Ni6tVgrPbxIR2KJyUmRhDe9TldWR3CFW6eL VLLe+/8zksvqnZ2AHq+QGEjkZHizdozBymYcxNnKOm+oqBI4744Xywz6ESfI+nCgL91J l6Dffl1ukJ+EPZpL11KL5j2MsztBUiwyDpFf9bbJi8fhyWgizZMX5X4j9qvYVtaEXZYZ ry05laIS2hlM41HfMLJkrTVgIGeGen71qt0cKXsY4ExclyGjZn9Rljt9NkcCD/s21gfZ lGk7FRQupNDhbJKFdhBx9Zi4EGVBtByU/9bS6F2rFm7rSU6a/vrXnD0M5EvS7VGHX1mw VVBA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v202-20020a6361d3000000b0054f9f9d1d90si886086pgb.643.2023.06.12.11.26.50; Mon, 12 Jun 2023 11:27:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237490AbjFLSVX (ORCPT + 99 others); Mon, 12 Jun 2023 14:21:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237000AbjFLSVW (ORCPT ); Mon, 12 Jun 2023 14:21:22 -0400 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2D70E8; Mon, 12 Jun 2023 11:21:20 -0700 (PDT) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1b3db8f3d94so5356785ad.1; Mon, 12 Jun 2023 11:21:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686594080; x=1689186080; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XyzQ4No+RLHAAwpMFK+EQR9jGsjSskvb0lQK3qnBq3I=; b=Rbae0nQ/+rpdPuzMGkNqkjjjeY4G8TDjp7oSMJcj66xh0nXvVGCf4r8COENWWLwtXZ 0kZdNe5v+8HqSqaM6Fd5m1UUKbXnwPxHZstzBZfjnZfwuisYHzxvpC4G1ZhDySp75oiO Mjtmlt36apusvONontwSDfqWXt72ALShkMoKO0k/OUJ9Y1aDFuhcVCQikMOS2d1DtYaM PyNZPKNsBMjw+yfWOmzjsNYH+cAyx4nSzWNBenN5wCrXkqn5qts3H1IV8k3dtihWM/nA 7TKUlEtxUl2uSTNF1BjXCB3siz2GR4378PQw+eMGJIqfpmRIPonm2ZiE4Jwu/rFcmhFC NIwg== X-Gm-Message-State: AC+VfDzxG2a/Tx7ADeMSeak/hj7mSnGnKaJk2FTmA6MHy1xIZx8SDBgk M+rpjYdd2XBrhswc5Xu/6nE= X-Received: by 2002:a17:902:c401:b0:1b1:753a:49ce with SMTP id k1-20020a170902c40100b001b1753a49cemr8867704plk.53.1686594079956; Mon, 12 Jun 2023 11:21:19 -0700 (PDT) Received: from [192.168.3.219] ([98.51.102.78]) by smtp.gmail.com with ESMTPSA id d6-20020a170903230600b001ae57277a87sm8558051plh.255.2023.06.12.11.21.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jun 2023 11:21:19 -0700 (PDT) Message-ID: Date: Mon, 12 Jun 2023 11:21:18 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v4] scsi: ufs: wb: Add explicit flush_threshold sysfs attribute Content-Language: en-US To: Lu Hongfei , Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Daniil Lunev , Jinyoung Choi , Bean Huo , Peter Wang , open list , "open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER" Cc: opensource.kernel@vivo.com References: <20230609091113.22531-1-luhongfei@vivo.com> From: Bart Van Assche In-Reply-To: <20230609091113.22531-1-luhongfei@vivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/9/23 02:11, Lu Hongfei wrote: > +What: /sys/bus/platform/drivers/ufshcd/*/wb_flush_threshold > +What: /sys/bus/platform/devices/*.ufs/wb_flush_threshold > +Date: June 2023 > +Contact: Lu Hongfei > +Description: wb_flush_threshold is a percentage that represents the threshold for flush WB. > + When avail_wb_buff < wb_flush_threshold, the dev will flush WB when entered H8. > + When avail_wb_buff >= wb_flush_threshold, it is not necessary. "Percentage" suggests a number in the range 0..100 while the valid range is 0..10. Please fix this. Thanks, Bart.