Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Jun 2023 15:17:43 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Su Hui <suhui@nfschina.com>
Cc:     Joerg Roedel <joro@8bytes.org>,
        Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
        Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>, kevin.tian@intel.com,
        vasant.hegde@amd.com, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iommu/amd: Fix possible memory leak of 'domain'
Message-ID: <ZIdhR1Z0QNTEeFJL@nvidia.com>
References: <20230608021933.856045-1-suhui@nfschina.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230608021933.856045-1-suhui@nfschina.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Zg6zNioW8N5U1l5brxvv0svF/JkUdeOFo9c0wMQY+pMbvT/2Hky/xdATd7wV?=
 =?us-ascii?Q?Gf2ovf3Nt2HTmM0sTny3md/nb0JaBTVOmtO+2XXck7okL+shdyjyNpw6PbKL?=
 =?us-ascii?Q?RfC55EJ3YGrvvtAGPANP3aO6xrz1c6VyEByOZyfmZ+Q2yEC9zqA1S+QygCyT?=
 =?us-ascii?Q?4qVjOxtjBNhOHz+vOy5yXTnqsAo7JYn3g2k7IY0oUV8wUEdxSPz7TKA+OHFG?=
 =?us-ascii?Q?ptt3wk1cVMKtOcswDu37bJNBhDBIgEM9QgbgELIqpbB8ikoT1AelkNm7DJVx?=
 =?us-ascii?Q?Ri/Gehf2y3zDLylFH2ElDlTBu7E982HaMTzorpCMZdaVqwWQeGMn3FhSqORZ?=
 =?us-ascii?Q?0KdS2bFOpr2CoQs+bWNSTGY4+6F3P2H0N0KJ8e3oTTQYO8jBBW/Z9huy3o/s?=
 =?us-ascii?Q?SDgSBgUpaiNLnQe6xsTiyDf3pRYKIpOdoZI6q8YQMfixhLx2mkJS4B0BgiMZ?=
 =?us-ascii?Q?/363xOIUmHtBu3AlGr2DUo3+2qLNlhJsP+axHaKmHakoBZEDxHoP/U5QfGRO?=
 =?us-ascii?Q?uzJ2FIY7jxW5f/ecRX9+hzHQuk0ngDx11R0PKFJaGR4lr2v8D1Q6YM2qNPIg?=
 =?us-ascii?Q?RjiYb6o2ANPCvdBptQmv4UYJgJt1OWGa4oLqyRFjKXkenKE9x62Vq1fYdOIM?=
 =?us-ascii?Q?z0JthDlVwbT2uyvMYJZLFHEtmMMePUPOYNaSr86yPMeC2x47hxgfF+KLfzuv?=
 =?us-ascii?Q?4L99ZGeJFosg7aUXZNnYvP0u45DzPcrxUhk8JW0tHgVD+TgmV9FwsE1TW7JJ?=
 =?us-ascii?Q?N1TeqQhuwvw/gy6K/yOL/EwsT3gWfj/UH3P/+0uqInVkDCnMZa7p2Mxs6foC?=
 =?us-ascii?Q?YmSZDRVze3TBFLauPmletMLIy1XgQ7GEAk/i1W0eqxJG2PyWa1zz0gwdsDit?=
 =?us-ascii?Q?/Wc5BX5DjJ+QLlB8izQDijJAsVjqgyCpM93AW4ZaJXpiJIl8J+6bmVr0ZaVx?=
 =?us-ascii?Q?tzUSMbFWbMapxDIMF1bmhqSKLHc309L/FjSlB24M8AMbN/H3Jv4CaXPPVjUY?=
 =?us-ascii?Q?Ccn5eS8hYfDAticeo4TBFzi4q9FpN2XN5h36W7SULoAYWEoupT8MV90FSaDY?=
 =?us-ascii?Q?Onvr7X/0ntvoOVMEkjyE5N6myd/2KokRuU2dhXynI8khHsQtjKH4PlJB2II/?=
 =?us-ascii?Q?QxLCdm7K0YySaDqLnR9P1Givcocrli2RnrvXbATmYvucHYsbL7TfbnC73pZ3?=
 =?us-ascii?Q?0HNs/KRcHlefljQyHBK7kym7enp6FZx10Pbyr5XKQCG5UEN9TCPZijIfAMhi?=
 =?us-ascii?Q?RbhAnFq8d+/4iVOOxCCTYvJB6PUFFG0n8pdSscvZG3NMYv+l4EmotVyka/Qh?=
 =?us-ascii?Q?uEeN1rVxG4EJJSByUH9LJ3XNT5kaQzaigNWkwOXv0V5RSjFQ3YnUqRrl7ioA?=
 =?us-ascii?Q?UUfzW893R6nAui5WCR/2cz3d7HDqYei09Rl0vIZb/HXsz5NRnmyQT+DqDtv9?=
 =?us-ascii?Q?FEYxXnn9oTzyqDyTYH9YEeiFu4Gr5JIHg19sNXGzLclc1/lUVHheOMBKlUKD?=
 =?us-ascii?Q?EpqrS6gFR4HJl5DniB2X5v1g3SPY/Vvy8sjVNFIajNGAN+HmPOaysCSi+1ML?=
 =?us-ascii?Q?2K7jt3zwzbscKSZVBvT2azoFH94wa3bxO0GJE4Sr?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f034a3a-38e8-4881-776b-08db6b715159
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 18:17:44.5016
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lH22pg5frCHSB77g9WTfjeHl6WB2VZN+WHL1Jl7cBQyRRprL8h7qpzxT9VAO9bcT
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9153
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 08, 2023 at 10:19:34AM +0800, Su Hui wrote:
> Move allocation code down to avoid memory leak.
> 
> Fixes: 29f54745f245 ("iommu/amd: Add missing domain type checks")
> Signed-off-by: Su Hui <suhui@nfschina.com>
> ---
> Changes in v2:
> 	change code order is better and more consistent with other
> drivers. 
>  drivers/iommu/amd/iommu.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Thanks,
Jason