Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Jun 2023 14:53:23 -0400
From:   Frank Li <Frank.li@nxp.com>
To:     Alexander Stein <alexander.stein@ew.tq-group.com>
Cc:     imx@lists.linux.dev, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>,
        coresight@lists.linaro.org
Subject: Re: [PATCH 1/1] arm64: dts: imx8mp: Add coresight trace components
Message-ID: <ZIdpo8UOg+d61xP6@lizhi-Precision-Tower-5810>
References: <20230505195151.1874071-1-Frank.Li@nxp.com>
 <2229161.iZASKD2KPV@steina-w>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2229161.iZASKD2KPV@steina-w>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?f4AoKl9y7nKE1lnz5k1I/59H8NbkkZ+XLN2j0y9eHpWmxLt3t2WglL69pFtY?=
 =?us-ascii?Q?HHpsbEM1FO4m9uw7bAOJsOhpRQh67sxJqeoPhc3cBSfnEDYI//kLu3XpEP40?=
 =?us-ascii?Q?o94CyBq0o8dlEpKuIBMBgq2fesw/GD3wRYMy8b+zk+UR3d8OXYe1cqMsjmfS?=
 =?us-ascii?Q?vep/DYB5Z/AY7sP47rtBqVY1O+SdfH0nx3mBEQ+TergDGecTDOEY//xu7vnB?=
 =?us-ascii?Q?nUrJ9EAQoAbRjaKJUp+OiR+LnpNb6GrwrwZ6Rz0cNFY1OCxImZyzaolYRwqs?=
 =?us-ascii?Q?9TmC6l4Eq2up7Z7VuVx9dogGXg9eA74SDJzSQap0d+qxqWI/Nv3wm673glOY?=
 =?us-ascii?Q?hXOHapTfvDN6dQI9QxgbzKMUcSCKYYYB6kk521oi3j8+mW8udqFrE176dsWJ?=
 =?us-ascii?Q?LO/HaNK/cpm593kVQQ7W1YmwElleM4GnY2k9Z6b80kEFODd5W1OFPyL2ryjR?=
 =?us-ascii?Q?eqG4eIBFQ4/h33Hr2/SOma05/l8Im6nvqTdLBYMZdiRP06C+M8P2nZRtaN8O?=
 =?us-ascii?Q?9NKqqux4/BtrhVMFgvfCAD9u0RW95CzOpePXhoKPZQ7S0Jhr57vGruJcgV9r?=
 =?us-ascii?Q?en3zhsGRh6zbbpfDlHbiHeOjMY/uD07HDqVqW2BZz96enfnf0GR/GyPRZ27f?=
 =?us-ascii?Q?pPTrPyf4HsOlWyIr8BhnGBeCXyQSqt/17MvVA5WlsvFNOvelVpfRe3nhNPXy?=
 =?us-ascii?Q?51kAAK6hkpnZ9OHv/92Al9BlJ8tGLbwZ7dMUokx90p0nqj9OPUEvpAyglMLk?=
 =?us-ascii?Q?H6gY7/dqjObNb7iHKEMDM3TC6+j4smo/4yIp5vCTOXy5MPLLl3BCHXUp+Xg3?=
 =?us-ascii?Q?r6+ToSqHX1tC7SPB1bjZ5CZdcAWijozuA1SNFIPI+DwXvdY+HekNpT/t7xMx?=
 =?us-ascii?Q?NfKVFUsMGfcOlxV7DfNvVmtVYVjJmd7QrCMx1MNPzpvCYOHk840pa2Rs6gjf?=
 =?us-ascii?Q?w0S66cqymkcirOgDEkwmoVxN71g9dAfeyQ+FhetKedJeGq+QnX9V+I0xfS20?=
 =?us-ascii?Q?9a/oFpyluGWAmap219sfx2RwFysuyzOp7bjvS+pN+USJI15zuONvLq23ceE+?=
 =?us-ascii?Q?1YaMVRCSNDGyVwzDGjaS1yovGTPDHPIRFMBEo0zlRGvJ4fDPNXxNRXQopD3b?=
 =?us-ascii?Q?EWCbwdqL5i1r8SRYxkvPKj6KkZ2xB+SVy9QukEoxjBjE6eosJx5lhukTkN3E?=
 =?us-ascii?Q?67VcsbK+vQyt6KHFG5pTJ4Nj4m4Kh0Kmirx2M4pI8sgOEOvwxR0qVqAWDokL?=
 =?us-ascii?Q?O5LkVeEgSScq84TqOh5DE7IS3pFb28VqBBWEJXkSRhah8nPqzQES4p7JGgdb?=
 =?us-ascii?Q?/912z3qBVoVwDBBoRUMbAaz6iAJ7PCcD6VxjcMdBRSfc/X6pa2AaOy7yXcwZ?=
 =?us-ascii?Q?JxxjgFkkxz4EbeKStDQX1R3ofyQUazWgnXbb2UpM6/cJn3Bhi038CKazMaq1?=
 =?us-ascii?Q?TvOCe8dCHJsrNbAE+LYyDEMaFVUCqLBpz0ixZpzFdC0s+p6atiAb2zGwAGpw?=
 =?us-ascii?Q?DF9XTG2QRtUegFiWGa9w2TlEH+xrYptZS1ERSyPtfiKGCkCQCOkJZ3Lvan+r?=
 =?us-ascii?Q?lWZB5nS+c3rQQDhCfaFQyp7Ta8T79vAHqsf1GlB4?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f72b102-0898-45c6-5470-08db6b765456
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 18:53:37.0738
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /9MNO54ydq1VA057tfrdXFAlBmaMbAN9KaM0lJKzCpv+Zr/Fh/DEqEkJanxxqnixGLA9CJZZKqEtuogDEh45PA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8408
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 09, 2023 at 10:20:16AM +0200, Alexander Stein wrote:
> > +			};
> > +		};
> > +
> > +		etf@28c04000 {
> 
> The reference manual states "CXTMC_ETB" for this address. I don't have much 
> knowledge about coresight, but ETB is not the same as ETF, right? Which one is 
> correct?
> 
> Best regards,
> Alexander
> 

coresight tmc driver can auto detect etb and etf according to register value.

Frank


> > +			compatible = "arm,coresight-tmc", 
> "arm,primecell";
> > +			reg = <0x28c04000 0x1000>;
> > +			clocks = <&clk IMX8MP_CLK_MAIN_AXI>;
> > +			clock-names = "apb_pclk";
> > +			in-ports {
> > +				port {
> > +					etf_in_port: endpoint {
> > +						remote-endpoint =