Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Jun 2023 20:06:19 +0100
From:   Mark Brown <broonie@kernel.org>
To:     YingKun Meng <mengyingkun@loongson.cn>
Cc:     lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
        alsa-devel@alsa-project.org, loongarch@lists.linux.dev,
        loongson-kernel@lists.loongnix.cn
Subject: Re: [ PATCH v2 2/3] ASoC: loongson: Add Loongson ASoC Sound Card
 Support
Message-ID: <1568e064-606e-4f56-951f-429a87a3a2d9@sirena.org.uk>
References: <20230612090046.3039532-1-mengyingkun@loongson.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="JmH6MnoyxZ+mPA1w"
Content-Disposition: inline
In-Reply-To: <20230612090046.3039532-1-mengyingkun@loongson.cn>
Precedence: bulk


--JmH6MnoyxZ+mPA1w
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jun 12, 2023 at 05:00:46PM +0800, YingKun Meng wrote:

> +	if (ls_card->mclk_fs) {
> +		mclk = ls_card->mclk_fs * params_rate(params);
> +		ret = snd_soc_dai_set_sysclk(cpu_dai, 0, mclk,
> +					     SND_SOC_CLOCK_OUT);
> +		if (ret < 0) {
> +			dev_err(codec_dai->dev, "cpu_dai clock not set\n");
> +			return ret;
> +		}

Does this need to be in the machine driver - this isn't configuring an
external clock, it's just within the SoC, so presumably the driver for
the SoC DAI can just set itself up.

--JmH6MnoyxZ+mPA1w
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEyBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSHbKoACgkQJNaLcl1U
h9DjFQf3dlnL5S14TJo0QE32BmeVlgoqhFL9wxd3gu8bQCVhB6nAC9Bf3q/HRd5T
fvkq/Qtuv1n4VCXt28d1SboHdkcwwbyeNFvR2UE+c9yVumPy5VHXHNfsdRCJlDn0
dkrA+p2IG6SrGIKeyhTv4na9U5psScEjaTMqfTyk0DmlQO1IPRhpEi9/TI8VvRE4
DR9zoE5bPwbnMw68HEOS1GJQaHvdfDVWV4lKAvB4SpUqdHmpe871o33+2dfsHi9w
XCcqPyi/b3NwpA2/7r58meKwtroWgNVK3UXBrzQMwHFM1cEItj7b7WEIctIZrFxl
Le5GHVG0fRO4igXwrRUArFACZFhI
=PFnV
-----END PGP SIGNATURE-----

--JmH6MnoyxZ+mPA1w--