Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Jun 2023 12:03:18 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
        Shuah Khan <shuah@kernel.org>, Jonathan Corbet <corbet@lwn.net>
CC:     "H . Peter Anvin" <hpa@zytor.com>,
        Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Tony Luck <tony.luck@intel.com>,
        "Wander Lairson Costa" <wander@redhat.com>,
        Erdem Aktas <erdemaktas@google.com>,
        Dionna Amalie Glaze <dionnaglaze@google.com>,
        Chong Cai <chongc@google.com>, Qinkun Bao <qinkun@apache.org>,
        Guorui Yu <GuoRui.Yu@linux.alibaba.com>,
        "Du Fan" <fan.du@intel.com>, <linux-kernel@vger.kernel.org>,
        <linux-kselftest@vger.kernel.org>, <linux-doc@vger.kernel.org>,
        <dhowells@redhat.com>, <brijesh.singh@amd.com>,
        <atishp@rivosinc.com>
Subject: RE: [PATCH v3 3/3] selftests/tdx: Test GetQuote TDX attestation
 feature
Message-ID: <64876bf6c30e2_1433ac29415@dwillia2-xfh.jf.intel.com.notmuch>
References: <cover.1684048511.git.sathyanarayanan.kuppuswamy@linux.intel.com>
 <972e1d5c5ec53e2757fb17a586558c5385e987dd.1684048511.git.sathyanarayanan.kuppuswamy@linux.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <972e1d5c5ec53e2757fb17a586558c5385e987dd.1684048511.git.sathyanarayanan.kuppuswamy@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HdK4XvzzGpS6MBdlNBbBU4nI0Jcos1dzVEzfEpjiPXJhVuYOd2bUZrdwfiDu?=
 =?us-ascii?Q?lzdTcQuOwOaHoBF5kyn62peS0gxvb+3AKfXj2AusifwoW1J4KHdoIQDoWdTv?=
 =?us-ascii?Q?cDf6b3IZk1DiUh1IoC2lD4PBJXvFIFajNS2jTL7r6rOdTRklRfg1KHDjkw0G?=
 =?us-ascii?Q?vsZg2wgKsCowjQP3wtN7RqvUyiady8AEcubq85O7I4eCo4rAYvH7p3eThKTw?=
 =?us-ascii?Q?Tu+FguU3Qh58smzLo6E2FAqpxAbrkQ0W1P/IVAYMy0bdEhK2a4kiknYRiFuj?=
 =?us-ascii?Q?Jx5ZEyq0xPUYxo9B1ZUOaiko6za5bL1Pi+Hdvv8XpO/ogJSCqpE6mV2dsl4z?=
 =?us-ascii?Q?092G01FXBYan0JZHebQGcU9dfViwBnD/zf7Evm8rToQGRdtL0fwfxzWxXu5G?=
 =?us-ascii?Q?wity90cWcErkDIEmuoU11tJxNSxNT1NZ6XOQq1R358lY+G9Ua8uAfpnuLknG?=
 =?us-ascii?Q?sdvGn6cBCh/+j2mAs9ui97FoRh+nC9HpI1mrKj0XNTRsSWnaWxJ08UvyTpQs?=
 =?us-ascii?Q?FIu3LNRI43oYxHvWvPdkQveE3LlWNeob3ID3SuaKKqCACMu1y6umE52SlJst?=
 =?us-ascii?Q?HwuF+0cHcIz29a9+9xpeoFCYW9dKQGaUBvKfp/R4oGpXUcF8HSg9G+ZIl0nW?=
 =?us-ascii?Q?OV3wSjZ9TcRhdQJWsW9dwoxJ1xHsCMryB8qourcIo+2gwhkX5Hep7qWc0e03?=
 =?us-ascii?Q?BgE6YkkvkQbo17uaNHCshwudENtSiwb+aWw6C0iUUtJllUjjWzHtIg916LSK?=
 =?us-ascii?Q?aLvrrtXLp1QzFgMvEj4DDXkQah9hG1qh2aBCglDq4pLn+MOuL06b+Q5SvUYt?=
 =?us-ascii?Q?b4bfsABujkysVnBLRpsIpJUJzpvKd00gBKbPHXTf8rrC+0Uxe/L6Np2gyOdy?=
 =?us-ascii?Q?VM9nZlg7ljemp04+fEz6Lsc7FKa+sFrLI91aX0YUIaQGq7V7Ye9jhDElzHs6?=
 =?us-ascii?Q?AL6aM9pgyYOEdDZ0IjVpbbnDO12gWTSp7ygE36sf87wjHpHcjfAkLoZlNGT+?=
 =?us-ascii?Q?4Csp7Hltb//cWJEqa3FHUmr87qFWTsSp/gVqTVIX7ZsrdtdcEboxK6MvBF76?=
 =?us-ascii?Q?SHIQF2KB+nRYwXYnuCh/zlSAasELOwcqEjG/a6KThKL4XYpYBSHZ4vlZDiZj?=
 =?us-ascii?Q?Wbngripw0qgM/LP2jWo2k82TfJT7ZNNNvF4GlCisPuwK0kUkHVHjNBhWhuEN?=
 =?us-ascii?Q?bZ7vtkmBHNHlvEQCj5rNia3LXaHgS7z4HCuQL0lxz4132IGoe0NB3EGWEVUD?=
 =?us-ascii?Q?eVyzxp2oE2W7xWrK5V1toNqznhLwobRnLZXHrPGYE5kxwhPWJl/WouRPqhZj?=
 =?us-ascii?Q?+8WZzYJIKT2/iBC6AKpgu4ICh7z6qz8T49ZZ1l1gkTVhf2VwJTTE6BIuJoUm?=
 =?us-ascii?Q?j8FEHuVtT3FGgXs5r1kfPO7LNwGufJ5orGS+zOjMDtg57BDzd9otdcCRyMY8?=
 =?us-ascii?Q?3nn/9HjsivY64zeXMoakNQFla+d5Qal4WEjUZ28Bbs48yWmc+oCU8Dl7qrg9?=
 =?us-ascii?Q?HqH1OlCJ3OY0yS7z7ZVB14qW/sF4p5IWrN7Awzmq9TUjwhPPZtnkdDF5MxyZ?=
 =?us-ascii?Q?wjq79ydFKOGvwuRK9Y73bdikDG2igx3A6qScJ/G+PEeKEkg6yOeYnv1OGdTj?=
 =?us-ascii?Q?7g=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a94278c-e999-4fd5-bfdb-08db6b77b111
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 19:03:22.2085
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hX83VqSc2ksN4kHbAo9ik6hqLpOJfT2W3N5UBgtvVyZcTCQT75d09V+737vm4PZRGKGc9es1i2ctUD7dGeMSY5xOzh+omIbeZpgQBOApifo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5607
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

[ add David, Brijesh, and Atish]

Kuppuswamy Sathyanarayanan wrote:
> In TDX guest, the second stage of the attestation process is Quote
> generation. This process is required to convert the locally generated
> TDREPORT into a remotely verifiable Quote. It involves sending the
> TDREPORT data to a Quoting Enclave (QE) which will verify the
> integrity of the TDREPORT and sign it with an attestation key.
> 
> Intel's TDX attestation driver exposes TDX_CMD_GET_QUOTE IOCTL to
> allow the user agent to get the TD Quote.
> 
> Add a kernel selftest module to verify the Quote generation feature.
> 
> TD Quote generation involves following steps:
> 
> * Get the TDREPORT data using TDX_CMD_GET_REPORT IOCTL.
> * Embed the TDREPORT data in quote buffer and request for quote
>   generation via TDX_CMD_GET_QUOTE IOCTL request.
> * Upon completion of the GetQuote request, check for non zero value
>   in the status field of Quote header to make sure the generated
>   quote is valid.

What this cover letter does not say is that this is adding another
instance of the similar pattern as SNP_GET_REPORT.

Linux is best served when multiple vendors trying to do similar
operations are brought together behind a common ABI. We see this in the
history of wrangling SCSI vendors behind common interfaces. Now multiple
confidential computing vendors trying to develop similar flows with
differentiated formats where that differentiation need not leak over the
ABI boundary.

My observation of SNP_GET_REPORT and TDX_CMD_GET_REPORT is that they are
both passing blobs across the user/kernel and platform/kernel boundary
for the purposes of unlocking other resources. To me that is a flow that
the Keys subsystem has infrastructure to handle. It has the concept of
upcalls and asynchronous population of blobs by handles and mechanisms
to protect and cache those communications. Linux / the Keys subsystem
could benefit from the enhancements it would need to cover these 2
cases. Specifically, the benefit that when ARM and RISC-V arrive with
similar communications with platform TSMs (Trusted Security Module) they
can build upon the same infrastructure.

David, am I reaching with that association? My strawman mapping of
TDX_CMD_GET_QUOTE to request_key() is something like:

request_key(coco_quote, "description", "<uuencoded tdreport>")

Where this is a common key_type for all vendors, but the description and
arguments have room for vendor differentiation when doing the upcall to
the platform TSM, but userspace never needs to contend with the
different vendor formats, that is all handled internally to the kernel.

At this point I am just looking for confirmation that the "every vendor
invent a new character device + ioctl" does not scale and a deeper
conversation is needed. Keys is a plausible solution to that ABI
proliferation problem.