Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp286896rwd; Mon, 12 Jun 2023 13:35:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ73ywccwzH8jdolvXAZU99Hiw7etI9MWxAgxAMcyH4j3B86NVeNdRNLKRAc5QEEZxxFUXma X-Received: by 2002:a05:6a00:3a28:b0:64d:b0d8:a396 with SMTP id fj40-20020a056a003a2800b0064db0d8a396mr12349862pfb.7.1686602120181; Mon, 12 Jun 2023 13:35:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686602120; cv=none; d=google.com; s=arc-20160816; b=KvQiGgCNydJHm6QiIf0KLD64srLmLFvD2mKBVn7sfcncYE6wyuafwcDpIOmODk9s9+ yzVXAyUstSmd+0UbWHKAhoQrXKEbSZwfemA7Vg80rP8hkUdIOeHO42BTrS1Ag7CvHqIK DHXeOZDu8fdlIl0sffbrMjuY2uh76wfazA7POXJD6urk7uoGqI82u1TV9X6c21JkUEAK mPytNHeWfhhah/YUNLfIskmcnMYZjuyVnQnQOL6rhSfxlMnGqyGDZq1Pa42f1KNeT7dN CmuSEdB6hGlIMQwHoaOLzXSG6x4SSgj3OJp6uF2pgJvUrm8HH4NGqT9fXs+q247lZffh O+mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=WHocG4UQ3ecO0uydSymSh8iIsvcAoTFn78fAzFQKDjI=; b=gnqHynbfvSa7TtYinqNiCV2RHUtuI8BLWALbJJ5OGre2gNW0TIaU2rU2xVKaMQ2sZZ WF+MV9r8kd3TH/ayEuemzAAr4eLs0JrcueASizI24hFaVNtJi50i+b92ByQBG21GhJLp wLHv2dS7Kf4IA36A77nhKGSfzrqjpkD3OF3cPlY7aqGqc0bgiESdikyKk8DhVaIzWUst h05/MxHXYWI5xAsvpT5sKZzK6f3zXjnfS0cQS85T6muX6a2snHYvYNA7puPqkijBiIrT 7VQDkSVFDpnk6YYea9fp1Dd3yBR3roRV6z8zam3OKvMQpybBjKSTOtg5kSH5q/2lFZgT kSOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@googlemail.com header.s=20221208 header.b=gn7OLV89; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s14-20020a63924e000000b00543fccec373si7526273pgn.266.2023.06.12.13.35.07; Mon, 12 Jun 2023 13:35:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@googlemail.com header.s=20221208 header.b=gn7OLV89; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233356AbjFLUTi (ORCPT + 99 others); Mon, 12 Jun 2023 16:19:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbjFLUTg (ORCPT ); Mon, 12 Jun 2023 16:19:36 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B95D5134; Mon, 12 Jun 2023 13:19:35 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5187351abfeso25649a12.3; Mon, 12 Jun 2023 13:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20221208; t=1686601174; x=1689193174; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WHocG4UQ3ecO0uydSymSh8iIsvcAoTFn78fAzFQKDjI=; b=gn7OLV895i9gRAkGix/1SL6oMaVp7CcSdGVgqiI7pCIuwI9xq7tDHl+Zsko2VJ0+ys ZrvOF/RUpQzlZLO+MrhB9B9u9fmNmDk7nEwHBhYXvU4b9LXw+3rhxf8yFrfRxVSaB5IG wu8f4L3cXfELhPUag82nphdxHQUGijHHBrDy5OW3C/GzT2AWXB7i9mccox28O6nVq/3B n1Buv53uYvq3KcsjJgaGa86LZgcEUQW5BuKtM+fFDyd6ieaNcX4bNVcTQO59e0/ZE9cd JTdU1UBI1pMk0YHyM8p5+mAuIP0xEGe9Nhc6TYDBd39DBiXs/9P5Fy5rTAfAQGjsG6JD bI7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686601174; x=1689193174; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WHocG4UQ3ecO0uydSymSh8iIsvcAoTFn78fAzFQKDjI=; b=aEccAidwkKgZrDtgU1oFrYhDwcSc4M8c5QCXyiCFfG3c25VwoKvNLaVrIJrZ/zmYRB FGXjE2pga50P0QnenQFOGKjhjNHxtLdA6X6qaaxWSxKf1lD3fnygbXiS+TerXZEUQIPx 0jPEKfjbRhhk6CfJI3EgNfkVSaaWYKzTYA5U6mAVCqRqKEoTSNFcUOlXtwUiimFQZZrU iV/k1gUdzApNthhhmgBBdSNjZ8UwYbWqSw1n8mGQ76YRuL6BizoXoJ91m6gVY4Oi7gVk 8ZtpVX5ycxbQh3+W6GcAttItjKZUF9P+C5YkiW0j+JqG38u1psFWCDAER9a2j8N3Gzg0 Oiqw== X-Gm-Message-State: AC+VfDwPNtWQvhdXf49v1qaPMuGZuITMtDD5W23Y4yt/ratnaCfbknCL biBRcxkhKJsXYFz9LnUR+xI18qR1XUOHMnfo1ENNtfVH0Ro= X-Received: by 2002:a17:907:3da0:b0:982:2278:bcef with SMTP id he32-20020a1709073da000b009822278bcefmr2406503ejc.60.1686601173890; Mon, 12 Jun 2023 13:19:33 -0700 (PDT) MIME-Version: 1.0 References: <20230612182332.371003-1-sboyd@kernel.org> In-Reply-To: <20230612182332.371003-1-sboyd@kernel.org> From: Martin Blumenstingl Date: Mon, 12 Jun 2023 22:19:22 +0200 Message-ID: Subject: Re: [PATCH] clk: meson: a1: Staticize rtc clk To: Stephen Boyd Cc: Michael Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, patches@lists.linux.dev, Jian Hu , Dmitry Rokosov , Jerome Brunet Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 12, 2023 at 8:23=E2=80=AFPM Stephen Boyd wro= te: > > Sparse rightly complains that this symbol is supposed to be static. > > Cc: Jian Hu > Cc: Dmitry Rokosov > Cc: Martin Blumenstingl > Cc: Jerome Brunet > Fixes: 84af914404db ("clk: meson: a1: add Amlogic A1 Peripherals clock co= ntroller driver") > Signed-off-by: Stephen Boyd Reviewed-by: Martin Blumenstingl Thanks for providing a fix so quickly! Jerome, I think it's easiest for Stephen to apply this patch directly to the clock tree. In my opinion there's no reason against this since our own patch queue is e= mpty. Best regards, Martin