Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: iac594737:Fastmail
Date:   Mon, 12 Jun 2023 16:25:01 -0400
From:   Demi Marie Obenour <demi@invisiblethingslab.com>
To:     Alexey Dobriyan <adobriyan@gmail.com>
Cc:     linux-kernel@vger.kernel.org,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Hans de Goede <hdegoede@redhat.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Juergen Gross <jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
        Lee Jones <lee@kernel.org>, Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Vincenzo Frascino <vincenzo.frascino@arm.com>,
        Petr Mladek <pmladek@suse.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v3 0/4] Make sscanf() stricter
Message-ID: <ZId/IA41c2sJyvE0@itl-email>
References: <6ab6adce-2318-4ae6-bde6-4317485639fd@p183>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="PjrwJQtKdb92ybe3"
Content-Disposition: inline
In-Reply-To: <6ab6adce-2318-4ae6-bde6-4317485639fd@p183>
Precedence: bulk


--PjrwJQtKdb92ybe3
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Mon, 12 Jun 2023 16:25:01 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Hans de Goede <hdegoede@redhat.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Lee Jones <lee@kernel.org>, Andy Lutomirski <luto@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	Petr Mladek <pmladek@suse.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v3 0/4] Make sscanf() stricter

On Mon, Jun 12, 2023 at 02:59:38PM +0300, Alexey Dobriyan wrote:
> > +	bool _placeholder;
> > +	return simple_strntoull(cp, INT_MAX, endp, base, &_placeholder);
>=20
> This can be done without introducing dummy variables:
>=20
> 	void f(bool *b)
> 	{
> 	}
>=20
> 	f((bool[1]){});

This is more consise, but (at least to me) significantly less readable.

> > > lib/vsprintf.c:3727:26: error: unknown conversion type character =E2=
=80=98!=E2=80=99 in format [-Werror=3Dformat=3D]
> > So NAK.
>=20
> Yeah, ! should go after format specifier like it does for %p.

I hadn't considered that.  Is the typical approach in Linux to use e.g.
%d%[!] if one wants a literal '!'?
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--PjrwJQtKdb92ybe3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmSHfyEACgkQsoi1X/+c
IsHM8BAArfYIa3ISJO/sXxxYMbF1z45VuZ+APs6Jy06/KZBRK9BfvdjOIYICgJLj
dDEWB1JaM9Z5wtu37GhiwkMBHueuQ1VUsHk2PFcdsqs0VeTBgcKYq7H/doMRwPhh
ihF9OP2Fcl1CnPBJv3WrZFfiRvm0iNjJdglt/Uqp1Qxbf0/x/QrtpqRPm3dzyQbA
ofRGw161bV/vu/PzcYNnjeMtUHZvz2skcC7OiFb1q/RYxowXz3w0xydLRXBL/YAf
12X+z6xCy6iZTHYT47h7WdQODjOUyscEeUyMYjqM2McveM6gnRGLbaKTYmKc4yMD
Gb/TwOyyGpm5BVyDYSxqxJBUvX3NATyEz6x4+uD6CS50c+mdXzhs7BjWGlqEzsg/
t2hHAfEQU4gef3y8aE6x34jFXJxl4YEHXwX97w+h0imIK0v02qwQkUD1GxWIWobo
4uPjxeEM3rH2aYnHW/Vpr7EfYW7GDYdz79EZGfxsZE0kXcSPfmUNb/jsMvO+Ezit
5am01alceJr8fYnWaD0ot999X9LX52PqizPbENVkVIKrd8ZAUcyxykQ7FZGI2loA
vBz58sEOK3GuPwl5C0p4Ll1pRvbU5lRBScxmu9i+ElELYb66xh1805XgBKw1uAZe
tg2qXZ2bdKM+/e4eDA2V4ceLzeHUGD2/AjVlsY+sOIPAyrxQWEw=
=K6Gh
-----END PGP SIGNATURE-----

--PjrwJQtKdb92ybe3--