Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Eric DeVolder <eric.devolder@oracle.com>
To:     linux-kernel@vger.kernel.org, david@redhat.com, osalvador@suse.de,
        corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, x86@kernel.org, bhe@redhat.com,
        ebiederm@xmission.com, kexec@lists.infradead.org
Cc:     hpa@zytor.com, gregkh@linuxfoundation.org, rafael@kernel.org,
        vgoyal@redhat.com, dyoung@redhat.com, lf32.dev@gmail.com,
        akpm@linux-foundation.org, naveen.n.rao@linux.vnet.ibm.com,
        zohar@linux.ibm.com, bhelgaas@google.com, vbabka@suse.cz,
        tiwai@suse.de, seanjc@google.com, linux@weissschuh.net,
        vschneid@redhat.com, linux-mm@kvack.org, linux-doc@vger.kernel.org,
        sourabhjain@linux.ibm.com, konrad.wilk@oracle.com,
        boris.ostrovsky@oracle.com, eric.devolder@oracle.com
Subject: [PATCH v23 8/8] x86/crash: optimize CPU changes
Date:   Mon, 12 Jun 2023 17:07:12 -0400
Message-Id: <20230612210712.683175-9-eric.devolder@oracle.com>
In-Reply-To: <20230612210712.683175-1-eric.devolder@oracle.com>
References: <20230612210712.683175-1-eric.devolder@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?H/GrEbwrvRIG1hpph9pkHYoLzpMWE/87wpHjeAC+ewkSrpyr924CxEfEi92l?=
 =?us-ascii?Q?SSVSJHnKkuGimfnYHbokWM8EtaLdxMIjyIKxJRN5OcT7AAJOkodI1of/cybM?=
 =?us-ascii?Q?sGzAg5zBAFDMxzYFvEeBwZEHNWOBzYMj1IcxGWE2tdwY4TpFpwFtBhP73bil?=
 =?us-ascii?Q?EIbDmtQbfebinXbzNWyD7rillY3CMGxmPm3PzIWk9CU/5K2Cq+BLvjT0yfaw?=
 =?us-ascii?Q?nEPxfHo64MzmuH6UWQlxRBt6xoxq1V4wTpUZ2E7EHDNrgiBfLP/3jLpRRnKP?=
 =?us-ascii?Q?BqXdweJVvQT0zd0XRS4Gv5IniRapH7BDYFBH/UTvaaE6aX5r5Fn1WCIdH/sf?=
 =?us-ascii?Q?bLgssZUjSbQH3829FWfi0r+h6zGOKvN5sLQeF4EmN9iOgJNVh1QcMuE2Os5G?=
 =?us-ascii?Q?gg4xDj7YjsIaRGoRNbxUjjNPmUHqZ/BUmM2kowHFrPOFvVZLYezfjGSdML6b?=
 =?us-ascii?Q?vnSjoK9DIGKkm+S3/gM5mQ2e8xwVQHBxCct3q4xeiTBl4iFynr4MqlYTc+UO?=
 =?us-ascii?Q?EokIvH45A5xU7sHzBsPYwcyPh61opyPZ4M06zcr8rxucQJg34/2Uv3DyOGFw?=
 =?us-ascii?Q?WVTmxu6kE9xyhv2B45h6faSZ8q/VrqZjM0QasUKU59pztbiP21aUvlxF3pnY?=
 =?us-ascii?Q?KiabVF8BqjZEWs7Ar80ZQdZspdVxzNCD2gbNLQU+1+mQXx7UW+FhLTBaxKWy?=
 =?us-ascii?Q?36HGdsiRYlzYEB7I/92F0xUeblJpjfWbZyPmmcxMI2Ww00JKowZbAMDzNdSl?=
 =?us-ascii?Q?qZs+71MBea5TxL4gPRiQtODt2MP1PRj9sSTAxPb4volK/u9WCGnkVTuuJRHB?=
 =?us-ascii?Q?w9ES/fmesd5+8qY1TTImkpFgrQ7ikIfCil6bPBlN56vWibu+OrzyrB7jW+m3?=
 =?us-ascii?Q?D1ASk5wEWqYm1W76btqehEBbq4eyXCJ8g1Y75MyelzMzr0JvpX6qszTa6/P6?=
 =?us-ascii?Q?Pfp7RK2MQGbmAGrV3nveRs/uozlxoU6B2ccW3v2Hu4JlbbPYb2MCCvzciLK7?=
 =?us-ascii?Q?Ur+yTGWZt0sLe+xD1pCSWI53w0YchV4V7P0ChOu+mdnNjBRzV75QUkmu2cUD?=
 =?us-ascii?Q?e7NhpX3vyd4HsgY1hDu8Y25CMhC2SZSG6SOe98s5V0FeQBALbKOxL6wGW0Xq?=
 =?us-ascii?Q?53pSALZ9gdCuB4WoDZxlyJizCLg2qBTHScAR9kl20lihbGT8dFyr3W9zn3xc?=
 =?us-ascii?Q?7xVK4f2+SZnS3rBU3N7/i+XImYSwzUU5QKb4szrxAkupM8asFYxzpsN+owc8?=
 =?us-ascii?Q?rH0KH1fkjNghLp1Lz+A3LKw+E/JftrKxx8rVjWPcc4uJc1uJj71u8KVJFJF6?=
 =?us-ascii?Q?G5glUl69umtrbiGpmIhTdAnANNypPkOuCYcmvTgAZmasaMrW3b4u6A453VQD?=
 =?us-ascii?Q?j0QMrNTUn4qQ3Nw7VBGnRW1M4s/OUQ/YoQSM5dvv+gWiWgNgXggSg1R+mGin?=
 =?us-ascii?Q?1Q8TQ37GfKIc69zaHa8e4DrFZXdBqkGjmJswpmljo86tTdwXpmwxcMoDgGLL?=
 =?us-ascii?Q?GijwsTT4Vc0H9/l8qC2AzwLo6y6viwsuz6205fXfKkxsvBk1KkvLKoq8BbpP?=
 =?us-ascii?Q?vpgmMU0G+t2AxpgnQ+kYNCufCsyMh8fZAdhcqFAqVPkHEB3SI64acqvNokY7?=
 =?us-ascii?Q?Nw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?MZpOJzC8vD8zCb0B3f7kg6I2nH4yFjUBtQnz+kWhQY9MeQXKZsIGlA1M/9+H?=
 =?us-ascii?Q?9lVsxlAUtRV+UX3m5Gy21loNcXFgLY6Wn1Jm4Zz2xz7qqs5IMVJlPxLrvDKo?=
 =?us-ascii?Q?3jC3dZ79Xquzlt75VbFB4TLp9AVPIXrRAyP1hmU56ox4sJ3nUaaBybizTLae?=
 =?us-ascii?Q?0XYH5gi1fhkyMIce48M0yTG1wEcM+JRUHqhL30pJ4xQCCjCkpAdx9zofVsW5?=
 =?us-ascii?Q?CzWf6odpLesMJq4rY6c9R9Kp20FDce31g/X0ItR8ZXJhCCqbtg0jfuQjcIs6?=
 =?us-ascii?Q?2yLMRY0Wczx80i+M92f3xX4Y8a70oMVobt8X687lRPt1l3UVEcNP4M4s5VB8?=
 =?us-ascii?Q?MufJov/IVDAwc64JCfpfSDFxKyWGkemMbtFxPVAVbsUEhEhOAPKpksFlBTz0?=
 =?us-ascii?Q?1szi67PMzy2eAiHCumdZF4y5/gQnsFYMyfJYgQnvlRu1SXxxGkSy1LTYwn30?=
 =?us-ascii?Q?kfRewKgIjGPm1O83G4DdXBZWxmqwD4UhgQodeHVH4V5T9Fohgd0tkBgFVxZy?=
 =?us-ascii?Q?UfyVHiWLfeI91bCCgYI3yISNT/6DAMLujYvtzpKTy2HyV/HyFcOb83ewHA7t?=
 =?us-ascii?Q?gJjPIOLlcSEA/A799g0QWEJz76R8DSxncEAg6XbeyJh2UlJ/fm2xbtSoVrbn?=
 =?us-ascii?Q?K1FeE8GTop1nJ6tWvskYItoCK1ZjTSMu9WpZ9Jc7amuhzK4m97b/pki9GnuL?=
 =?us-ascii?Q?BxVoxcZL1fPpKq6s6SMwErvN85W94xlhYADVxeOsAv09oPc2vyST4VRt21pV?=
 =?us-ascii?Q?rOJYgvfJ1cVeB23kDQaFqnn1h3IChomfwMLCJmEVpWH38h83SpYv7/Ln8ale?=
 =?us-ascii?Q?eUqywtkTg7gVPqGygLeirGzCK5ychQ6GRScPuBAglQD1VHfksunugo07Vvlh?=
 =?us-ascii?Q?+QzGQfNZtzFwAig8JcyOV82C1bsj03So3o1sbxpUl5hVFwQ5gr334ghVdNvn?=
 =?us-ascii?Q?MAPt1BDPQO+BLVFn6hNVec5qKLXfPcytOeMrRttLFTJlaS0Nl0T8PuCnbL9u?=
 =?us-ascii?Q?BpJzo/6pKvog5581xfddkkw3xZ468j6rLSZLjPSGIFkjXopWG3cKF5Ya/tyq?=
 =?us-ascii?Q?z1zdTxeWx77Phjh+jiqzAS/uk3+W3/4CU+W3Zphqg8C6b6Tag1+0UsHTTqnp?=
 =?us-ascii?Q?eLqo20W3WChu+ce2l329gqImmRhAYUsIJFAy0V9Rwp4+auJQnKQyN5qFbq6o?=
 =?us-ascii?Q?TviAKrD1IAXDrsSykjYLsGWzXTz0+HH3n/6q/iqZFxPyYOkDGA2H+9PANJPs?=
 =?us-ascii?Q?pWoQcD7oQruHatBqp87s+rkdCMg+f5dtVfZlG+fwSJ6ccj+1TvwiGB5gd43h?=
 =?us-ascii?Q?62TCEaTXY9YnQGv6tvRdn9+i4zMQTLASHhEyT9b05jMxbOIjvOwOtuEa6bEm?=
 =?us-ascii?Q?S4HuFup7rQyVsn+PdV6mgPkT3l65Lavr0bnJQIoKfoHASzq3rRFAYqHSn1LR?=
 =?us-ascii?Q?0e+gODy8uOU=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: edfb1e0c-0efa-4531-541e-08db6b8915ef
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 21:07:52.7321
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2kERe+G3banCgkzlGp8aNdX8NZD+Lv74Vtm2oubtsL1Yd01htrwKmPgXSGYZzJ7pLXVEwks7MqNYBbWWO3NoZZwvwVB1TJuvamAtON/5WQ8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6410
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-06-12_16,2023-06-12_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 malwarescore=0 mlxscore=0 adultscore=0 bulkscore=0 spamscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2305260000 definitions=main-2306120180
X-Proofpoint-GUID: ZsF877mBckACUNC3VPrdpzLiNXxHTu7P
X-Proofpoint-ORIG-GUID: ZsF877mBckACUNC3VPrdpzLiNXxHTu7P
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

crash_prepare_elf64_headers() writes into the elfcorehdr an ELF
PT_NOTE for all possible CPUs. As such, subsequent changes to CPUs
(ie. hot un/plug, online/offline) do not need to rewrite the elfcorehdr.

The kimage->file_mode term covers kdump images loaded via the
kexec_file_load() syscall. Since crash_prepare_elf64_headers()
wrote the initial elfcorehdr, no update to the elfcorehdr is
needed for CPU changes.

The kimage->elfcorehdr_updated term covers kdump images loaded via
the kexec_load() syscall. At least one memory or CPU change must occur
to cause crash_prepare_elf64_headers() to rewrite the elfcorehdr.
Afterwards, no update to the elfcorehdr is needed for CPU changes.

This code is intentionally *NOT* hoisted into
crash_handle_hotplug_event() as it would prevent the arch-specific
handler from running for CPU changes. This would break PPC, for
example, which needs to update other information besides the
elfcorehdr, on CPU changes.

Signed-off-by: Eric DeVolder <eric.devolder@oracle.com>
Reviewed-by: Sourabh Jain <sourabhjain@linux.ibm.com>
Acked-by: Hari Bathini <hbathini@linux.ibm.com>
Acked-by: Baoquan He <bhe@redhat.com>
---
 arch/x86/kernel/crash.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
index caf22bcb61af..18d2a18d1073 100644
--- a/arch/x86/kernel/crash.c
+++ b/arch/x86/kernel/crash.c
@@ -467,6 +467,16 @@ void arch_crash_handle_hotplug_event(struct kimage *image)
 	unsigned long mem, memsz;
 	unsigned long elfsz = 0;
 
+	/*
+	 * As crash_prepare_elf64_headers() has already described all
+	 * possible CPUs, there is no need to update the elfcorehdr
+	 * for additional CPU changes.
+	 */
+	if ((image->file_mode || image->elfcorehdr_updated) &&
+		((image->hp_action == KEXEC_CRASH_HP_ADD_CPU) ||
+		(image->hp_action == KEXEC_CRASH_HP_REMOVE_CPU)))
+		return;
+
 	/*
 	 * Create the new elfcorehdr reflecting the changes to CPU and/or
 	 * memory resources.
-- 
2.31.1