Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: iac594737:Fastmail
Date:   Mon, 12 Jun 2023 17:23:18 -0400
From:   Demi Marie Obenour <demi@invisiblethingslab.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Alexey Dobriyan <adobriyan@gmail.com>,
        linux-kernel@vger.kernel.org,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Hans de Goede <hdegoede@redhat.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Juergen Gross <jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
        Lee Jones <lee@kernel.org>, Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Vincenzo Frascino <vincenzo.frascino@arm.com>,
        Petr Mladek <pmladek@suse.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: Re: [PATCH v3 0/4] Make sscanf() stricter
Message-ID: <ZIeMyQXU49OcoxY2@itl-email>
References: <6ab6adce-2318-4ae6-bde6-4317485639fd@p183>
 <ZId/IA41c2sJyvE0@itl-email>
 <ZIeHfBf3aB3vUgRM@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="1qNhvq2VHyxB7HMQ"
Content-Disposition: inline
In-Reply-To: <ZIeHfBf3aB3vUgRM@smile.fi.intel.com>
Precedence: bulk


--1qNhvq2VHyxB7HMQ
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Mon, 12 Jun 2023 17:23:18 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>, linux-kernel@vger.kernel.org,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Hans de Goede <hdegoede@redhat.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Lee Jones <lee@kernel.org>, Andy Lutomirski <luto@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	Petr Mladek <pmladek@suse.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: Re: [PATCH v3 0/4] Make sscanf() stricter

On Tue, Jun 13, 2023 at 12:00:44AM +0300, Andy Shevchenko wrote:
> On Mon, Jun 12, 2023 at 04:25:01PM -0400, Demi Marie Obenour wrote:
> > On Mon, Jun 12, 2023 at 02:59:38PM +0300, Alexey Dobriyan wrote:
> > > > +	bool _placeholder;
> > > > +	return simple_strntoull(cp, INT_MAX, endp, base, &_placeholder);
> > >=20
> > > This can be done without introducing dummy variables:
> > >=20
> > > 	void f(bool *b)
> > > 	{
> > > 	}
> > >=20
> > > 	f((bool[1]){});
> >=20
> > This is more consise, but (at least to me) significantly less readable.
> >=20
> > > > > lib/vsprintf.c:3727:26: error: unknown conversion type character =
=E2=80=98!=E2=80=99 in format [-Werror=3Dformat=3D]
> > > > So NAK.
> > >=20
> > > Yeah, ! should go after format specifier like it does for %p.
> >=20
> > I hadn't considered that.  Is the typical approach in Linux to use e.g.
> > %d%[!] if one wants a literal '!'?
>=20
> It might be that the cleanest way we have is to create %p-like extensions=
 to
> sscanf(). %p takes alnum as parameter and that is usually works since it =
makes
> a little sense to attach alnum suffix to the pointer.
>=20
> (I don't like to have %dX, where X is alnum as we expanding our hack to
>  something which people don't expect to be altered even in the kernelm, y=
ou may
>  refer to the discussion about %de for printing errors)

Personally I=E2=80=99m not too worried about compatibility with userspace
sscanf(), except to the extent that -Werror=3Dformat can keep working.
Userspace sscanf() is almost useless: it has undefined behavior on
integer overflow and swallows spaces that should usually be rejected.
I typically either use strto*l() or (as I am currently doing for Xen=E2=80=
=99s
toolstack) just write my own parsing functions from scratch.
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--1qNhvq2VHyxB7HMQ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmSHjMoACgkQsoi1X/+c
IsFFLg/+IexZNCutgAvzB9QpLaKvrRK1RyCLLOexeqRIrLpsZxC5ph43KrBFdEye
ORcumc8hllJ6geaozUFYZWZi1bEq2pELnftswyZzwzHq2JXrRoDfJDwidQd9fSui
8OThDF5rcDips9C3kaD1LjTkFkeNDqz68bh4ns78PWIZVt6m4Vct9FV1Qj1cPD1b
Er7B7eb9OY+mT9+/k02JNejJ56zw8VxB0+UKeFpdnl5aZHRS75lkEPaQe7y0F+bB
WbAjCzlac8sDrMJYi5GwumwarFDQRIPKgLff0VE/qeQl+c9l6jFHzBwH6TnYSd33
evxkYU+PID/GlsXTVSuSBbRdXRZ8TACoN78xjK5dk9PWKfZ56oTNLNVs8gSw47Ci
MSIVZoGD5Nm7tEPY+5BSQSwHE4NmWVcK8kfbI0xfc3Kkg8mfiWmO5chg44+EZD9y
ui+SaDuras2bVsLiie4y/nvznEmLd8sGW2MmZErtTJUZlMpaZ8zxmWPO041UceQc
hCYmOTu5W9GQaRW/mkEAxFXDKWXHuNiRezAKNGQLLP7UZAxpOWiIYsnMQTbdMwjC
Xa1k75R1qKbXqmFOULaT2ng5+vI1KUQe1XRjLbr9UDD10x8HnjCSDOBcuqJVX4mK
etxenamwRW1++pcZDGPJh26vWrBn3Vkxd0doGvHdUM96A4pz6cQ=
=KpGC
-----END PGP SIGNATURE-----

--1qNhvq2VHyxB7HMQ--