Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Jun 2023 14:44:32 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Peter Xu <peterx@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Muchun Song <songmuchun@bytedance.com>,
        Naoya Horiguchi <naoya.horiguchi@nec.com>
Subject: Re: [PATCH] mm/hugetlb: Fix pgtable lock on pmd sharing
Message-ID: <20230612214432.GE3704@monkey>
References: <20230612160420.809818-1-peterx@redhat.com>
 <20230612204418.GD3704@monkey>
 <ZIePspc+wgNeR0/H@x1n>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZIePspc+wgNeR0/H@x1n>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?B0HMgwF0tz6WbB7qIvFRObJHee314e5tRy9jrLjCPr6PFDUeArrBSdlDjkso?=
 =?us-ascii?Q?HW4BKr9B6HIjN99cwl/SSj+9/mV12oLsr5pSgZS2XiVckmgAilRVlVBJOCvY?=
 =?us-ascii?Q?guAu5o832nSwmPm5sYZrnJ7UvPMQc7uhlHIBXVZeWrtl/+0n8CPdTEdb1gQG?=
 =?us-ascii?Q?KajadklwtwGQjgdfOO7xNDPHSZWgEXcyGLkOvJgrfvAsSKdEzOqnU5C+IbBD?=
 =?us-ascii?Q?i3HmTQQN72DgLMxZ9cy1NbMIHS8zxQhnASBf8Ax9/ZzrhuAi9u4YuGAeG8Qj?=
 =?us-ascii?Q?OYlQX7ykbHqJZE7WiAsKmjSE4JrOcatpJnlEl6tx2pweB2B3XsDM0Xrrqpgd?=
 =?us-ascii?Q?EHsWJqocj2IY0meLKVZ28LKkgTROV4n7JJGcF/Y//eum8Y++rqRhrfO1QbVq?=
 =?us-ascii?Q?Q4Awq3r3p/zyj8K6oEq16ZItr7eaVKTG/7iw72BDh1mGpgMUB+6Iz+t1Qpwu?=
 =?us-ascii?Q?+a6ZldAUdnaaW50qkf+7QFS+RP+3RQ8GRv4Y/J5O3pUCAC8BPGL7wWjcgZBW?=
 =?us-ascii?Q?DZaREiHy6SYKH45ANOpiQsT8umAJYJxrbTapQ00Z9TbU6Z6qgOKxNd/EJub1?=
 =?us-ascii?Q?X188Nd5Rzf40VNE/E3zP4K0zyG14W/2gN3trOHlIllr4SpSGmqfsEYOR2oyg?=
 =?us-ascii?Q?AgP/buPRTLHTNm/FCJ6y8p2FCED/Pa4AgVJ/aknzcKBkTM3N6sVGBpdjmTA/?=
 =?us-ascii?Q?QRCkVSolS5J6HAg7D0bEg+El0y8bTZWE0Xf6CcsVIH+NbYl3HXJHUkFu+RwC?=
 =?us-ascii?Q?Z12CLtlmeE+NfPtKWgXsUzmcVaVkF8cCAKsLwImB7d4dwqh3A/S6hS8lzGps?=
 =?us-ascii?Q?dZjzrdSpKsthY++YcUxOjOn//toq6j7ZAtlK5iCGUXgN5lUlyqaaSHpbN47X?=
 =?us-ascii?Q?Rug5xsKcl93RaXe4efhE3yTrkEZ5RoPz3bdW9tNtBaQjI7Yw4pqu31LkHQQ3?=
 =?us-ascii?Q?VCiVob0prAZQLUsx60PyxQ29vAiP4adYUW2gdWOaO0qMOg7GrYe56YJWcy+p?=
 =?us-ascii?Q?vUjw3JwpwpMHjAUWayOV6H3VGD9c2GoOPmxVffslDNkAnSHQMtkLP2ofGT4G?=
 =?us-ascii?Q?50rYl/7iSCckwTh0qBWI4/xi7eYkwUtFyInh3YIOLLebVQiHZywI7tcnWNd3?=
 =?us-ascii?Q?SJle0LBOib2rJVVT/5yLkyMtYBuKs5GHDfov++yXdOe9WVL/7dPoeuW0OiAj?=
 =?us-ascii?Q?5i5plfMcdYO5QyWLy/ct4fo8eex5XR8tG+Qji8/3qm88fPpI68WS5hn8aFIe?=
 =?us-ascii?Q?Xz5w399IQQKzHF04q66tyM5/fYTHVwqmdZfkJEeBq8JU5ggKG8+WVcsIBEQl?=
 =?us-ascii?Q?wBZVosWqYHKJ+mHyVaBKKJghgLdeaP+MzzopGsIYSYau05YmTyL61uMtFBZl?=
 =?us-ascii?Q?Gwah3hIlZu6Y0ucOsQLahWqpRL56zypQi4QfO5sMbjAdnKw/7Sy9Q/aEtDqr?=
 =?us-ascii?Q?fWG5DG7epwUpbhB94z2jT1d5yQHqoIrJw1JaDmcX96TzJFDUYBrFLxd1A3H+?=
 =?us-ascii?Q?LfWkCsBmyDL9CHhVv4Rm4TP47yRCCe8doKPw3h3+GVtcL0BdAWc/C77u3de8?=
 =?us-ascii?Q?4hKxuBCMyzxcGrMWV4qbCnFSBTJXwUn/DKhtj66k?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?JF+KSfut4vIyOCKBoQeiIZt7QJkjKVlIMh+n9/rzC5p6+KkoRIgjBfYajcVY?=
 =?us-ascii?Q?dongZoz2/MAjfY0dKsXO33qrBb3xJUh/RYN/K1EulH/PDXOvAjEXFHuz8N0/?=
 =?us-ascii?Q?wnRnVb8BK3bK9ekWGdCpUiVsFlSCg3RLxZkPfBhqMHXdi3UwvO0DA9zfffiO?=
 =?us-ascii?Q?lrTx+Nr3byhozAPM4HDKt/t9SeV5QVSxb6KPYd+Pad8akdfTMj7TKU1bhs29?=
 =?us-ascii?Q?aNcHRBWkexhCV590SnH9mfATZsEs6OKTZ5wfAvjUng7QMnVtTRejVwjtAFsn?=
 =?us-ascii?Q?jQYeyf7YGUTO9C9TuAKPJPgcBZCMfZzMlab51h95bVKi/umlqlNfslqqv33l?=
 =?us-ascii?Q?JEL3QYSft0ZGcJXfBzIY9U+QbJUO/bP6B/tXfdXrq5150ZNQv0jBuIH/9bJR?=
 =?us-ascii?Q?6x/08/qfops8g6Pb3mF7sYSkY4jZcyo9pYsKXWULILXN6sDXXgfQjM9EhneA?=
 =?us-ascii?Q?RXceYd9rT3mrbTqUZsJFu2VdD7HeDiQnDcerrJRriSLd1/94zStGkHfgaF+2?=
 =?us-ascii?Q?nrJzfic+HTzXbolcVopI3GlJxV69qrbju7t+iJvTAdx+Nyul+AHQE42QJnIk?=
 =?us-ascii?Q?os5Yku62tbImIXo/wZ4WOXUU42wD92vlUpqA6JRKvwvrqa9Hqd/0KK3EbfhV?=
 =?us-ascii?Q?1b3ubaIUfsYPn0wcPoeoxOzrrUFoWT3nQG5Hyhl9vb2e1GGkexF4fWlHOAn/?=
 =?us-ascii?Q?u7+AmMLOaHlCjRJxCvc0PJgvokr/miQFDighdkHx0swMzzuGKxHZpMm2ulnE?=
 =?us-ascii?Q?ihktWrQOJjqhsDD5BWPzkGesLUUef1+idCCR/0W/91FqhRRAevmrx+evQDR6?=
 =?us-ascii?Q?hbbGbeodadyyHC/LbGPuefow68+bwm/tbaRtdHofg4qk4xpK90nYqS6RP8UN?=
 =?us-ascii?Q?0fLPjJWFNb0STCwE1IBJXBJxDPrDmsyDeHM+G8JIuW8p0Du7AYgYFOsHnRTL?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 59922b77-f9c3-4263-9a92-08db6b8e3702
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 21:44:35.8555
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ITGfuvwI+KdHk8v5YCV86/q/QknbbIdvGdJUNDnMbbU+zsxP5bj/dqoreYLVrqYeOVg3H7nee6K8cnJC9VzRrg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7414
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-06-12_16,2023-06-12_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 phishscore=0
 mlxscore=0 suspectscore=0 malwarescore=0 mlxlogscore=858 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000
 definitions=main-2306120186
X-Proofpoint-ORIG-GUID: MjbcoNgTOHJbdM7HrV3Ia44UDPcAyw5j
X-Proofpoint-GUID: MjbcoNgTOHJbdM7HrV3Ia44UDPcAyw5j
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/12/23 17:35, Peter Xu wrote:
> Hi, Mike!
> 
> On Mon, Jun 12, 2023 at 01:44:18PM -0700, Mike Kravetz wrote:
> > Agree with this change.  But, it does make one wonder if the pud_clear()
> > in huge_pmd_unshare is safe.  Like here, we really should be holding the
> > higher level lock but are holding the PMD lock.
> 
> The vma write lock?  My memory tells me that you worked on the vma lock and
> one major reason was for that, but maybe I missed something?
> 
> I did check again and all call sites should have that lock held, which
> looks fine here.  One thing worth mention is pmd unshare should also always
> be gup-fast-safe because it never really releases the pgtable, unlike thp
> collapse.

Yes, Duh!

In the unshare case we KNOW what is mapped (the vma) via the PUD.  So,
we certainly am synchronized with that access.  I was just trying to
imagine some other situation where we may be walking the page table
without the vma lock held.  However, you already took care of those call
sites.

Thanks!

You or Andrew can add,

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>

-- 
Mike Kravetz