Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230609-khugepage-v1-1-dad4e8382298@google.com>
In-Reply-To: <20230609-khugepage-v1-1-dad4e8382298@google.com>
From:   Yang Shi <shy828301@gmail.com>
Date:   Mon, 12 Jun 2023 14:59:28 -0700
Message-ID: <CAHbLzkr4cf7XqsCR29_-qLysuELaaFvThJ3eoNd-nvkhVdKrYg@mail.gmail.com>
Subject: Re: [PATCH] mm/khugepaged: use DEFINE_READ_MOSTLY_HASHTABLE macro
To:     ndesaulniers@google.com
Cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jun 9, 2023 at 4:44=E2=80=AFPM <ndesaulniers@google.com> wrote:
>
> These are equivalent, but DEFINE_READ_MOSTLY_HASHTABLE exists to define
> a hashtable in the .data..read_mostly section.
>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>

Reviewed-by: Yang Shi <shy828301@gmail.com>

> ---
>  mm/khugepaged.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/khugepaged.c b/mm/khugepaged.c
> index 6b9d39d65b73..e7dc49214413 100644
> --- a/mm/khugepaged.c
> +++ b/mm/khugepaged.c
> @@ -88,7 +88,7 @@ static unsigned int khugepaged_max_ptes_swap __read_mos=
tly;
>  static unsigned int khugepaged_max_ptes_shared __read_mostly;
>
>  #define MM_SLOTS_HASH_BITS 10
> -static __read_mostly DEFINE_HASHTABLE(mm_slots_hash, MM_SLOTS_HASH_BITS)=
;
> +static DEFINE_READ_MOSTLY_HASHTABLE(mm_slots_hash, MM_SLOTS_HASH_BITS);
>
>  static struct kmem_cache *mm_slot_cache __read_mostly;
>
>
> ---
> base-commit: 64569520920a3ca5d456ddd9f4f95fc6ea9b8b45
> change-id: 20230609-khugepage-09ea340b378e
>
> Best regards,
> --
> Nick Desaulniers <ndesaulniers@google.com>
>
>