Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230610034114.981861-1-linmiaohe@huawei.com>
In-Reply-To: <20230610034114.981861-1-linmiaohe@huawei.com>
From:   Yang Shi <shy828301@gmail.com>
Date:   Mon, 12 Jun 2023 14:57:58 -0700
Message-ID: <CAHbLzkpnkZwmbigEp19dH+Q1tH_VWs6fuivKY=nNY7aUmTfEsg@mail.gmail.com>
Subject: Re: [PATCH] memory tier: remove unneeded !IS_ENABLED(CONFIG_MIGRATION)
 check
To:     Miaohe Lin <linmiaohe@huawei.com>
Cc:     akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jun 9, 2023 at 8:41=E2=80=AFPM Miaohe Lin <linmiaohe@huawei.com> wr=
ote:
>
> establish_demotion_targets() is defined while CONFIG_MIGRATION is
> enabled. There's no need to check it again.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

Reviewed-by: Yang Shi <shy828301@gmail.com>

> ---
>  mm/memory-tiers.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
> index dd04f0ce5277..a516e303e304 100644
> --- a/mm/memory-tiers.c
> +++ b/mm/memory-tiers.c
> @@ -366,7 +366,7 @@ static void establish_demotion_targets(void)
>
>         lockdep_assert_held_once(&memory_tier_lock);
>
> -       if (!node_demotion || !IS_ENABLED(CONFIG_MIGRATION))
> +       if (!node_demotion)
>                 return;
>
>         disable_all_demotion_targets();
> --
> 2.27.0
>
>