Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <499ded51-3fb8-f11b-8776-08ab2e9a8812@infradead.org>
Date:   Mon, 12 Jun 2023 16:43:09 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH v4 11/11] blksnap: Kconfig and Makefile
Content-Language: en-US
To:     Sergei Shtepa <sergei.shtepa@veeam.com>, axboe@kernel.dk,
        hch@infradead.org, corbet@lwn.net, snitzer@kernel.org
Cc:     viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org,
        dlemoal@kernel.org, wsa@kernel.org,
        heikki.krogerus@linux.intel.com, ming.lei@redhat.com,
        gregkh@linuxfoundation.org, linux-block@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org
References: <20230609115858.4737-1-sergei.shtepa@veeam.com>
 <20230609115858.4737-11-sergei.shtepa@veeam.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20230609115858.4737-11-sergei.shtepa@veeam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/9/23 04:58, Sergei Shtepa wrote:
> diff --git a/drivers/block/blksnap/Kconfig b/drivers/block/blksnap/Kconfig
> new file mode 100644
> index 000000000000..14081359847b
> --- /dev/null
> +++ b/drivers/block/blksnap/Kconfig
> @@ -0,0 +1,12 @@
> +# SPDX-License-Identifier: GPL-2.0
> +#
> +# Block device snapshot module configuration
> +#
> +
> +config BLKSNAP
> +	tristate "Block Devices Snapshots Module (blksnap)"
> +	help
> +	  Allow to create snapshots and track block changes for block devices.
> +	  Designed for creating backups for simple block devices. Snapshots are
> +	  temporary and are released then backup is completed. Change block

	                             when backup is completed.

or is the order of operations as listed: release snapshots and then backup
can be completed?

> +	  tracking allows to create incremental or differential backups.

-- 
~Randy