Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp563392rwd; Mon, 12 Jun 2023 18:53:41 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ51DmtRvbEcjCadURY2Kn0KgzklxRnf/NC8ty7Vefb5gK6dtRXEEFe1QmHkpideDIcvxMRu X-Received: by 2002:aa7:dad4:0:b0:514:a376:9e12 with SMTP id x20-20020aa7dad4000000b00514a3769e12mr5261828eds.26.1686621221595; Mon, 12 Jun 2023 18:53:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686621221; cv=none; d=google.com; s=arc-20160816; b=pZ7CDgRmiwr68FzsBPfh0/BkLhyc26PWMO0goo5ZeG234g2tLcACf/hlKkRR4LRHtl /RzOK9VPIljfBDB1rPO9MCJkZAApF2htVDdmdoj5/S7WWvMHuEkYSUS/z3OW6bv4woE9 3TsSSb6uEQMKUSAYttUkpL3jAxI7ejmVsDJzwz5EN3lBWc+DTNKLZZlg2lg/8KNBhq+M IXsKeeOZKmnnPkndfFVbKsZP+QkiDZfUQ/kF9zbQhV/FbPok/N6R/NYVqhdgKbeY3/Lw gJfcMT9bk8Bd6AgPdNwbKWUUlRIXuNKkIxxgcNSUw2GEbTHqFOgMP5729Vk3m205yjb7 QF6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:date:to:cc:from:subject:references :in-reply-to:content-transfer-encoding:mime-version:message-id :dkim-signature; bh=nMTjj6z1aJO7b2UchCOr1ylRwdXqGyT5I/GFrTW51Q8=; b=uHQArPpOc/F2AsBjkSdYN4mXrDVqH5VLCF+0HcaPAx6/k495jh0a8CiN5RxTz2E8EQ RT7MW53yfvQ9Via7Sw/c1AFXWvX8CqY1IEtde8lmALs15owwsN7tYyIpwV/esg5dI58R UZCDgXY5nVVh4pkJ0dW37Som8629zm8EAVFUBvrxw3TeTm5z++LcskxGbqc6dNN1haHS TgeUrPGzt8kMKCo4y2YCC5Rg2It0sk5T0GaY5P+NH7wpFj4r6xEVc/9rrNKlWOo3Z1qf zzqplt1FXUKGtmOeXkztpjDYtxKK8S5gZE4ToJGndtAxGI447vmlg893HacyIYAUFlxY 8VUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nOnXZOmR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x24-20020aa7dad8000000b0050d0ddf6582si6707728eds.474.2023.06.12.18.53.17; Mon, 12 Jun 2023 18:53:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nOnXZOmR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235711AbjFMBUp (ORCPT + 99 others); Mon, 12 Jun 2023 21:20:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236433AbjFMBUn (ORCPT ); Mon, 12 Jun 2023 21:20:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6AA21728; Mon, 12 Jun 2023 18:20:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 20F8A62E74; Tue, 13 Jun 2023 01:20:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78FA9C433D2; Tue, 13 Jun 2023 01:20:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686619237; bh=nMTjj6z1aJO7b2UchCOr1ylRwdXqGyT5I/GFrTW51Q8=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=nOnXZOmRkf9MNLKNySEhayFAHH2rHoxjPb86DdV9ltPb7lKLIk8d7FGOFfc/KaF2C 2d0eHk7oelFeUWpq3nKquDWvEK4f+B+7Oo6O4ulsqTW+u3gQHlnZMg7zvdtnSPO+iW /ADiUs6uvJR7v7E2sq70y2WC5sBtd7ifMizL4cfNPZnSP5v2411FNnklcZYNU5REuq TNllPv7pAjNDkRipPwlm5Wf2JFHog0V24m/Lq7R2UksjlwZh5hmYG7JVG7/pzFbs1w 8E8mExKmmyeod3AlK7UDqLgxirLDrNHBY0Rg8VstL0STBd30GNtCd03D8RDTMoUQX9 QTOHQpnASS4JQ== Message-ID: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230516135205.372951-3-angelogioacchino.delregno@collabora.com> References: <20230516135205.372951-1-angelogioacchino.delregno@collabora.com> <20230516135205.372951-3-angelogioacchino.delregno@collabora.com> Subject: Re: [PATCH v2 2/2] clk: mediatek: Remove CLK_SET_PARENT from all MSDC core clocks From: Stephen Boyd Cc: matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, wenst@chromium.org, chun-jie.chen@mediatek.com, mandyjh.liu@mediatek.com, miles.chen@mediatek.com, zhaojh329@gmail.com, daniel@makrotopia.org, nfraprado@collabora.com, rex-bc.chen@mediatek.com, Garmin.Chang@mediatek.com, msp@baylibre.com, yangyingliang@huawei.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com To: AngeloGioacchino Del Regno , mturquette@baylibre.com Date: Mon, 12 Jun 2023 18:20:35 -0700 User-Agent: alot/0.10 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting AngeloGioacchino Del Regno (2023-05-16 06:52:05) > Various MSDC core clocks, used for multiple MSDC controller instances, > share the same parent(s): in order to add parents selection in the > mtk-sd driver to achieve an accurate clock rate for all modes, remove > the CLK_SET_RATE_PARENT flag from all MSDC clocks for all SoCs: this > will make sure that a clk_set_rate() call performed for a clock on > a secondary controller will not change the rate of a common parent, > which would result in an overclock or underclock of one of the > controllers. >=20 > Signed-off-by: AngeloGioacchino Del Regno > Reviewed-by: Matthias Brugger > Reviewed-by: Markus Schneider-Pargmann > --- Applied to clk-next