Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8b0376be-fbee-f4ad-c0d8-f12471fab7ae@gmail.com>
Date:   Tue, 13 Jun 2023 10:19:52 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v13 08/10] clk: nuvoton: Add clock driver for ma35d1 clock
 controller
Content-Language: en-US
To:     Stephen Boyd <sboyd@kernel.org>, catalin.marinas@arm.com,
        gregkh@linuxfoundation.org, jirislaby@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, lee@kernel.org,
        mturquette@baylibre.com, p.zabel@pengutronix.de,
        robh+dt@kernel.org, tmaimon77@gmail.com, will@kernel.org
Cc:     devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-serial@vger.kernel.org, arnd@arndb.de, soc@kernel.org,
        schung@nuvoton.com, mjchen@nuvoton.com,
        Jacky Huang <ychuang3@nuvoton.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
References: <20230605040749.67964-1-ychuang570808@gmail.com>
 <20230605040749.67964-9-ychuang570808@gmail.com>
 <bda5f640831a8080a83eca8c8e37c30d.sboyd@kernel.org>
 <233f4e83-e872-5499-2ca7-a1c277425fb0@gmail.com>
 <b4a20267862f6cd20d50016cb130ba95.sboyd@kernel.org>
From:   Jacky Huang <ychuang570808@gmail.com>
In-Reply-To: <b4a20267862f6cd20d50016cb130ba95.sboyd@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2023/6/13 上午 10:16, Stephen Boyd wrote:
> Quoting Jacky Huang (2023-06-12 18:37:31)
>> On 2023/6/13 上午 09:02, Stephen Boyd wrote:
>>> Quoting Jacky Huang (2023-06-04 21:07:47)
>>>> diff --git a/drivers/clk/nuvoton/clk-ma35d1-divider.c b/drivers/clk/nuvoton/clk-ma35d1-divider.c
>>>> +                                           int num_pdata)
>>>> +{
>>>> +       return clk_hw_register_mux_parent_data(dev, name, pdata, num_pdata,
>>>> +                                              CLK_SET_RATE_NO_REPARENT, reg, shift,
>>>> +                                              width, 0, &ma35d1_lock);
>>>> +}
>>>> +
>>>> +static struct clk_hw *ma35d1_clk_mux(struct device *dev, const char *name,
>>>> +                                    void __iomem *reg, u8 shift, u8 width,
>>>> +                                    const char *const *parents, int num_parents)
>>> Please don't use string arrays for parent descriptions. Everything
>>> should use clk_parent_data or direct clk_hw pointers.
>> I will use clk_parent_data instead of strings.
>>
> When you use clk_parent_data, just don't set anything for the "dummy"
> clks besides a -1 .index to indicate there isn't a parent for that
> entry.


Okay, thank you for the reminder.

Best Regards,
Jacky Huang