Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Lu Hongfei <luhongfei@vivo.com>
To:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Moudy Ho <moudy.ho@mediatek.com>,
        Deepak R Varma <drv@mailo.com>,
        Arnd Bergmann <arnd@arndb.de>, Sun Ke <sunke32@huawei.com>,
        Lu Hongfei <luhongfei@vivo.com>,
        linux-media@vger.kernel.org (open list:MEDIA INPUT INFRASTRUCTURE
        (V4L/DVB)),
        linux-kernel@vger.kernel.org (open list:ARM/Mediatek SoC support),
        linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC
        support),
        linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC
        support)
Cc:     opensource.kernel@vivo.com
Subject: [PATCH v2] media: platform: mtk-mdp3: Fix resource leaks in mdp_get_subsys_id()
Date:   Tue, 13 Jun 2023 10:55:06 +0800
Message-Id: <20230613025515.24512-1-luhongfei@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nWhv4lchVax53ZjlVwP6qvuAyNl1CDqjjZmgpgO+07dNrng3yl/BKNTXSHKO?=
 =?us-ascii?Q?AxyBnQMYjanSRdJm2ZbOmBObksnUKuYgB+YOdWAnlKrU9lpX//TILq+Jk+At?=
 =?us-ascii?Q?kaNhs/Hhz8KjgmEhSWaV6jCyJCR6U1arHlXWln3+phY5AmSTTgPjYBZgowPS?=
 =?us-ascii?Q?OMta1rjuVE42snGPR8gTBYtr8dt7e012LqwNXhQcYI/YrWWe24lR01C8iLzg?=
 =?us-ascii?Q?g9hkQHoR91vxcIvWLxc50LLkvs2aP/5uZV4OBxmB6bzh81S1jLUx0vKuQq9O?=
 =?us-ascii?Q?bKQ+Moojzgy1q4nEP4YsY0tE8ltxCqGKOJsXDGKKDLxQqyq3GAe4rHpCjF5q?=
 =?us-ascii?Q?ICa3MmYF+/8JuGZsQX/WdXcJvEj2mjueYLpQMjWwAfDzgeSOV+XvhEtkIMBP?=
 =?us-ascii?Q?kPsPHQRWleQ4ioZshBCKbLOLMNnU6qtZ9G7rEklOUzoProfbLeBAkn3NUtzC?=
 =?us-ascii?Q?1eMcPXStNzen6AUvOi/tWOjOPA9KTB1CrMrNIdXZpS9/VrEY4/mVRjybc8zp?=
 =?us-ascii?Q?73+A4NOkhiB499Io8PH5K2a8bfxejybCAWs3pTLayry6/1lWu8nD3v1WpBcZ?=
 =?us-ascii?Q?ZRe2MntYqO4+EKe3o5NQrbEZtCAxAEJOt58/hAAexzAjuMyzAPxlbM+OVs7C?=
 =?us-ascii?Q?N6CG43nhEyD6RybPvBG7be1oTrwP2d4VUXdzBgL7XtvqfWUIQ/PF1NNzvLSe?=
 =?us-ascii?Q?4Oy3hT+N4urtygu2rRpTp+3SHKSxTeMNzL/rogjdsXZ6Nzxn6tBXfGtUq9/L?=
 =?us-ascii?Q?E79ANuFlNls4C4pXueTJFAolRIl/MlTHVsELyeeXfyOl6nw2n1EPD3rLp93d?=
 =?us-ascii?Q?nanuKI1PuiRDUXAxQVX5WglnLmU9OkWY1rgs5p3wxrixIpKov1N6OggsS++g?=
 =?us-ascii?Q?TYEOEcg1ya/aLjfn7soryPDFIJJOmoeN+aP7f9YxM9OvCcRyzB52fHekZnf3?=
 =?us-ascii?Q?Rl6aJnrBWv8LUmDabJRT4zR3p2NflIHr5iDUORdPS5g17vuYf5eYkjRvz+nB?=
 =?us-ascii?Q?MU1epamsNa6ybgXBbXEaVqBwTlJPjoATqFDUxhhJXRpTXc4PdNsqmQevdjuV?=
 =?us-ascii?Q?qMdj3/VvjLKTYLy3hXqEiaQbvsdHN85qS28hEuG1RK4g4TrG0YpsM63sUmOh?=
 =?us-ascii?Q?jWnFVVk1TRy99wikOtrP0s/nttUQK8x2K5EAgipt8JzEjJTyXgaxstagDnIG?=
 =?us-ascii?Q?nB9Q+GgpFUGEUZ/h+mWy9VT3zbPcaMkEj3mJyPRP46g9WukSQOXEAhmhZgBt?=
 =?us-ascii?Q?TcOZTWG1ziesYQBUMs4a8EAYk4XiMQZSqiwf5snAdQ8Vb4R9ovDcCMdVoQ5i?=
 =?us-ascii?Q?gO+icpvJCB0du5K4xjv/Ke2Ji0Ao2pXxLAc008O1/5KKsDXdKkWYxkdJS5WY?=
 =?us-ascii?Q?Wdf8H4Ych6vhbkSB8BBoSmEUYMBi8X5p0Anq6j57BlBcU1SQwTuXwenT0C3J?=
 =?us-ascii?Q?+0KeGP37ceKWanLfixG5+f2bv1IYZ3SQh8LcEp8gdBnl09fH0/3Yqcr+BUT2?=
 =?us-ascii?Q?/AWZfsHDr6GBuvHW8uWDEgINRlekD+8huEoA92aAdXzea0TVBkOMIFG4IqCg?=
 =?us-ascii?Q?hhycAYynnMSlqTIfhgYwWiw8EWBgnt+hw3NeAZ9f?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d3884ec1-da1a-4fe4-0990-08db6bb9a336
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB6697.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 02:55:25.6574
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b4JkDjssdTeHaI9mRyTwhEn0oqEQ1VbcodUKYMQu6WR+mI3i2sVzqo3hX0rLtEBIQq+ad6np21wpdCSTyFuE4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6418
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Add a put_device() call for the release of the object
which was determined by a of_find_device_by_node() call.

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
---
The modifications made compared to the previous version are as follows:
1. Modified the patch subject
2. Modified the commit message to make it easier to understand.
3. Use an additional label "put_device". Increase the usage of the variable "ret".

 drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
index a605e80c7dc3..ec39662a2282
--- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
+++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
@@ -892,13 +892,16 @@ static int mdp_get_subsys_id(struct mdp_dev *mdp, struct device *dev,
 	ret = cmdq_dev_get_client_reg(&comp_pdev->dev, &cmdq_reg, index);
 	if (ret != 0) {
 		dev_err(&comp_pdev->dev, "cmdq_dev_get_subsys fail!\n");
-		return -EINVAL;
+		ret = -EINVAL;
+		goto put_device;
 	}
 
 	comp->subsys_id = cmdq_reg.subsys;
 	dev_dbg(&comp_pdev->dev, "subsys id=%d\n", cmdq_reg.subsys);
 
-	return 0;
+put_device:
+	put_device(&comp_pdev->dev);
+	return ret;
 }
 
 static void __mdp_comp_init(struct mdp_dev *mdp, struct device_node *node,
-- 
2.39.0