Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Markus Burri <markus.burri@mt.com>
To:     linux-kernel@vger.kernel.org
Cc:     Markus Burri <markus.burri@mt.com>,
        Alexandru Tachici <alexandru.tachici@analog.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Michael Hennerich <Michael.Hennerich@analog.com>,
        Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Subject: [PATCH v1] iio: ado: ad7192: Add error check and more debug log
Date:   Tue, 13 Jun 2023 07:42:51 +0200
Message-Id: <20230613054250.472897-1-markus.burri@mt.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fFXFycRGTcBjuNEJbOIpMRd1/T+ewT//jP5Fg/QL9JN2wZ6kPHrPas7ifM2h?=
 =?us-ascii?Q?uyQ+2GIy1HEFUhWUuCSrE8GcKzVH337/wLhLDUZWZ65kmCCNoq3AqYiWh5ah?=
 =?us-ascii?Q?Zkn6OordF8iDYMsFzWresb/lCzQOex0AwXlLTRidwpXV3tsbjFrfKH6wOEil?=
 =?us-ascii?Q?K2RUcQobj/3Jp+krQysoxCR5/uoAfOkNpzUPh9kw+JLqyDMdVLUn0vYlg8ph?=
 =?us-ascii?Q?vmGxdTvYtTYf3ABCPSnjbWneFd7vQOYg8CFjn1Y1k25433uhqqZXlWnES011?=
 =?us-ascii?Q?5S7aXEewS8lus0Ewa+GHOfIvgWxgQWUtxUEhlABvmOsPjA/VGh8UzSTfwT1Q?=
 =?us-ascii?Q?XicD+YsfqEHeTjw9zQjVpjC52SdAizK8le42FAZlAtOhPB5LvkMlBnJTIzKJ?=
 =?us-ascii?Q?cF3BzdB9XvF13n0BJkPrge7l5ocuBCkcDgujHln6ceFW6v0UGRmLPA4YvJRK?=
 =?us-ascii?Q?f6YBra1EFg4Yfd8omVB7iV2KQLR7zG0HGvQCpB9wKDv8BNOvPQrexVLBkvUN?=
 =?us-ascii?Q?fElv4+Xxe1dpMlMhTEUIOrSBfJjGFhkmAJ6f3qRSqT4OD+VJpygnAShGB2sS?=
 =?us-ascii?Q?R3siIJVCkRV0f6dQZWrD/ze+2QDyFqENdcjSa+Z7GbF0y9B8PIm28ZkiF5Qa?=
 =?us-ascii?Q?GZbBziuCmu6KQwf3FZE5NJG8w3Hrw6rfj2f5SsmtcEcso4O0/Y40sLtIVvqr?=
 =?us-ascii?Q?IJtWYNpzowg5DAFz4dLtxot4Lu+TZQ8LwjeyrELSO9TTME3ce2UUNbk2xjM+?=
 =?us-ascii?Q?D14bEnsywHkoSAPa/CO0YBjU1AYQ2Rmt1qBs3srpqPL6uqy+hGaaKz6diddn?=
 =?us-ascii?Q?jovseeCnkCQLA+qIcDm6E8Y7eE+lc77xIfPeEBHJUvp0ztJ/i+hy/N7Izwbc?=
 =?us-ascii?Q?r3BbsixDwe8qfUmurzKE/XGskZ3upYpL/PZZG6XfDzC2cLBQopqhguWSKtKZ?=
 =?us-ascii?Q?nZxfYu9JdYhvlUyVWq6kvVDRT8rrsSannAI9nJgjlF4Jbbkb93FZ2Z6Nc/BU?=
 =?us-ascii?Q?P0Gc4JMwsn/1AR/q5h0/w+6qvJNx9nLIHZnUyVhSbOmPvmfRyoY9kn8IdRmv?=
 =?us-ascii?Q?nxpUbBAhg8R6LF/3kRqtwmA8noR7l3zmV8tLFQ8Ob8DgCjD3dPF5mYJIPB8k?=
 =?us-ascii?Q?BHOSPEfDNurAgQLXr2CT5BxoSS3waYIIN7fekTqtPOH3OmAo4I95YWifQir2?=
 =?us-ascii?Q?GHK6ouykb97Zvyvw8dWdYvYdOBSaNz28wG1Kshnk5iErq8yL00laarONbfUe?=
 =?us-ascii?Q?j8jUXzPx10Cf3gfZaD4fE3S5DJmhoI9al08XAatdTaRLs9mhdTm6YHMZQPPH?=
 =?us-ascii?Q?A60pP/AgQJLOyL9xfp7m7vd+ar2xXjV5AZxHzJL7oE8LPtS/qYrqZhl9g5zm?=
 =?us-ascii?Q?mND7anZ8B1niRGfKBHnPxAHm8vPpCxMn2z/aKrjG9RipE3u+Q/b7V+35Y4gJ?=
 =?us-ascii?Q?m/3/b+0ZJJIGu+8tj8kzo8LHN8ByNwop5G4grtG1KoznOKqqCKXxIjymOqik?=
 =?us-ascii?Q?mBKZtPpH38c6Dp1MD309807OcmLKdz8KsZqBgmAXj6dmb9sRmYDTCOmTW1RZ?=
 =?us-ascii?Q?t05robbYUd9xCVJeaC211De22JKmLp0G9RyLVr7b?=
X-OriginatorOrg: mt.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0fa4a7d4-9bfb-4a4b-fbc0-08db6bd1357e
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7488.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 05:44:09.4081
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fb4c0aee-6cd2-482f-a1a5-717e7c02496b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sYn1GNBjWhatlW05nvxohSL+vqz1/LicnsE7dkaqtbdhPhka+kwD2Tu1BlD/krDL4Wn9gRvFiCk3/xaT2tiHQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB9094
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Print read and expected device ID as debug warning.
Add error check for ad_sd_init() result.

Signed-off-by: Markus Burri <markus.burri@mt.com>
---
 drivers/iio/adc/ad7192.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c
index d71977b..220c3b7 100644
--- a/drivers/iio/adc/ad7192.c
+++ b/drivers/iio/adc/ad7192.c
@@ -403,8 +403,8 @@ static int ad7192_setup(struct ad7192_state *st, struct device_node *np)
 	id &= AD7192_ID_MASK;
 
 	if (id != st->chip_info->chip_id)
-		dev_warn(&st->sd.spi->dev, "device ID query failed (0x%X)\n",
-			 id);
+		dev_warn(&st->sd.spi->dev, "device ID query failed (0x%X != 0x%X)\n",
+			 id, st->chip_info->chip_id);
 
 	st->mode = AD7192_MODE_SEL(AD7192_MODE_IDLE) |
 		AD7192_MODE_CLKSRC(st->clock_sel) |
@@ -1049,7 +1049,9 @@ static int ad7192_probe(struct spi_device *spi)
 	else
 		indio_dev->info = &ad7192_info;
 
-	ad_sd_init(&st->sd, indio_dev, spi, &ad7192_sigma_delta_info);
+	ret = ad_sd_init(&st->sd, indio_dev, spi, &ad7192_sigma_delta_info);
+	if (ret)
+		return ret;
 
 	ret = devm_ad_sd_setup_buffer_and_trigger(&spi->dev, indio_dev);
 	if (ret)
-- 
2.39.2